Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String guide improvements #16824

Closed

Conversation

steveklabnik
Copy link
Member

A few steps toward #15994


This does not compile. This is on purpose. In the world of UTF-8, direct
indexing is basically never what you want to do. The reason is that each
charater can be a variable number of bytes. This means that you have to iterate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/charater/character/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@steveklabnik
Copy link
Member Author

Updated!

@steveklabnik
Copy link
Member Author

Fixed the failing test

bors added a commit that referenced this pull request Sep 10, 2014
@bors bors closed this Sep 10, 2014
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 17, 2024
minor: Fix unwanted leading whitespace in hover text

PR rust-lang#16366 moved layout information to a separate line, so the leading whitespace is no longer necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants