Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #21356 #21366

Closed
wants to merge 2 commits into from
Closed

Fix #21356 #21366

wants to merge 2 commits into from

Conversation

aochagavia
Copy link
Contributor

Closes #21356

@aochagavia
Copy link
Contributor Author

r? @jdm

@jdm
Copy link
Contributor

jdm commented Jan 18, 2015

I'm not a reviewer for any code in Rust any longer, but thanks for fixing this :)

r? @cmr

@rust-highfive rust-highfive assigned emberian and unassigned jdm Jan 18, 2015
@emberian
Copy link
Member

r=me with backticks

@aochagavia aochagavia changed the title Macro ice Fix #21356 Jan 18, 2015
@aochagavia
Copy link
Contributor Author

@cmr Added backticks

@alexcrichton
Copy link
Member

@bors: r=cmr c8211e5c

@bors
Copy link
Contributor

bors commented Jan 19, 2015

🙀 You have a wrong number! Please try again with c821.

@alexcrichton
Copy link
Member

@bors: r=cmr c821e5c

@alexcrichton alexcrichton mentioned this pull request Jan 19, 2015
Closed
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 20, 2015
Merged
@aochagavia
Copy link
Contributor Author

Closed in favor of #21429

@aochagavia aochagavia closed this Jan 21, 2015
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jan 21, 2015
@alexcrichton
rollup merge of rust-lang#21429: GuillaumeGomez/macro-fix
28937be 
This is little clean code of this PR: rust-lang#21366. I patched the same thing as aochagavia but too slowly obviously. This is a merge of our two codes, more "rust-like".
@aochagavia aochagavia deleted the macro_ice branch February 13, 2015 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emberian emberian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ICE: unrecognized builtin nonterminal t_ty
5 participants
@aochagavia @jdm @emberian @alexcrichton @bors