Reference tidying #24548
Merged
Reference tidying #24548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ rollup |
|
📌 Commit a99a8b0 has been approved by |
|
❤️❤️❤️❤️❤️❤️❤️❤️👌👍 |
| @@ -3888,7 +3883,7 @@ Box<i32>, y: Box<i32>)` declare one mutable variable `x` and one immutable | |||
| variable `y`). | |||
|
|
|||
| Methods that take either `self` or `Box<Self>` can optionally place them in a | |||
| mutable slot by prefixing them with `mut` (similar to regular arguments): | |||
| mutable variable by prefixing them with `mut` (similar to regular arguments): | |||
There was a problem hiding this comment.
Actually I think the original word "slot" might be more accurate.
If I have to change "slot" to something I would use "binding" in this case.
See #24149
There was a problem hiding this comment.
Sure, binding is fine. Slot is just very old terminology, the only uses in this sense remaining are weird old corners of trans inside the compiler. In the docs it's a dead term, sticks out.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Apr 18, 2015
…labnik This just deletes some egregious lies and obsolete terminology -- all of which I originally wrote -- from the reference. I expect the reference itself will be deleted soon enough, but I found myself gritting teeth over these bits too much to let them into a 1.0 release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just deletes some egregious lies and obsolete terminology -- all of which I originally wrote -- from the reference. I expect the reference itself will be deleted soon enough, but I found myself gritting teeth over these bits too much to let them into a 1.0 release.