rustfmt librustc_front #28697

Merged
merged 1 commit into from Oct 6, 2015

Conversation

Projects
None yet
6 participants
@nrc
Member

nrc commented Sep 27, 2015

No description provided.

@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Sep 27, 2015

Collaborator

r? @jroesch

(rust_highfive has picked a reviewer for you, use r? to override)

Collaborator

rust-highfive commented Sep 27, 2015

r? @jroesch

(rust_highfive has picked a reviewer for you, use r? to override)

@jdm

This comment has been minimized.

Show comment
Hide comment
@jdm

jdm Sep 27, 2015

Contributor

https://github.com/rust-lang/rust/pull/28697/files?w=1 is a lot nicer to read than the default "Files changed" view.

Contributor

jdm commented Sep 27, 2015

https://github.com/rust-lang/rust/pull/28697/files?w=1 is a lot nicer to read than the default "Files changed" view.

@nrc

This comment has been minimized.

Show comment
Hide comment
@nrc

nrc Sep 28, 2015

Member

r? @brson

Member

nrc commented Sep 28, 2015

r? @brson

@rust-highfive rust-highfive assigned brson and unassigned jroesch Sep 28, 2015

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Sep 30, 2015

Contributor

☔️ The latest upstream changes (presumably #28702) made this pull request unmergeable. Please resolve the merge conflicts.

Contributor

bors commented Sep 30, 2015

☔️ The latest upstream changes (presumably #28702) made this pull request unmergeable. Please resolve the merge conflicts.

@nrc

This comment has been minimized.

Show comment
Hide comment
@nrc

nrc Sep 30, 2015

Member

Because the where clause is indented from the left + 4 which is the same indent as the body, without the newline brace it's hard to see where the signature ends and the body begins. Aligning the where clause with the arguments tends to overflow too often.

Member

nrc commented Sep 30, 2015

Because the where clause is indented from the left + 4 which is the same indent as the body, without the newline brace it's hard to see where the signature ends and the body begins. Aligning the where clause with the arguments tends to overflow too often.

@brson

This comment has been minimized.

Show comment
Hide comment
@brson

brson Sep 30, 2015

Contributor

@bors r+

Contributor

brson commented Sep 30, 2015

@bors r+

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Sep 30, 2015

Contributor

📌 Commit 9d34308 has been approved by brson

Contributor

bors commented Sep 30, 2015

📌 Commit 9d34308 has been approved by brson

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 2, 2015

Contributor

🔒 Merge conflict

Contributor

bors commented Oct 2, 2015

🔒 Merge conflict

@nrc

This comment has been minimized.

Show comment
Hide comment
@nrc

nrc Oct 5, 2015

Member

@bors: r=brson

Member

nrc commented Oct 5, 2015

@bors: r=brson

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 5, 2015

Contributor

📌 Commit 869e971 has been approved by brson

Contributor

bors commented Oct 5, 2015

📌 Commit 869e971 has been approved by brson

bors added a commit that referenced this pull request Oct 5, 2015

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Oct 5, 2015

Contributor

⌛️ Testing commit 869e971 with merge 32a8567...

Contributor

bors commented Oct 5, 2015

⌛️ Testing commit 869e971 with merge 32a8567...

@bors bors merged commit 869e971 into rust-lang:master Oct 6, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment