don't warn on casting byte strs to slices #34394

oli-obk · 2016-06-21T08:09:26Z

durka · 2016-06-21T14:44:57Z

src/librustc_const_eval/eval.rs

@@ -1116,6 +1116,7 @@ fn cast_const<'a, 'tcx>(tcx: TyCtxt<'a, 'tcx, 'tcx>, val: ConstVal, ty: ty::Ty)
            ty::TyRawPtr(_) => {
                Err(ErrKind::UnimplementedConstVal("casting a bytestr to a raw ptr"))
            },
+            ty::TyRef(..) => Err(ErrKind::UnimplementedConstVal("casting a bytestr to slice")),


Does this message replace the uninformative "cannot cast this type" when you do const INVALID: &'static [u8] = b"x" as &[u8];?

durka · 2016-06-21T14:45:33Z

LGTM but I am not a reviewer

durka · 2016-06-21T14:46:07Z

r? @eddyb

eddyb · 2016-06-21T14:52:11Z

@bors r+

bors · 2016-06-21T14:52:12Z

📌 Commit 0de72bb has been approved by eddyb

@durka

…r=eddyb don't warn on casting byte strs to slices r? @durka

@durka

…r=eddyb don't warn on casting byte strs to slices r? @durka

Rollup of 7 pull requests - Successful merges: #34190, #34363, #34367, #34383, #34387, #34394, #34404 - Failed merges:

don't warn on casting byte strs to slices

0de72bb

durka reviewed Jun 21, 2016
View reviewed changes

Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 22, 2016

Rollup merge of rust-lang#34394 - oli-obk:const_cast_false_positive, …

bbe0049

…r=eddyb don't warn on casting byte strs to slices r? @durka

Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 22, 2016

Rollup merge of rust-lang#34394 - oli-obk:const_cast_false_positive, …

c295a1c

…r=eddyb don't warn on casting byte strs to slices r? @durka

Manishearth mentioned this pull request Jun 22, 2016

Rollup of 7 pull requests #34408

Merged

bors added a commit that referenced this pull request Jun 22, 2016

Auto merge of #34408 - Manishearth:rollup, r=Manishearth

e41cdab

Rollup of 7 pull requests - Successful merges: #34190, #34363, #34367, #34383, #34387, #34394, #34404 - Failed merges:

bors merged commit 0de72bb into rust-lang:master Jun 22, 2016

oli-obk deleted the const_cast_false_positive branch June 22, 2016 14:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

don't warn on casting byte strs to slices #34394

don't warn on casting byte strs to slices #34394

oli-obk commented Jun 21, 2016

durka Jun 21, 2016

oli-obk Jun 21, 2016

durka commented Jun 21, 2016 •

edited

durka commented Jun 21, 2016

eddyb commented Jun 21, 2016

bors commented Jun 21, 2016

don't warn on casting byte strs to slices #34394

don't warn on casting byte strs to slices #34394

Conversation

oli-obk commented Jun 21, 2016

durka Jun 21, 2016

Choose a reason for hiding this comment

oli-obk Jun 21, 2016

Choose a reason for hiding this comment

durka commented Jun 21, 2016 • edited

durka commented Jun 21, 2016

eddyb commented Jun 21, 2016

bors commented Jun 21, 2016

durka commented Jun 21, 2016 •

edited