Add new error codes and improve some explanations #34467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
force-pushed
the
err-codes
branch
from
92ecaf9
to
9d0988d
Compare
| @@ -16,6 +16,8 @@ | |||
| register_long_diagnostics! { | |||
|
|
|||
| E0154: r##" | |||
| ## WARNING: Unused error code | |||
There was a problem hiding this comment.
Perhaps this can be clearer about what it means to be unused. As a warning this sounds like the user has done something wrong. What about something like 'Note: this error code is no longer emitted by the compiler.'?
GuillaumeGomez
force-pushed
the
err-codes
branch
from
9d0988d
to
58955de
Compare
|
Updated. |
|
@bors r+ |
|
📌 Commit 58955de has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jun 29, 2016
Add new error codes and improve some explanations r? @brson cc @steveklabnik cc @jonathandturner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @brson
cc @steveklabnik
cc @jonathandturner