-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated error format for E0069 #35351
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
return; | ||
//~^ ERROR `return;` in a function whose return type is not `()` | ||
//~| NOTE return type is not () | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for PR - Looks good, but can you remove this extra line?
@jonathandturner let me know if you want me to rebase this. |
@jaredwy - would you mind squashing the commits? |
hehe, good call. yes, please :) |
a4ada33
to
1cf5142
Compare
@jonathandturner hopefully good to go now. |
Looks good! @bors r+ rollup |
📌 Commit 1cf5142 has been approved by |
…dturner Updated error format for E0069 Fixes rust-lang#35219 which is part of the error bonanza at rust-lang#35233 r? @jonathandturner
Fixes #35219 which is part of the error bonanza at #35233
r? @jonathandturner