Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update E0214 to the new error format #35470

Merged
merged 1 commit into from Aug 10, 2016
Merged

Update E0214 to the new error format #35470

merged 1 commit into from Aug 10, 2016

Conversation

munyari
Copy link
Contributor

@munyari munyari commented Aug 7, 2016

Part of #35233

Addresses #35383
"r? @jonathandturner

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@sophiajt
Copy link
Contributor

sophiajt commented Aug 7, 2016

Looks good!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 7, 2016

📌 Commit f07f093 has been approved by jonathandturner

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 7, 2016
Rollup merge of rust-lang#35470 - munyari:e0214, r=jonathandturner
625a010 
Update E0214 to the new error format

Part of rust-lang#35233

Addresses rust-lang#35383
"r? @jonathandturner
@sophiajt sophiajt mentioned this pull request Aug 7, 2016
Closed
bors added a commit that referenced this pull request Aug 7, 2016
@bors
Auto merge of #35476 - jonathandturner:rollup, r=jonathandturner
8913330 
Rollup of 6 pull requests

- Successful merges: #35396, #35402, #35446, #35466, #35470, #35475
- Failed merges: #35395, #35415
@bors
Copy link
Contributor

bors commented Aug 8, 2016

⌛ Testing commit f07f093 with merge 613cdcc...

@bors
Copy link
Contributor

bors commented Aug 8, 2016

💔 Test failed - auto-win-gnu-64-opt

@alexcrichton
Copy link
Member

@bors: retry

  • not sure why...

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 8, 2016
Rollup merge of rust-lang#35470 - munyari:e0214, r=jonathandturner
0e4e8e9 
Update E0214 to the new error format

Part of rust-lang#35233

Addresses rust-lang#35383
"r? @jonathandturner
@sophiajt sophiajt mentioned this pull request Aug 8, 2016
Merged
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Aug 10, 2016
@steveklabnik
Rollup merge of rust-lang#35470 - munyari:e0214, r=jonathandturner
9c1e4cb 
Update E0214 to the new error format

Part of rust-lang#35233

Addresses rust-lang#35383
"r? @jonathandturner
@steveklabnik steveklabnik mentioned this pull request Aug 10, 2016
Closed
bors added a commit that referenced this pull request Aug 10, 2016
@bors
Auto merge of #35525 - jonathandturner:rollup, r=jonathandturner
1f2ae38 
Rollup of 15 pull requests

- Successful merges: #35371, #35396, #35446, #35449, #35452, #35458, #35465, #35466, #35470, #35475, #35477, #35484, #35504, #35507, #35524
- Failed merges: #35395, #35415
@bors bors merged commit f07f093 into rust-lang:master Aug 10, 2016
@munyari munyari deleted the e0214 branch August 11, 2016 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sophiajt sophiajt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@munyari @rust-highfive @sophiajt @bors @alexcrichton