Join GitHub today
small fix to closure debuginfo #38483
This is fallout from #37429. The faking we do to make closures appear to have local variables was broken and made it through CI because the debuginfo tests got turned off.
This probably needs a dedicated test, but I wanted to get this in as quickly as possible because we probably need to backport this to the beta.
added a commit
this pull request
Dec 20, 2016
Oh yes #37429 should have been prevented from landing in the first place due to it causing a regression to an existing test that this PR fixes. That test was erroneously not running and has since been fixed to run on all PRs.
In that sense I believe we've already got tests checked in for this.
I'm not sure what dense means but suspect it is bad; if you're referring to the description and the commit it's because I don't fully understand what's going on. @eddyb gets credit for this fix, and they tried to explain but not with much luck, I'm afraid.
I forget which test specifically checks this, but there are already tests examining closure-local variables.