/rust

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize static lifetime in statics #39265

Merged
merged 1 commit into from Feb 9, 2017

Conversation

Reviewers
No reviews
Assignees

@nrc nrc

Labels
None yet
Projects
None yet
Milestone
No milestone
7 participants
@est31 @nikomatsakis @bors @alexcrichton @steveklabnik @nrc @petrochenkov
@est31
Contributor

est31 commented Jan 23, 2017 •
edited

Stabilize the "static_in_const" feature. Blockers before this PR can be merged:

Closes #35897.

@rust-highfive rust-highfive assigned nrc Jan 23, 2017

@nikomatsakis

This comment has been minimized.

Sign in to view
Contributor

nikomatsakis commented Jan 24, 2017

@est31 nice
@bors

This comment has been minimized.

Sign in to view
Contributor

bors commented Jan 27, 2017

☔️ The latest upstream changes (presumably #39282) made this pull request unmergeable. Please resolve the merge conflicts.

@est31 est31 force-pushed the est31:master branch from 69139b6 to 459113b Jan 27, 2017

@est31

This comment has been minimized.

Sign in to view
Contributor

est31 commented Jan 27, 2017

Rebased.
@bors

This comment has been minimized.

Sign in to view
Contributor

bors commented Jan 28, 2017

☔️ The latest upstream changes (presumably #39305) made this pull request unmergeable. Please resolve the merge conflicts.

@est31 est31 force-pushed the est31:master branch 2 times, most recently from 8ac8f0d to 35191d0 Jan 28, 2017

@est31

This comment has been minimized.

Sign in to view
Contributor

est31 commented Jan 28, 2017 •
edited

Rebased on top of @eddyb 's PR. Its really great to see how the PR made this change much easier, so it must have been a good refactor!
@alexcrichton

This comment has been minimized.

Sign in to view
Member

alexcrichton commented Feb 4, 2017

ping @nrc, would be a neat feature for 1.17!
@est31

This comment has been minimized.

Sign in to view
Contributor

est31 commented Feb 5, 2017

@alexcrichton its currently blocked by #37928
@bors

This comment has been minimized.

Sign in to view
Contributor

bors commented Feb 5, 2017

☔️ The latest upstream changes (presumably #39563) made this pull request unmergeable. Please resolve the merge conflicts.

@est31 est31 force-pushed the est31:master branch from 35191d0 to 0361dcf Feb 5, 2017

@est31

This comment has been minimized.

Sign in to view
Contributor

est31 commented Feb 5, 2017

Now that beta branched, I would like to ask for beta backport nomination, so that already 1.16 would have it stabilized.

@alexcrichton alexcrichton added the beta-nominated label Feb 5, 2017

@steveklabnik

This comment has been minimized.

Sign in to view
Member

steveklabnik commented Feb 6, 2017

@nrc

This comment has been minimized.

Sign in to view
Member

nrc commented Feb 7, 2017

@bors: r+

I would also recommend against backporting - I don't think we should reduce stabilisation time in general.
@bors

This comment has been minimized.

Sign in to view
Contributor

bors commented Feb 7, 2017

📌 Commit 0361dcf has been approved by nrc
@bors

This comment has been minimized.

Sign in to view
Contributor

bors commented Feb 7, 2017

⌛️ Testing commit 0361dcf with merge 443866e...

bors added a commit that referenced this pull request Feb 7, 2017

@bors
Auto merge of #39265 - est31:master, r=nrc 
Stabilize static lifetime in statics

Stabilize the "static_in_const" feature. Blockers before this PR can be merged:

* [x] The [FCP with inclination to stabilize](#35897 (comment)) needs to be over. FCP lasts roughly three weeks, so will be over at Jan 25, aka this thursday.
* [ ] Documentation needs to be added (#37928)

Closes #35897.
Loading status checks…
443866e
@bors

This comment has been minimized.

Sign in to view
Contributor

bors commented Feb 7, 2017

💔 Test failed - status-travis

@est31 est31 force-pushed the est31:master branch from 942d101 to 1c8cb8a Feb 7, 2017

@alexcrichton

This comment has been minimized.

Sign in to view
Member

alexcrichton commented Feb 7, 2017

@bors: r=nrc
@bors

This comment has been minimized.

Sign in to view
Contributor

bors commented Feb 7, 2017

📌 Commit 1c8cb8a has been approved by nrc
@steveklabnik

This comment has been minimized.

Sign in to view
Member

steveklabnik commented Feb 7, 2017

#37928 is not yet closed, how is this being merged?
@alexcrichton

This comment has been minimized.

Sign in to view
Member

alexcrichton commented Feb 7, 2017

@bors: r-

@est31 est31 force-pushed the est31:master branch 2 times, most recently from 85accdc to f8b6108 Feb 8, 2017

@est31
Stabilize static in const 
Closes #35897.
Loading status checks…
f8b6108
@est31

This comment has been minimized.

Sign in to view
Contributor

est31 commented Feb 9, 2017

The documentation PR got merged, this is ready to be r+ed!
@petrochenkov

This comment has been minimized.

Sign in to view
Contributor

petrochenkov commented Feb 9, 2017

It took 2.5 months to document this (#37928 was open at Nov 22, 2016).
Fantastic.

@bors r+
@bors

This comment has been minimized.

Sign in to view
Contributor

bors commented Feb 9, 2017

📌 Commit f8b6108 has been approved by petrochenkov
@bors

This comment has been minimized.

Sign in to view
Contributor

bors commented Feb 9, 2017

⌛️ Testing commit f8b6108 with merge 1129ce5...

bors added a commit that referenced this pull request Feb 9, 2017

@bors
Auto merge of #39265 - est31:master, r=petrochenkov 
Stabilize static lifetime in statics

Stabilize the "static_in_const" feature. Blockers before this PR can be merged:

* [x] The [FCP with inclination to stabilize](#35897 (comment)) needs to be over. FCP lasts roughly three weeks, so will be over at Jan 25, aka this thursday.
* [x] Documentation needs to be added (#37928)

Closes #35897.
Loading status checks…
1129ce5
@bors

This comment has been minimized.

Sign in to view
Contributor

bors commented Feb 9, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: petrochenkov
Pushing 1129ce5 to master...

@bors bors merged commit f8b6108 into rust-lang:master Feb 9, 2017
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@eddyb eddyb referenced this pull request Feb 13, 2017

Closed

Tracking issue for lifetime elision for impl headers (feature impl_header_lifetime_elision) #15872

@alexcrichton alexcrichton referenced this pull request Feb 17, 2017

Closed

Tracking issue for static lifetime in statics (RFC #1623) #35897

@alexcrichton

This comment has been minimized.

Sign in to view
Member

alexcrichton commented Feb 21, 2017

Removing beta nomination as sentiment seems to be to not backport (also see #35897)

@alexcrichton alexcrichton removed the beta-nominated label Feb 21, 2017

@Object905 Object905 referenced this pull request Aug 1, 2017

Closed

Tracking issue for `associated_consts` feature #29646

4 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment