Rollup of 29 pull requests #40429
Closed
Rollup of 29 pull requests #40429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rendering of the end of the `Configure and Make` section.
Keeps MIR cleaner, `StorageLive(_: !)` makes no sense anyway.
gdb will now reliably detect the lanugage as rust even before any code is run.
I can't find anything that'd cause unexpected EOF in the source, so let's try taking a look at the error logs on failures.
This causes problems when first cloning and bootstrapping the repository unfortunately, so let's ensure that Cargo sticks around in its own workspace. Because Cargo is a submodule it's not available by default on the inital clone of the rust-lang/rust repository. Normally it's the responsibility of the rustbuild to take care of this, but unfortunately to build rustbuild itself we need to resolve the workspace conflicts. To deal with this we'll just have to ensure that all submodules are in their own workspace, which sort of makes sense anyway as updates to dependencies as bugfixes to Cargo should go to rust-lang/cargo instead of rust-lang/rust. In any case this commit removes Cargo from the global workspace which should resolve the issues that we've been seeing. To actually perform this the `cargo` submodule has been moved to the top directory to ensure it's outside the scope of `src/Cargo.toml` as a workspace.
When declaring nested unsafe blocks (`unsafe {unsafe {}}`) that trigger
the "unnecessary `unsafe` block" error, point out the enclosing `unsafe
block` or `unsafe fn` that makes it unnecessary.
Some annotations like the "test" annotations might be of interest for other projects, especially rls. Export all attributes in a new attributes item.
Remove the AST structure
In recent months there have been a few different people investigating how to make a plugin that registers a MIR-pass – one that isn’t intended to be eventually merged into rustc proper. The interface to register MIR passes was added primarily for miri (& later was found to make prototyping of rustc-proper MIR passes a tiny bit faster). Since miri does not use this interface anymore it seems like a good time to remove this "feature". For prototyping purposes a similar interface can be added by developers themselves in their custom rustc build.
added 13 commits
March 10, 2017 23:08
save-analysis: cope with lack of method data after a type error Fixes rust-lang#39957 r? @eddyb
Fix missing backtick typo Fixes rendering of the end of the `Configure and Make` section.
Do not bother creating StorageLive for TyNever Keeps MIR cleaner, `StorageLive(_: !)` makes no sense anyway. r? @eddyb
Fix UB in repr(packed) tests r? @arielb1 cc rust-lang#37609 and rust-lang#27060
Box docs: no allocation is done for ZSTs. Updated to add a small bit saying that ZSTs don't actually allocate on `Box::new`.
emit !align attributes on stores of operand pairs This avoids another case of missing-align UB. cc rust-lang#40373 r? @eddyb
…or, r=alexcrichton Distinguish the ways `CStr::from_bytes_with_nul` can fail
Implement placement-in protocol for `VecDeque` CC rust-lang#30172 r? @nagisa
Update gdbr tests gdb will now reliably detect the lanugage as rust even before any code is run.
fix rust-lang#40294 obligation cause.body_id is not always a NodeExpr Hello! This fixes rust-lang#40294 and moves tests related to rust-lang#38812 to a much more sensible directory. Thanks to @nikomatsakis and @eddyb
…r=alexcrichton OsString::shrink_to_fit. Considering how the other capacity-related methods are there, I found it odd that this one wasn't included. Will create a tracking issue once I get an OK on this.
… r=arielb1 rustc: Support auto-retry linking on a segfault This is a last-ditch attempt to help our pain with dealing with rust-lang#38878 on the bots. A new environment variable is added to the compiler, `RUSTC_RETRY_LINKER_ON_SEGFAULT`, which will instruct the compiler to automatically retry the final linker invocation if it looks like the linker segfaulted (up to 2 extra times). Unfortunately there have been no successful attempts to debug rust-lang#38878. The only information seems to be that the linker (e.g. `ld` on OSX) is segfaulting somewhere in some thread pool implementation. This appears to be spurious as failed PRs will later merge. The hope is that this helps the queue keep moving without clogging and delaying PRs due to rust-lang#38878.
Clarify docs in `VecDeque::resize`
|
Some changes occurred in HTML/CSS. |
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ p=10000 |
|
📌 Commit 2645637 has been approved by |
|
⌛ Testing commit 2645637 with merge 1a7726e... |
|
💔 Test failed - status-appveyor |
|
@bors: retry
|
|
⌛ Testing commit 2645637 with merge 93b05f3... |
|
💔 Test failed - status-appveyor |
|
|
Closing in favor of #40432 which I believe has a fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proc_macro#40199, Restore creating the channel-rust-$channel-date.txt files #40225, Remove ability for plugins to register a MIR pass #40239, Fix emscripten test detection #40259, Clean up rustdoc css #40278, Fix incorrect span label formatting #40287, Don't put Cargo into the rustc workspace #40297, Expect macro defs in save-analysis and add expn info to spans for att… #40311, Allow lints to check Bodys directly #40315, Disallow subtyping between T and U in T: Unsize<U>. #40319, travis: Attempt to debug sccache failures #40324, Update syntax forpub(restricted)#40340, save-analysis: cope with lack of method data after a type error #40344, Fix missing backtick typo #40345, Do not bother creating StorageLive for TyNever #40372, Fix UB in repr(packed) tests #40373, Box docs: no allocation is done for ZSTs. #40379, emit !align attributes on stores of operand pairs #40385, Distinguish the waysCStr::from_bytes_with_nulcan fail #40386, Implement placement-in protocol forVecDeque#40389, Update gdbr tests #40400, fix #40294 obligation cause.body_id is not always a NodeExpr #40404, OsString::shrink_to_fit. #40410, rustc: Support auto-retry linking on a segfault #40422, Clarify docs inVecDeque::resize#40423