Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release notes for 1.19.0 #43368

Merged
merged 1 commit into from Jul 21, 2017
Merged

Update release notes for 1.19.0 #43368

merged 1 commit into from Jul 21, 2017

Conversation

XAMPPRocky
Copy link
Member

This is just #42503 there is some problems with submodules I can't seem to fix so I just created a new PR.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jul 20, 2017

📌 Commit 077dead has been approved by alexcrichton

@kennytm
Copy link
Member

kennytm commented Jul 20, 2017

This one needs a p=1 or something. It is currently at the last place of the queue.

@Mark-Simulacrum
Copy link
Member

It's just going into master though? Presumably not all that important, but seeing as the other PR was p=100...

@bors p=100

@XAMPPRocky
Copy link
Member Author

@Mark-Simulacrum Does it not need to go on origin/beta?

@Mark-Simulacrum
Copy link
Member

Not sure. @alexcrichton or @brson should know.

@bors
Copy link
Contributor

bors commented Jul 20, 2017

⌛ Testing commit 077dead with merge cc80053...

bors added a commit that referenced this pull request Jul 20, 2017
Update release notes for 1.19.0

This is just #42503 there is some problems with submodules I can't seem to fix so I just created a new PR.
@bors
Copy link
Contributor

bors commented Jul 21, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing cc80053 to master...

@bors bors merged commit 077dead into rust-lang:master Jul 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants