Skip to content

Conversation

jdm
Copy link
Contributor

@jdm jdm commented Jan 20, 2013

Similarly, building non-rustc with -g should also not ICE now. The output is also kind of useful in gdb if you're careful and don't use any macros/syntax extensions in your code.

r? @TJC

@catamorphism
Copy link
Contributor

Destructors implicitly return ty_nil -- can you just make that the result type for dtors and avoid the need to turn the return type into an option in the debuginfo code?

@catamorphism
Copy link
Contributor

r+ if you change that -- unless there's a reason to do it this way!

@jdm
Copy link
Contributor Author

jdm commented Jan 20, 2013

The problem is that the return type data also contains stuff like spans which I would have to synthesize somehow.

@catamorphism
Copy link
Contributor

Ah, usually the solution to the span issue is to use ast_util::dummy_spanned. Is there other info you don't know how to synthesize?

@TJC
Copy link

TJC commented Jan 20, 2013

Hi, I get emailed about this issue all the time, because someone mentioned me (@TJC) at some point, by mistake.
Is there any way to get me off the notification list for this issue?
Thanks.

@jdm
Copy link
Contributor Author

jdm commented Jan 20, 2013

Whoops. Try changing the "Watching thread" pulldown under the comment box?

@TJC
Copy link

TJC commented Jan 21, 2013

Thanks, I must have missed that when I looked the last few times >.<
ta

@catamorphism
Copy link
Contributor

I noticed there's a function in ast_util that does exactly what's needed here for the dtor help. I'm going to go ahead and make the change in my tree and merge it. Thanks @jdm !

@catamorphism
Copy link
Contributor

Merged in 17ea548 - thanks!

RalfJung added a commit to RalfJung/rust that referenced this pull request Sep 3, 2025
native-lib mode: avoid unsoundness due to mrpotect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants