New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regenerate libcore/char_private.rs #45571

Merged
merged 1 commit into from Nov 7, 2017

Conversation

Projects
None yet
8 participants
@zackmdavis
Member

zackmdavis commented Oct 27, 2017

(filed separately from the work in #45569, because of this matter of the updated Unicode data; see also #45567)

char_private.rs is generated programmatically by char_private.py, using data retrieved from the Unicode Consortium's website.

The motivation here was to make is_printable crate-visible (with pub(crate)), but it would seem that the Unicode data has changed slightly since char_private.rs was last generated.

regenerate libcore/char_private.rs
char_private.rs is generated programmatically by char_private.py, using data
retrieved from the Unicode Consortium's website.

The motivation here was to make `is_printable` crate-visible (with
`pub(crate)`), but it would seem that the Unicode data has changed slightly
since char_private.rs was last generated.
@rust-highfive

This comment has been minimized.

Show comment
Hide comment
@rust-highfive

rust-highfive Oct 27, 2017

Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

Collaborator

rust-highfive commented Oct 27, 2017

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@estebank

This comment has been minimized.

Show comment
Hide comment
@estebank

estebank Oct 31, 2017

Contributor

Sorry for the wide spam, @rust-lang/core, @rust-lang/libs, @rust-lang/docs not sure who to ask this.

This change will update Rust's unicode support from 9 to 10, IIUC. Is this something that can be updated matter of fact without an RFC? I'm inclined to r+ it, maybe changing the PR's name beforehand to make sure it's not lost in the shuffle in the corresponding release's notes.

Contributor

estebank commented Oct 31, 2017

Sorry for the wide spam, @rust-lang/core, @rust-lang/libs, @rust-lang/docs not sure who to ask this.

This change will update Rust's unicode support from 9 to 10, IIUC. Is this something that can be updated matter of fact without an RFC? I'm inclined to r+ it, maybe changing the PR's name beforehand to make sure it's not lost in the shuffle in the corresponding release's notes.

@kennytm kennytm added the relnotes label Nov 1, 2017

@kennytm

This comment has been minimized.

Show comment
Hide comment
@kennytm

kennytm Nov 1, 2017

Member

@estebank We should be already using Unicode 10 (#42999)...

Similar previous PRs (e.g. upgrade entirely to Unicode 9 #34599) don't have RFCs, but they don't pass as a single-handed r+ either.

However, the char_private module only defines the is_printable function, which in turn is only used in char::escape_debug that has no stability guarantee on the Unicode version. So I guess it is fine to merge without deep inspection.

Member

kennytm commented Nov 1, 2017

@estebank We should be already using Unicode 10 (#42999)...

Similar previous PRs (e.g. upgrade entirely to Unicode 9 #34599) don't have RFCs, but they don't pass as a single-handed r+ either.

However, the char_private module only defines the is_printable function, which in turn is only used in char::escape_debug that has no stability guarantee on the Unicode version. So I guess it is fine to merge without deep inspection.

@alexcrichton

This comment has been minimized.

Show comment
Hide comment
@alexcrichton

alexcrichton Nov 6, 2017

Member

@bors: r+

Thanks for the extra info @kennytm!

Member

alexcrichton commented Nov 6, 2017

@bors: r+

Thanks for the extra info @kennytm!

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Nov 6, 2017

Contributor

📌 Commit 3c81d3d has been approved by alexcrichton

Contributor

bors commented Nov 6, 2017

📌 Commit 3c81d3d has been approved by alexcrichton

@kennytm

This comment has been minimized.

Show comment
Hide comment
@kennytm

kennytm Nov 7, 2017

Member

(I've removed the relnotes tag since it only affects escape_debug which doesn't seem to be a big point to mention.)

Member

kennytm commented Nov 7, 2017

(I've removed the relnotes tag since it only affects escape_debug which doesn't seem to be a big point to mention.)

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Nov 7, 2017

Contributor

⌛️ Testing commit 3c81d3d with merge a17e724...

Contributor

bors commented Nov 7, 2017

⌛️ Testing commit 3c81d3d with merge a17e724...

bors added a commit that referenced this pull request Nov 7, 2017

Auto merge of #45571 - zackmdavis:regenerate_char_private, r=alexcric…
…hton

regenerate libcore/char_private.rs

(filed separately from the work in #45569, because of this matter of the updated Unicode data; see also #45567)

char_private.rs is generated programmatically by char_private.py, using data retrieved from the Unicode Consortium's website.

The motivation here was to make `is_printable` crate-visible (with `pub(crate)`), but it would seem that the Unicode data has changed slightly since char_private.rs was last generated.
@Mark-Simulacrum

This comment has been minimized.

Show comment
Hide comment
@Mark-Simulacrum

Mark-Simulacrum Nov 7, 2017

Member

I disagree - I think this change is worth mentioning in the compatibility section of the relnotes.

Member

Mark-Simulacrum commented Nov 7, 2017

I disagree - I think this change is worth mentioning in the compatibility section of the relnotes.

@bors

This comment has been minimized.

Show comment
Hide comment
@bors

bors Nov 7, 2017

Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing a17e724 to master...

Contributor

bors commented Nov 7, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing a17e724 to master...

@bors bors merged commit 3c81d3d into rust-lang:master Nov 7, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@zackmdavis zackmdavis deleted the zackmdavis:regenerate_char_private branch Jan 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment