New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: Don't modify library path for doctests #56514

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
6 participants
@ollie27
Contributor

ollie27 commented Dec 4, 2018

It shouldn't be needed anymore because doctests are no longer compiled with prefer-dynamic (since #54939).

r? @QuietMisdreavus

rustdoc: Don't modify library path for doctests
It shouldn't be needed anymore because doctests are no longer compiled with `prefer-dynamic`.
@QuietMisdreavus

This comment has been minimized.

Member

QuietMisdreavus commented Dec 4, 2018

This feels like something that could use a crater run...

@QuietMisdreavus

This comment has been minimized.

Member

QuietMisdreavus commented Dec 4, 2018

Just to sate my paranoia, i'm going to try to run this through crater. First step...

@bors try

@bors

This comment has been minimized.

Contributor

bors commented Dec 4, 2018

⌛️ Trying commit 7dd34d5 with merge 6eb0fd3...

bors added a commit that referenced this pull request Dec 4, 2018

Auto merge of #56514 - ollie27:rustdoc_test_libdir, r=<try>
rustdoc: Don't modify library path for doctests

It shouldn't be needed anymore because doctests are no longer compiled with `prefer-dynamic` (since #54939).

r? @QuietMisdreavus
@bors

This comment has been minimized.

Contributor

bors commented Dec 4, 2018

☀️ Test successful - status-travis
State: approved= try=True

@QuietMisdreavus

This comment has been minimized.

Member

QuietMisdreavus commented Dec 4, 2018

@craterbot run start=master#906deae0790bd18681b937fe9a141a3c26cf1855 end=try#6eb0fd3ac58f9b16bddb9924a17c3b6c156aa468 mode=build-and-test

@craterbot

This comment has been minimized.

Collaborator

craterbot commented Dec 4, 2018

👌 Experiment pr-56514 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot

This comment has been minimized.

Collaborator

craterbot commented Dec 4, 2018

🚧 Experiment pr-56514 is now running on agent aws-1.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot

This comment has been minimized.

Collaborator

craterbot commented Dec 8, 2018

🎉 Experiment pr-56514 is completed!
📊 17 regressed and 15 fixed (50140 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@QuietMisdreavus

This comment has been minimized.

Member

QuietMisdreavus commented Dec 8, 2018

All of the legit failures look like docmatic-style tests where people run doctests from their README by calling rustdoc directly. I guess the directory they pass to rustdoc (-L target/debug/deps in most examples) has both the cfg(test) and cfg(not(test)) versions of the rlib in it, which confuses the crate loader.

However, the more i look at docmatic and skeptic reverse-deps, the more i see them everywhere on the report. I wonder if there's something else that's causing the failures, and this specific change isn't actually what's at fault.

Regardless, GitHub is now reporting a merge conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment