Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Unconditionally emit the target-cpu LLVM attribute. #56609
This PR makes
added a commit
this pull request
Dec 7, 2018
That does not appear to be true at all? That is, I don’t recall seeing this attribute in code generated by rustc, ever.
There is one use case of mine that is semi-broken by unconditionally emitting target-cpu attribute. When investigating codegen bugs for trivial code, I like emiting LLVM-IR and running it through
a dozen times for each function, making it necessary to remove those attributes somehow to make it workable. Not that I’m gonna block this PR on it, it is just something I felt was not taken into account of being possible :)
What I meant was: When compiling all of your code with xLTO then only the libstd LLVM IR pulled in from crate metadata would not have the attribute.
I'm sorry about the regression you mention