Rollup of 13 pull requests #56728

pietroalbini · 2018-12-11T20:40:05Z

Successful merges:

Add lint for items deprecated in future #56203 (Add lint for items deprecated in future)
Remove not used mod #56343 (Remove not used mod)
Clearer error message for dead assign #56439 (Clearer error message for dead assign)
polonius tweaks #56507 (polonius tweaks)
Contexually dependent error message for E0424 when value is assigned to "self" #56572 (Contexually dependent error message for E0424 when value is assigned to "self")
Unconditionally emit the target-cpu LLVM attribute. #56609 (Unconditionally emit the target-cpu LLVM attribute.)
rustdoc: Fix local reexports of proc macros #56637 (rustdoc: Fix local reexports of proc macros)
overhaul external doc attribute diagnostics #56679 (overhaul external doc attribute diagnostics)
Update the stdsimd submodule #56682 (Update the stdsimd submodule)
fix install broken link #56691 (fix install broken link)
[self-profiler] Add column for percent of total time #56702 ([self-profiler] Add column for percent of total time)
Remove some unnecessary feature gates #56708 (Remove some unnecessary feature gates)
Always set the RDRAND and RDSEED features on SGX #56710 (Always set the RDRAND and RDSEED features on SGX)

Failed merges:

`mir_stats` mod has not been used since c1ff104.

Filter out `ProcMacroStub`s to avoid an ICE during cleaning. Also add proc macros to `cache().paths` so it can generate links.

Also, provide a suggestion for the correct syntax.

Includes some new stabilized intrinsics for the wasm32 target! Closes rust-lang#56292

Add lint for items deprecated in future Resolves rust-lang#55892

…omatsakis Remove not used mod `mir_stats` mod has not been used since c1ff104.

Clearer error message for dead assign I'm not that this is the right place for this (if it needs an RFC or not). I had the problem where I misunderstood the compiler lint message rust-lang#56436 and other people seem to have had the same problem https://www.reddit.com/r/rust/comments/8cy9p4/value_assigned_to_is_never_read/. I think this new wording might be slightly clearer (and help out beginners like me). I'm very new though, so there might be some nuance I'm missing that would make this more confusing or a bad idea for other reasons. I thought I would create a PR to make it easy to change the code if the consensus was that it would make sense to make a change. If this is the wrong place for this sort of thing I'll happily delete/move it.

@matthewjasper

…MatthewJasper polonius tweaks - bump polonius to 0.6.0 - fix 2-phase-borrow activations r? @matthewjasper

Contexually dependent error message for E0424 when value is assigned to "self" This is an improvement for pull request rust-lang#54495 referencing issue rust-lang#54369. If the "self" keyword is assigned a value as though it were a valid identifier, it will now report: ``` let self = "self"; ^^^^ `self` value is a keyword and may not be bound to variables or shadowed ``` instead of ``` let self = "self"; ^^^^ `self` value is a keyword only available in methods with `self` parameter ``` If anyone has a better idea for what the error should be I'd be happy to modify it appropriately.

@alexcrichton

…et-cpu-attr, r=alexcrichton Unconditionally emit the target-cpu LLVM attribute. This PR makes `rustc` always emit the `target-cpu` LLVM attribute for functions. The goal is to allow for cross-language inlining of functions defined in `libstd`. So far `libstd` functions were the only function without a `target-cpu` attribute, so in whole-crate-graph cross-lang LTO scenarios they were not eligible for inlining into foreign code. r? @alexcrichton

@QuietMisdreavus

…export, r=QuietMisdreavus rustdoc: Fix local reexports of proc macros Filter out `ProcMacroStub`s to avoid an ICE during cleaning. Also add proc macros to `cache().paths` so it can generate links. r? @QuietMisdreavus

@QuietMisdreavus

overhaul external doc attribute diagnostics This PR improves the error handling and spans for the external doc attribute. Many cases that silently failed before now emit errors, spans are tightened, and the errors have help and suggestions. I tried to address all the cases that users ran into in the tracking issue. cc rust-lang#44732 r? @QuietMisdreavus

pietroalbini · 2018-12-11T20:54:42Z

@bors r+ p=13

bors · 2018-12-11T20:54:44Z

📌 Commit cd4e775 has been approved by pietroalbini

bors · 2018-12-11T23:26:32Z

⌛ Testing commit cd4e775 with merge 26126234d942576a36195cf33bb1433ea15b8184...

bors · 2018-12-11T23:28:05Z

💔 Test failed - status-appveyor

rust-highfive · 2018-12-11T23:30:09Z

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

Checking out files: 100% (17619/17619), done.
travis_time:end:145aa7e0:start=1544570918231763000,finish=1544570928881442000,duration=10649679000
$ cd rust-lang/rust
$ git checkout -qf 26126234d942576a36195cf33bb1433ea15b8184
fatal: reference is not a tree: 26126234d942576a36195cf33bb1433ea15b8184
The command "git checkout -qf 26126234d942576a36195cf33bb1433ea15b8184" failed and exited with 128 during .
Your build has been stopped.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

alexcrichton · 2018-12-11T23:47:23Z

@bors: retry

CI automation hiccup

bors · 2018-12-11T23:54:39Z

⌛ Testing commit cd4e775 with merge 68fcfc31b96253e0ffb215d96324d44e9da8e370...

bors · 2018-12-12T00:01:30Z

💔 Test failed - status-appveyor

alexcrichton · 2018-12-12T01:13:58Z

@bors: p=9

(moving below the treeclosed threshold

alexcrichton · 2018-12-12T01:14:03Z

@bors: retry

bors · 2018-12-12T04:14:41Z

⌛ Testing commit cd4e775 with merge 5c64d0b8caa50320e6ba07e5f112cb02e53046dc...

bors · 2018-12-12T05:30:13Z

💔 Test failed - status-travis

rust-highfive · 2018-12-12T05:30:14Z

The job x86_64-gnu-tools of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[01:12:16] Verifying status of rustfmt...
[01:12:16] Verifying status of clippy-driver...
[01:12:16] This PR updated 'src/tools/clippy', verifying if status is 'test-pass'...
[01:12:16] 
[01:12:16] ⚠️ We detected that this PR updated 'clippy-driver', but its tests failed.
[01:12:16] 
[01:12:16] If you do intend to update 'clippy-driver', please check the error messages above and
[01:12:16] commit another update.
[01:12:16] 
[01:12:16] If you do NOT intend to update 'clippy-driver', please ensure you did not accidentally
[01:12:16] change the submodule at 'src/tools/clippy'. You may ask your reviewer for the
[01:12:16] proper steps.
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 3.
travis_time:start:1cfd49af
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Wed Dec 12 05:29:13 UTC 2018
---
travis_time:end:24a2d6ba:start=1544592553944423103,finish=1544592553952782775,duration=8359672
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0ecac01b
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:24a91520
travis_time:start:24a91520
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:016eef76
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

yui-knk and others added 30 commits November 29, 2018 08:54

Remove not used mod

934e4d3

`mir_stats` mod has not been used since c1ff104.

Clearer error message for dead assign

eaeebb5

Fix line length

54026c1

Fix stderr files

4cf5702

Fix stderr file (unused variable)

70536d4

Change to give a help message

c0e3f4b

Unconditionally emit the target-cpu LLVM attribute.

86822eb

rustdoc: Fix local reexports of proc macros

0bb075f

Filter out `ProcMacroStub`s to avoid an ICE during cleaning. Also add proc macros to `cache().paths` so it can generate links.

Add lint for items deprecated in future

aa04285

reject invalid external doc attributes

c3c2de9

Also, provide a suggestion for the correct syntax.

improve diagnostics for invalid external docs

7f7045f

debug logging, added conditional error message, tests updated

5586c04

Update the stdsimd submodule

07a3d69

Includes some new stabilized intrinsics for the wasm32 target! Closes rust-lang#56292

fix install broken link

3d23e55

Add lint for stlib

f8c03b6

[self-profiler] Add column for percent of total time

771e8b8

Remove unnecessary feature gates from const fns

799cadb

Remove some dead code from sgx

1346619

Properly stage new feature gates

5457b19

generate invalidations from 2-phase-borrow activations

30f531b

adopt polonius-engine 0.6.1

8ee2c06

Always set the RDRAND and RDSEED features on SGX

5acab2d

Rollup merge of rust-lang#56203 - aheart:master, r=varkor

86b786b

Add lint for items deprecated in future Resolves rust-lang#55892

Rollup merge of rust-lang#56343 - yui-knk:remove_mir_stats_mod, r=nik…

a7e1d77

…omatsakis Remove not used mod `mir_stats` mod has not been used since c1ff104.

Rollup merge of rust-lang#56507 - nikomatsakis:polonius-integrate, r=…

a6e98b3

…MatthewJasper polonius tweaks - bump polonius to 0.6.0 - fix 2-phase-borrow activations r? @matthewjasper

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 11, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 11, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 11, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 12, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 12, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 12, 2018

kennytm closed this Dec 12, 2018

pietroalbini deleted the rollup branch December 12, 2018 16:31

Centril added the rollup A PR which is a rollup label Oct 24, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 13 pull requests #56728

Rollup of 13 pull requests #56728

pietroalbini commented Dec 11, 2018

pietroalbini commented Dec 11, 2018

bors commented Dec 11, 2018

bors commented Dec 11, 2018

bors commented Dec 11, 2018

rust-highfive commented Dec 11, 2018

alexcrichton commented Dec 11, 2018

bors commented Dec 11, 2018

bors commented Dec 12, 2018

alexcrichton commented Dec 12, 2018

alexcrichton commented Dec 12, 2018

bors commented Dec 12, 2018

bors commented Dec 12, 2018

rust-highfive commented Dec 12, 2018

Rollup of 13 pull requests #56728

Rollup of 13 pull requests #56728

Conversation

pietroalbini commented Dec 11, 2018

pietroalbini commented Dec 11, 2018

bors commented Dec 11, 2018

bors commented Dec 11, 2018

bors commented Dec 11, 2018

rust-highfive commented Dec 11, 2018

alexcrichton commented Dec 11, 2018

bors commented Dec 11, 2018

bors commented Dec 12, 2018

alexcrichton commented Dec 12, 2018

alexcrichton commented Dec 12, 2018

bors commented Dec 12, 2018

bors commented Dec 12, 2018

rust-highfive commented Dec 12, 2018