Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use SOURCE_DATE_EPOCH for man page time if set #57920

Merged
merged 1 commit into from
Jan 31, 2019

Conversation

euclio
Copy link
Contributor

@euclio euclio commented Jan 26, 2019

Fixes #57776.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 26, 2019
@nikomatsakis
Copy link
Contributor

r? @Mark-Simulacrum

@Mark-Simulacrum
Copy link
Member

Seems good. We might want to consider falling back to current time if the environment variable failed to parse, but at least for now this seems like strictly better behavior.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 28, 2019

📌 Commit 8db66ca has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 28, 2019
Centril added a commit to Centril/rust that referenced this pull request Jan 30, 2019
…mulacrum

use `SOURCE_DATE_EPOCH` for man page time if set

Fixes rust-lang#57776.
Centril added a commit to Centril/rust that referenced this pull request Jan 30, 2019
…mulacrum

use `SOURCE_DATE_EPOCH` for man page time if set

Fixes rust-lang#57776.
Centril added a commit to Centril/rust that referenced this pull request Jan 30, 2019
…mulacrum

use `SOURCE_DATE_EPOCH` for man page time if set

Fixes rust-lang#57776.
Centril added a commit to Centril/rust that referenced this pull request Jan 30, 2019
…mulacrum

use `SOURCE_DATE_EPOCH` for man page time if set

Fixes rust-lang#57776.
Centril added a commit to Centril/rust that referenced this pull request Jan 31, 2019
…mulacrum

use `SOURCE_DATE_EPOCH` for man page time if set

Fixes rust-lang#57776.
bors added a commit that referenced this pull request Jan 31, 2019
Rollup of 12 pull requests

Successful merges:

 - #57008 (suggest `|` when `,` founds in invalid match value)
 - #57106 (Mark str::trim.* functions as #[must_use].)
 - #57920 (use `SOURCE_DATE_EPOCH` for man page time if set)
 - #57934 (Introduce into_raw_non_null on Rc and Arc)
 - #57971 (SGX target: improve panic & exit handling)
 - #57980 (Add the edition guide to the bookshelf)
 - #57984 (Improve bug message in check_ty)
 - #57999 (Add MOVBE x86 CPU feature)
 - #58000 (Fixes and cleanups)
 - #58005 (update docs for fix_start/end_matches)
 - #58007 (Don't panic when accessing enum variant ctor using `Self` in match)
 - #58008 (Pass correct arguments to places_conflict)

Failed merges:

r? @ghost
@bors bors merged commit 8db66ca into rust-lang:master Jan 31, 2019
@euclio euclio deleted the source-date-epoch branch January 31, 2019 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants