libsyntax => 2018 #58125

taiki-e · 2019-02-03T19:42:13Z

Transitions libsyntax to Rust 2018; cc #58099

rust-highfive · 2019-02-03T20:20:45Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:002e5966:start=1549223007963931417,finish=1549223137675528268,duration=129711596851
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---

[00:03:59] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:03:59] tidy error: /checkout/src/libsyntax/parse/lexer/comments.rs:148: line longer than 100 chars
[00:04:01] some tidy checks failed
[00:04:01] 
[00:04:01] 
[00:04:01] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:01] 
[00:04:01] 
[00:04:01] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:01] Build completed unsuccessfully in 0:00:47
[00:04:01] Build completed unsuccessfully in 0:00:47
[00:04:01] make: *** [tidy] Error 1
[00:04:01] Makefile:68: recipe for target 'tidy' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:24583f10
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Sun Feb  3 19:49:48 UTC 2019
---
travis_time:end:160a6151:start=1549223389159338409,finish=1549223389164511760,duration=5173351
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:04946557
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:07f83510
travis_time:start:07f83510
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0565f040
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Centril · 2019-02-05T12:00:24Z

@bors r+

bors · 2019-02-05T12:00:25Z

📌 Commit 072fa58ef2c1688a57af7b4e5c3ba0e2e3c66b54 has been approved by Centril

bors · 2019-02-06T08:55:16Z

☔ The latest upstream changes (presumably #58061) made this pull request unmergeable. Please resolve the merge conflicts.

rust-highfive · 2019-02-06T14:52:53Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:05153590:start=1549459209293998767,finish=1549459212440707061,duration=3146708294
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:08:55] 
[01:08:55] running 119 tests
[01:09:19] .iiiii...i.....i..i...i..i.i..i.ii...i.....i..i....i..........iiii..........i...ii...i.......ii.i.i. 100/119
[01:09:23] i......iii.i.....ii
[01:09:23] 
[01:09:23]  finished in 28.611
[01:09:23] travis_fold:end:test_debuginfo

---
[01:32:13]    Compiling syntax v0.0.0 (/checkout/src/libsyntax)
[01:32:15] error[E0433]: failed to resolve: use of undeclared type or module `util`
[01:32:15]     --> src/libsyntax/mut_visit.rs:1261:9
[01:32:15]      |
[01:32:15] 1261 |     use util::parser_testing::{string_to_crate, matches_codepattern};
[01:32:15] 
[01:32:15] error[E0432]: unresolved import `ast`
[01:32:15]     --> src/libsyntax/mut_visit.rs:1260:15
[01:32:15]      |
[01:32:15]      |
[01:32:15] 1260 |     use ast::{self, Ident};
[01:32:15]      |               ^^^^ no `ast` external crate
[01:32:15] error[E0432]: unresolved import `print`
[01:32:15]     --> src/libsyntax/mut_visit.rs:1262:9
[01:32:15]      |
[01:32:15] 1262 |     use print::pprust;
[01:32:15] 1262 |     use print::pprust;
[01:32:15]      |         ^^^^^ did you mean `crate::print`?
[01:32:15]      |
[01:32:15]      = note: `use` statements changed in Rust 2018; read more at <https://doc.rust-lang.org/edition-guide/rust-2018/module-system/path-clarity.html>
[01:32:15] error[E0432]: unresolved import `mut_visit`
[01:32:15]     --> src/libsyntax/mut_visit.rs:1263:9
[01:32:15]      |
[01:32:15] 1263 |     use mut_visit;
[01:32:15] 1263 |     use mut_visit;
[01:32:15]      |         ^^^^^^^^^ no `mut_visit` external crate
[01:32:15] 
[01:32:15] error[E0432]: unresolved import `with_globals`
[01:32:15]     --> src/libsyntax/mut_visit.rs:1264:9
[01:32:15] 1264 |     use with_globals;
[01:32:15] 1264 |     use with_globals;
[01:32:15]      |         ^^^^^^^^^^^^ no `with_globals` external crate
[01:32:17] error[E0425]: cannot find function `string_to_crate` in this scope
[01:32:17]     --> src/libsyntax/mut_visit.rs:1304:29
[01:32:17]      |
[01:32:17] 1304 |             let mut krate = string_to_crate(
---
[01:32:17] 1308 |                 matches_codepattern,
[01:32:17]      |                 ^^^^^^^^^^^^^^^^^^^ not found in this scope
[01:32:17] help: possible candidate is found in another module, you can import it into scope
[01:32:17]      |
[01:32:17] 1259 |     use crate::util::parser_testing::matches_codepattern;
[01:32:17] 
[01:32:17] error[E0425]: cannot find function `string_to_crate` in this scope
[01:32:17]     --> src/libsyntax/mut_visit.rs:1319:29
[01:32:17]      |
---
[01:32:17] 1324 |                 matches_codepattern,
[01:32:17]      |                 ^^^^^^^^^^^^^^^^^^^ not found in this scope
[01:32:17] help: possible candidate is found in another module, you can import it into scope
[01:32:17]      |
[01:32:17] 1259 |     use crate::util::parser_testing::matches_codepattern;
[01:32:17] 
[01:32:17] error: unused import: `Ident`
[01:32:17]     --> src/libsyntax/mut_visit.rs:1260:21
[01:32:17]      |
[01:32:17]      |
[01:32:17] 1260 |     use ast::{self, Ident};
[01:32:17]      |
[01:32:17]      = note: `-D unused-imports` implied by `-D warnings`
[01:32:17] 
[01:32:17] 
[01:32:17] error: unused imports: `matches_codepattern`, `string_to_crate`
[01:32:17]     --> src/libsyntax/mut_visit.rs:1261:32
[01:32:17]      |
[01:32:17] 1261 |     use util::parser_testing::{string_to_crate, matches_codepattern};
[01:32:17] 
[01:32:24] error: aborting due to 11 previous errors
[01:32:24] 
[01:32:24] Some errors occurred: E0425, E0432, E0433.
[01:32:24] Some errors occurred: E0425, E0432, E0433.
[01:32:24] For more information about an error, try `rustc --explain E0425`.
[01:32:24] error: Could not compile `syntax`.
[01:32:24] 
[01:32:24] To learn more, run the command again with --verbose.
[01:32:24] 
[01:32:24] 
[01:32:24] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "-p" "syntax" "--" "--quiet"
[01:32:24] 
[01:32:24] 
[01:32:24] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:32:24] Build completed unsuccessfully in 0:34:56
[01:32:24] Build completed unsuccessfully in 0:34:56
[01:32:24] Makefile:48: recipe for target 'check' failed
[01:32:24] make: *** [check] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0307bb75
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Wed Feb  6 14:52:46 UTC 2019

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2019-02-06T16:39:45Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:20db9100:start=1549465571116619232,finish=1549465573851959489,duration=2735340257
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:09:01] 
[01:09:01] running 119 tests
[01:09:29] .iiiii...i.....i..i...i..i.i..i.ii...i.....i..i....i..........iiii..........i...ii...i.......ii.i.i. 100/119
[01:09:34] i......iii.i.....ii
[01:09:34] 
[01:09:34]  finished in 33.026
[01:09:34] travis_fold:end:test_debuginfo

---
[01:33:02]    Compiling syntax v0.0.0 (/checkout/src/libsyntax)
[01:33:05] error: hidden lifetime parameters in types are deprecated
[01:33:05]     --> src/libsyntax/mut_visit.rs:1268:33
[01:33:05]      |
[01:33:05] 1268 |     fn fake_print_crate(s: &mut pprust::State,
[01:33:05] 
[01:33:12] error: aborting due to previous error
[01:33:12] 
[01:33:12] error: Could not compile `syntax`.
[01:33:12] error: Could not compile `syntax`.
[01:33:12] 
[01:33:12] To learn more, run the command again with --verbose.
[01:33:12] 
[01:33:12] 
[01:33:12] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "-p" "syntax" "--" "--quiet"
[01:33:12] 
[01:33:12] 
[01:33:12] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:33:12] Build completed unsuccessfully in 0:36:20
[01:33:12] Build completed unsuccessfully in 0:36:20
[01:33:12] make: *** [check] Error 1
[01:33:12] Makefile:48: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0629b592
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Wed Feb  6 16:39:37 UTC 2019

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Centril · 2019-02-06T17:56:20Z

@bors r+ p=1

bors · 2019-02-06T17:56:25Z

📌 Commit 7bb082d has been approved by Centril

bors · 2019-02-07T01:41:21Z

⌛ Testing commit 7bb082d with merge 1efdda1...

@Centril

libsyntax => 2018 Transitions `libsyntax` to Rust 2018; cc #58099 r? @Centril

bors · 2019-02-07T04:26:04Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: Centril
Pushing 1efdda1 to master...

rust-highfive assigned Centril Feb 3, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 3, 2019

taiki-e force-pushed the libsyntax-2018 branch 2 times, most recently from 79ea074 to 072fa58 Compare February 4, 2019 13:26

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 5, 2019

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 6, 2019

taiki-e force-pushed the libsyntax-2018 branch from 072fa58 to ea7e2eb Compare February 6, 2019 13:18

taiki-e force-pushed the libsyntax-2018 branch from ea7e2eb to ffa026b Compare February 6, 2019 15:04

libsyntax => 2018

7bb082d

taiki-e force-pushed the libsyntax-2018 branch from ffa026b to 7bb082d Compare February 6, 2019 17:33

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 6, 2019

bors added a commit that referenced this pull request Feb 7, 2019

Auto merge of #58125 - taiki-e:libsyntax-2018, r=Centril

1efdda1

libsyntax => 2018 Transitions `libsyntax` to Rust 2018; cc #58099 r? @Centril

bors merged commit 7bb082d into rust-lang:master Feb 7, 2019

This was referenced Feb 7, 2019

Error on duplicate matcher bindings #57617

Merged

Deduplicate mismatched delimiter errors #57944

Merged

[WIP] Massive cosmetic PR, take 2 #58036

Closed

Add const generics to the AST #58191

Merged

bors mentioned this pull request Feb 7, 2019

multiple substitutions become multiple children in JSON output #58221

Closed

6 tasks

taiki-e deleted the libsyntax-2018 branch February 7, 2019 04:48

pietroalbini added the merged-by-bors This PR was explicitly merged by bors. label Feb 7, 2019

Centril mentioned this pull request Feb 11, 2019

Tracking issue for Transitioning crates to Rust 2018 #58099

Closed

78 tasks

Manishearth mentioned this pull request Mar 9, 2019

Huge performance regression in rustdoc between 1/28 and 2/25 nightlies #58849

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

libsyntax => 2018 #58125

libsyntax => 2018 #58125

taiki-e commented Feb 3, 2019

rust-highfive commented Feb 3, 2019

Centril commented Feb 5, 2019

bors commented Feb 5, 2019

bors commented Feb 6, 2019

rust-highfive commented Feb 6, 2019

rust-highfive commented Feb 6, 2019

Centril commented Feb 6, 2019

bors commented Feb 6, 2019

bors commented Feb 7, 2019

bors commented Feb 7, 2019

libsyntax => 2018 #58125

libsyntax => 2018 #58125

Conversation

taiki-e commented Feb 3, 2019

rust-highfive commented Feb 3, 2019

Centril commented Feb 5, 2019

bors commented Feb 5, 2019

bors commented Feb 6, 2019

rust-highfive commented Feb 6, 2019

rust-highfive commented Feb 6, 2019

Centril commented Feb 6, 2019

bors commented Feb 6, 2019

bors commented Feb 7, 2019

bors commented Feb 7, 2019