Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
multiple substitutions become multiple children in JSON output #58221
This is a proposed fix for #53934.
The problem being solved is this: in our internal representation of diagnostics, a
Previously, the JSON-emitter was flat-mapping spans into the
Look specifically at the diff of the second "multiple substitutions become ..." commit to see the diff in the JSON output. (The first commit introduces some
rust-lang-nursery/rustfix#162 is the sister pull-request for rustfix.
Don't merge this yet; the following items need to be resolved first—
r? @ghost (attempting to suppress bors autoassignment since this isn't ready yet)
Click to expand the log.