Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Refactor ppaux out of existence. #58140
A long-time coming, this PR reorganizes and rewrites the pretty-printing architecture of rustc, specifically the parts that involve the typesystem (which used to be in
Note: these commits used to be in #57967 before being split off.
The new API (i.e. the
Design points, roughly:
Most of the behavior is unchanged, except for a few details, which should be clear from the test changes.
nikomatsakis left a comment
So I am generally positive on this PR. I think it's a great step towards a better pretty-printing system. However, I would like to see more comments! I left some review comments at specific places that I think could use some documentation to help convey the design a bit. I also left various other nits and questions.