New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quote_*! macros #51285

Open
wants to merge 2 commits into
base: master
from

Conversation

@Mark-Simulacrum
Member

Mark-Simulacrum commented Jun 1, 2018

This deletes a considerable amount of test cases, some of which we may want to keep. I'm not entirely certain what the primary intent of many of them was; if we should keep them I can attempt to edit each case to continue compiling without the quote_*! macros involved.

Fixes #46849.
Fixes #12265.
Fixes #12266.
Fixes #26994.

r? @Manishearth

@Manishearth

Looks good.

@Manishearth

This comment has been minimized.

Member

Manishearth commented Jun 1, 2018

cc @eddyb any reason we should keep these tests? They're mostly testing quasi quoting or old style proc macros, both of which we shouldn't need to care about as much now.

@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented Jun 1, 2018

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
  Downloading https://files.pythonhosted.org/packages/b9/03/6eea2653cb4a1f64c06eb1f9e848822cb6c9972cb5a518624eed5f74d06b/awscli-1.15.31-py2.py3-none-any.whl (1.3MB)
    0% |▎                               | 10kB 12.0MB/s eta 0:00:01
    1% |▌                               | 20kB 1.9MB/s eta 0:00:01
    2% |▉                               | 30kB 2.2MB/s eta 0:00:01
    3% |█                               | 40kB 2.0MB/s eta 0:00:01
---
[00:24:20]    Compiling syntax_ext v0.0.0 (file:///checkout/src/libsyntax_ext)
[00:24:20] error[E0557]: feature has been removed
[00:24:20]   --> librustc/lib.rs:60:12
[00:24:20]    |
[00:24:20] 60 | #![feature(quote)]
[00:24:20] 
-gnu/stage0/lib/rustlib/x86_64-unknown-linux-gnu
396292 ./.git/objects
396252 ./.git/objects/pack
---
146620 ./.git/modules/src
137732 ./obj/build/bootstrap/debug/incremental
126980 ./obj/build/x86_64-unknown-linux-gnu/stage1-std
123180 ./obj/build/bootstrap/debug/incremental/bootstrap-1r3bppl29tbrj
123176 ./obj/build/bootstrap/debug/incremental/bootstrap-1r3bppl29tbrj/s-f1ld71lnxw-kqamuf-2rxy29zuufd4c
91128 ./obj/build/x86_64-unknown-linux-gnu/stage1
91104 ./obj/build/x86_64-unknown-linux-gnu/stage1/lib
89796 ./src/llvm/test/CodeGen
79476 ./obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Mark-Simulacrum Mark-Simulacrum force-pushed the Mark-Simulacrum:remove-quote_apis branch from 1e6a6cf to c7cb32c Jun 2, 2018

@eddyb

This comment has been minimized.

Member

eddyb commented Jun 2, 2018

LGTM. cc @alexcrichton Do we want to move any of these tests to proc_macro?

@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented Jun 2, 2018

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:47:31] ..........................................................................i.........................
[00:47:36] ....................................................................................................
[00:47:42] ....................................................................................................
[00:47:49] ....................................................................................................
[00:47:53] ......i.................iiiiiiiii...................................................
[00:47:53] 
[00:47:53] travis_fold:start:test_ui_nll
travis_time:start:test_ui_nll
Check compiletest suite=ui mode=ui compare_mode=nll (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
---
[00:48:47] ..........................................................................i.........................
[00:48:52] ....................................................................................................
[00:48:57] ....................................................................................................
[00:49:03] ....................................................................................................
[00:49:08] ......i..................iiiiiiiii..................................................
[00:49:08] 
[00:49:08]  finished in 74.521
[00:49:08] travis_fold:end:test_ui_nll

---

[01:07:33] travis_fold:start:test_run-fail-fulldeps
travis_time:start:test_run-fail-fulldeps
Check compiletest suite=run-fail-fulldeps mode=run-fail (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:07:33] thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }', libcore/result.rs:945:5
[01:07:33] 
[01:07:33] 
[01:07:33] 
[01:07:33] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/run-fail-fulldeps" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/run-fail-fulldeps" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "run-fail" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-3.9/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options " "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "3.9.1\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:07:33] 
[01:07:33] 
[01:07:33] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:07:33] Build completed unsuccessfully in 0:22:28
[01:07:33] Build completed unsuccessfully in 0:22:28
[01:07:33] Makefile:58: recipe for target 'check' failed
[01:07:33] make: *** [check] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0430fad9
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Mark-Simulacrum

This comment has been minimized.

Member

Mark-Simulacrum commented Jun 2, 2018

We should probably cc @rust-lang/lang and maybe @rust-lang/libs here as well to check in since this is removing the unstable quote feature. FCP would be ideal but I don't have the rights to start it.

@sfackler sfackler added the T-libs label Jun 2, 2018

@sfackler

This comment has been minimized.

Member

sfackler commented Jun 2, 2018

It's not quite true that clippy was the only consumer of these - rust-phf uses them as well, for example: https://github.com/sfackler/rust-phf/blob/master/phf_macros/src/util.rs. It does still seem reasonable to move the ecosystem towards the newer APIs though.

I think this is probably a libs thing vs a lang thing, so I'll start an FCP there, but if lang folks want to jump in that works as well!

@rfcbot fcp merge

@rfcbot

This comment has been minimized.

rfcbot commented Jun 2, 2018

Team member @sfackler has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@eddyb

This comment has been minimized.

Member

eddyb commented Jun 4, 2018

@sfackler It seems phf_macro uses plugin_registrar - that will likely get removed sooner or later, so moving to the proc_macro approach in both interface and implementation is advisable.

@bors

This comment has been minimized.

Contributor

bors commented Jun 21, 2018

☔️ The latest upstream changes (presumably #48149) made this pull request unmergeable. Please resolve the merge conflicts.

@Mark-Simulacrum

This comment has been minimized.

Member

Mark-Simulacrum commented Jun 21, 2018

I'll rebase when/if this is approved.

@rfcbot

This comment has been minimized.

rfcbot commented Jun 22, 2018

🔔 This is now entering its final comment period, as per the review above. 🔔

@Mark-Simulacrum Mark-Simulacrum force-pushed the Mark-Simulacrum:remove-quote_apis branch from eef0919 to f2184c3 Jun 22, 2018

@Mark-Simulacrum

This comment has been minimized.

Member

Mark-Simulacrum commented Jun 22, 2018

@eddyb Do we want to wait for @alexcrichton's approval here?

@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented Jun 22, 2018

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:06:23]    Compiling rustc_data_structures v0.0.0 (file:///checkout/src/librustc_data_structures)
[00:06:25]    Compiling arena v0.0.0 (file:///checkout/src/libarena)
[00:06:26]    Compiling syntax_pos v0.0.0 (file:///checkout/src/libsyntax_pos)
[00:06:30]    Compiling rustc_errors v0.0.0 (file:///checkout/src/librustc_errors)
0m     new_parser_from_source_str(sess, name, source).parse_stmt()
[00:06:49]     | |_^
[00:06:49] 
[00:06:49] error: aborting due to 4 previous errors
[00:06:49] 
[00:06:49] 
[00:06:49] error: Could not compile `syntax`.
[00:06:49] 
[00:06:49] Caused by:
[00:06:49]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc --crate-name syntax libsyntax/lib.rs --color always --error-format json --crate-type dylib --emit=dep-info,link -C prefer-dynamic -C opt-level=2 -C metadata=6a2f0731783c2bd3 -C extra-filename=-6a2f0731783c2bd3 --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps --target x86_64-unknown-linux-gnu -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/release/deps --extern rustc_data_structures=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_data_structures-a7df2fc298b4fb06.so --extern rustc_errors=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_errors-c9d6678b1c0f0b46.so --extern scoped_tls=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libscoped_tls-b76c070114255d98.rlib --extern log=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/liblog-5073f1296cd24b67.rlib --extern syntax_pos=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libsyntax_pos-670f6bac60d99b34.so --extern serialize=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libserialize-5d0a8a65bb9fe29f.so --extern serialize=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libserialize-5d0a8a65bb9fe29f.rlib --extern rustc_target=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/librustc_target-58741ed9de9aae4f.so --extern bitflags=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-rustc/x86_64-unknown-linux-gnu/release/deps/libbitflags-99b4534960f92449.rlib` (exit code: 101)
[00:06:49] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" " jemalloc" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "--message-format" "json"
[00:06:49] expected success, got: exit code: 101
[00:06:49] thread 'main' panicked at 'cargo must succeed', bootstrap/compile.rs:1091:9
[00:06:49] travis_fold:end:stage0-rustc

[00:06:49] travis_time:end:stage0-rustc:start=1529691049296310564,finish=1529691123487131918,duration=74190821354


[00:06:49] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap build
[00:06:49] Build completed unsuccessfully in 0:01:26
[00:06:49] Makefile:28: recipe for target 'all' failed
[00:06:49] make: *** [all] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0907e5d3
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@petrochenkov

This comment has been minimized.

Contributor

petrochenkov commented Jun 22, 2018

Do we want to move any of these tests to proc_macro?

I wanted to suggest to migrate the tests to quote! initially, but they seem to be so specific to legacy plugins that it doesn't worth the effort.

@bors

This comment has been minimized.

Contributor

bors commented Dec 8, 2018

⌛️ Trying commit abe4182 with merge bc8e7ee...

bors added a commit that referenced this pull request Dec 8, 2018

Auto merge of #51285 - Mark-Simulacrum:remove-quote_apis, r=<try>
Remove quote_*! macros

This deletes a considerable amount of test cases, some of which we may want to keep. I'm not entirely certain what the primary intent of many of them was; if we should keep them I can attempt to edit each case to continue compiling without the quote_*! macros involved.

Fixes #46849.
Fixes #12265.
Fixes #12266.
Fixes #26994.

r? @Manishearth
@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented Dec 8, 2018

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:08a6a94c:start=1544228458171824670,finish=1544228459359309672,duration=1187485002
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors

This comment has been minimized.

Contributor

bors commented Dec 8, 2018

💔 Test failed - status-travis

@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented Dec 8, 2018

The job dist-x86_64-linux of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_fold:end:services

travis_fold:start:git.checkout
travis_time:start:02f79cd5
$ git clone --depth=2 --branch=try https://github.com/rust-lang/rust.git rust-lang/rust
---
travis_time:end:151e56f0:start=1544228996207746857,finish=1544228996214968578,duration=7221721
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:00571848
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"en

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Mark-Simulacrum Mark-Simulacrum force-pushed the Mark-Simulacrum:remove-quote_apis branch from abe4182 to 9b19586 Dec 8, 2018

@rust-highfive

This comment has been minimized.

Collaborator

rust-highfive commented Dec 8, 2018

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:0622f400:start=1544229270874937426,finish=1544229273505658078,duration=2630720652
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-5.0
---
[00:35:11]    Compiling rustc_codegen_ssa v0.0.0 (/checkout/src/librustc_codegen_ssa)
[00:35:11] error[E0557]: feature has been removed
[00:35:11]   --> src/librustc_codegen_ssa/lib.rs:25:12
[00:35:11]    |
[00:35:11] 25 | #![feature(quote)]
[00:35:11] 
[00:35:16] error: aborting due to previous error
[00:35:16] 
[00:35:16] For more information about this error, try `rustc --explain E0557`.
[00:35:16] For more information about this error, try `rustc --explain E0557`.
[00:35:16] error: Could not compile `rustc_codegen_ssa`.
[00:35:16] warning: build failed, waiting for other jobs to finish...
[00:35:33] error: build failed
[00:35:33] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "--message-format" "json"
[00:35:33] expected success, got: exit code: 101
[00:35:33] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap build
[00:35:33] Build completed unsuccessfully in 0:32:25
[00:35:33] Makefile:28: recipe for target 'all' failed
[00:35:33] make: *** [all] Error 1
travis_fold:end:after_failure.1
travis_fold:start:after_failure.2
travis_time:start:0cec0a04
$ ls -lat $HOME/Library/Logs/DiagnosticReports/
---
travis_time:end:20d5743e:start=1544231417099104525,finish=1544231417104186440,duration=5081915
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0b766444
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travi

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Mark-Simulacrum Mark-Simulacrum force-pushed the Mark-Simulacrum:remove-quote_apis branch from 9b19586 to 8bf152b Dec 8, 2018

@Mark-Simulacrum

This comment has been minimized.

Member

Mark-Simulacrum commented Dec 8, 2018

@bors try

@bors

This comment has been minimized.

Contributor

bors commented Dec 8, 2018

⌛️ Trying commit 8bf152b with merge 51fed10...

bors added a commit that referenced this pull request Dec 8, 2018

Auto merge of #51285 - Mark-Simulacrum:remove-quote_apis, r=<try>
Remove quote_*! macros

This deletes a considerable amount of test cases, some of which we may want to keep. I'm not entirely certain what the primary intent of many of them was; if we should keep them I can attempt to edit each case to continue compiling without the quote_*! macros involved.

Fixes #46849.
Fixes #12265.
Fixes #12266.
Fixes #26994.

r? @Manishearth
@bors

This comment has been minimized.

Contributor

bors commented Dec 8, 2018

☀️ Test successful - status-travis
State: approved= try=True

@Mark-Simulacrum

This comment has been minimized.

Member

Mark-Simulacrum commented Dec 8, 2018

@craterbot run start=master#0a7798079608b4ff014471ae64b6c8201aa59cdf end=try#51fed1065d4f23779902876ba8c37ed02399dde7 mode=check-only

@craterbot

This comment has been minimized.

Collaborator

craterbot commented Dec 8, 2018

👌 Experiment pr-51285-1 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@nagisa

This comment has been minimized.

Contributor

nagisa commented Dec 8, 2018

Rocket v0.4 has been released so merge away.

@craterbot

This comment has been minimized.

Collaborator

craterbot commented Dec 9, 2018

🚧 Experiment pr-51285-1 is now running on agent aws-2.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot

This comment has been minimized.

Collaborator

craterbot commented Dec 11, 2018

🎉 Experiment pr-51285-1 is completed!
📊 29 regressed and 0 fixed (50140 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@Centril

This comment has been minimized.

Contributor

Centril commented Dec 11, 2018

Regression tree

Possibly spurious

  • loggr-0.3.0

Actual:

  • pear_codegen:
    • basic-auth-raw-0.1.0
    • diesel_errors-0.1.3
    • hadron-0.1.0
    • limiting-factor-0.5.1
    • line-messaging-api-rocket-0.1.1
    • rocket-lenient-json-0.3.1
    • rocket-file-cache-1.0.0-beta
    • rocket-etagged-file-response-0.5.0
    • rocket_igniter-0.0.2
    • rocket-simpleauth-0.4.0
  • phf_macros-0.7.23:
    • css-0.0.22
    • css-autoprefix-0.0.5
    • css-purify-0.0.15
    • fix-rs-0.2.1
    • html5ever_ext-0.21.20
    • human_name-0.7.0
    • json-api-rocket-0.4.1
    • oil_shared-0.1.0
    • punkt-1.0.4
    • orf-0.1.0
    • openrtb-0.1.0
    • vstepchik/mold-web
    • Lythenas/rust-orgmode
    • tld-1.17.0
    • static_map_macros-0.2.0-beta
  • cluuname-0.1.8
  • google/rerast
@eddyb

This comment has been minimized.

Member

eddyb commented Dec 11, 2018

I think pear_codegen is part of Rocket, so those projects should update.

As for phf_macros, I guess that still needs to be ported over to proc macros.

@sfackler do you want this PR to wait on phf_macros?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment