Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upOnly insert nodes which changes lint levels in the LintLevelMap #58176
+79
−93
Conversation
rust-highfive
assigned
eddyb
Feb 5, 2019
rust-highfive
added
the
S-waiting-on-review
label
Feb 5, 2019
This comment has been minimized.
This comment has been minimized.
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
This comment has been minimized.
This comment has been minimized.
|
@bors try |
This comment has been minimized.
This comment has been minimized.
added a commit
that referenced
this pull request
Feb 5, 2019
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
@rust-timer build 0677dc2 |
This comment has been minimized.
This comment has been minimized.
rust-timer
commented
Feb 5, 2019
|
Success: Queued 0677dc2 with parent b2c6b8c, comparison URL. |
This comment has been minimized.
This comment has been minimized.
rust-timer
commented
Feb 5, 2019
|
Finished benchmarking try commit 0677dc2 |
Zoxc
force-pushed the
Zoxc:lint-levels
branch
2 times, most recently
from
1d97ce4
to
59c6c5a
Feb 6, 2019
This comment has been minimized.
This comment has been minimized.
|
@bors try |
This comment has been minimized.
This comment has been minimized.
added a commit
that referenced
this pull request
Feb 6, 2019
This comment has been minimized.
This comment has been minimized.
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Zoxc
force-pushed the
Zoxc:lint-levels
branch
from
59c6c5a
to
0426faa
Feb 6, 2019
Zoxc
changed the title
[WIP] Only insert nodes which changes lint levels in the LintLevelMap
Only insert nodes which changes lint levels in the LintLevelMap
Feb 6, 2019
This comment has been minimized.
This comment has been minimized.
|
@bors try |
This comment has been minimized.
This comment has been minimized.
added a commit
that referenced
this pull request
Feb 6, 2019
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
@rust-timer build f94acd0 |
This comment has been minimized.
This comment has been minimized.
rust-timer
commented
Feb 6, 2019
|
Success: Queued f94acd0 with parent 65e647c, comparison URL. |
This comment has been minimized.
This comment has been minimized.
rust-timer
commented
Feb 6, 2019
|
Finished benchmarking try commit f94acd0 |
Zoxc
changed the title
Only insert nodes which changes lint levels in the LintLevelMap
[WIP] Only insert nodes which changes lint levels in the LintLevelMap
Feb 6, 2019
This comment has been minimized.
This comment has been minimized.
|
@bors try |
This comment has been minimized.
This comment has been minimized.
added a commit
that referenced
this pull request
Feb 6, 2019
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
@rust-timer build 8762a64 |
This comment has been minimized.
This comment has been minimized.
rust-timer
commented
Feb 9, 2019
|
Success: Queued 8762a64 with parent a2ec156, comparison URL. |
Zoxc
force-pushed the
Zoxc:lint-levels
branch
from
9e0d26a
to
876f1c8
Feb 9, 2019
This comment has been minimized.
This comment has been minimized.
rust-timer
commented
Feb 9, 2019
|
Finished benchmarking try commit 8762a64 |
This comment has been minimized.
This comment has been minimized.
|
|
Zoxc
force-pushed the
Zoxc:lint-levels
branch
2 times, most recently
from
d5e511b
to
d0b6aa5
Feb 9, 2019
This comment has been minimized.
This comment has been minimized.
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Zoxc
force-pushed the
Zoxc:lint-levels
branch
from
d0b6aa5
to
427bb89
Feb 10, 2019
This comment has been minimized.
This comment has been minimized.
|
@bors try |
This comment has been minimized.
This comment has been minimized.
added a commit
that referenced
this pull request
Feb 10, 2019
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
@rust-timer build 341a256 |
This comment has been minimized.
This comment has been minimized.
rust-timer
commented
Feb 10, 2019
|
Success: Queued 341a256 with parent 2e08bb1, comparison URL. |
This comment has been minimized.
This comment has been minimized.
rust-timer
commented
Feb 10, 2019
|
Finished benchmarking try commit 341a256 |
Zoxc
force-pushed the
Zoxc:lint-levels
branch
from
427bb89
to
de114e3
Feb 10, 2019
Zoxc
changed the title
[WIP] Only insert nodes which changes lint levels in the LintLevelMap
Only insert nodes which changes lint levels in the LintLevelMap
Feb 10, 2019
Zoxc
reviewed
Feb 10, 2019
src/librustc_mir/util/pretty.rs Outdated
This comment has been minimized.
This comment has been minimized.
|
My guess is that the remaining regressions are more legitimate uses of the Executed queries diff for regex-check--- master.txt 2019-02-11 02:31:15.091536800 +0100
+++ lints.txt 2019-02-11 01:53:14.802134300 +0100
@@ -8654,6 +8653,7 @@
[task::green] DefSpan(core[c72f]::ops[0]::arith[0]::{{impl}}[42])
[task::green] DefSpan(core[c72f]::ops[0]::bit[0]::{{impl}}[1338])
[task::green] DefSpan(core[c72f]::ops[0]::bit[0]::{{impl}}[1351])
+[task::green] TypeckTables(regex[f8f2]::dfa[0]::{{impl}}[5]::exec_byte[0])
[task::green] DefSpan(core[c72f]::ops[0]::arith[0]::{{impl}}[300])
[task::green] DefSpan(core[c72f]::ops[0]::arith[0]::{{impl}}[314])
[task::green] DefSpan(core[c72f]::iter[0]::traits[0]::collect[0]::Extend[0])
@@ -8664,6 +8664,7 @@
[task::green] InherentImpls(core[c72f]::fmt[0]::builders[0]::DebugMap[0])
[task::green] DefSpan(alloc[b4a6]::string[0]::ToString[0])
[task::green] DefSpan(core[c72f]::fmt[0]::builders[0]::DebugMap[0])
+[task::green] TypeckTables(regex[f8f2]::dfa[0]::{{impl}}[11]::fmt[0])
[task::green] InherentImpls(core[c72f]::ascii[0]::EscapeDefault[0])
[task::green] InherentImpls(alloc[b4a6]::borrow[0]::Cow[0])
[task::green] DefSpan(alloc[b4a6]::borrow[0]::{{impl}}[3])
@@ -9381,6 +9382,7 @@
|
= note: #[warn(unused_mut)] on by default
+[task::green] BorrowCheck(regex[f8f2]::backtrack[0]::{{impl}}[1]::exec[0])
[task::green] DefSpan(utf8_ranges[c3e9]::Utf8Sequence[0]::Two[0]::0[0]::{{constant}}[0])
[task::green] ExternCrate(utf8_ranges[c3e9])
[task::green] DefSpan(utf8_ranges[c3e9]::Utf8Sequence[0]::Three[0]::0[0]::{{constant}}[0])
@@ -9393,6 +9395,7 @@
| |
| help: remove this `mut`
+[task::green] BorrowCheck(regex[f8f2]::dfa[0]::{{impl}}[5]::forward[0])
warning: variable does not need to be mutable
--> src\dfa.rs:498:13
|
@@ -9401,6 +9404,7 @@
| |
| help: remove this `mut`
+[task::green] BorrowCheck(regex[f8f2]::dfa[0]::{{impl}}[5]::reverse[0])
warning: variable does not need to be mutable
--> src\dfa.rs:532:13
|
@@ -9409,6 +9413,7 @@
| |
| help: remove this `mut`
+[task::green] BorrowCheck(regex[f8f2]::dfa[0]::{{impl}}[5]::forward_many[0])
[task::green] DefSpan(core[c72f]::cmp[0]::Ordering[0]::Less[0]::{{constant}}[0])
[task::green] DefSpan(core[c72f]::cmp[0]::Ordering[0]::Equal[0]::{{constant}}[0])
[task::green] DefSpan(core[c72f]::cmp[0]::Ordering[0]::Greater[0]::{{constant}}[0])
@@ -9420,6 +9425,7 @@
| |
| help: remove this `mut`
+[task::green] BorrowCheck(regex[f8f2]::pikevm[0]::{{impl}}[1]::exec[0])
warning: variable does not need to be mutable
--> src\re_bytes.rs:1013:9
|
@@ -9428,6 +9434,7 @@
| |
| help: remove this `mut`
+[task::green] BorrowCheck(regex[f8f2]::re_bytes[0]::extend_from_slice[0])
[task::red] MirBuilt(regex[f8f2]::re_set[0]::unicode[0]::{{impl}}[10]::clone[0])
[task::green] IsConstFn(regex[f8f2]::re_set[0]::unicode[0]::{{impl}}[10]::clone[0])
[task::green] UnsafetyCheckResult(regex[f8f2]::re_set[0]::unicode[0]::{{impl}}[10]::clone[0]) |
eddyb
added
S-blocked
and removed
S-waiting-on-review
labels
Feb 14, 2019
Zoxc
force-pushed the
Zoxc:lint-levels
branch
from
de114e3
to
a29c375
Feb 15, 2019
Zoxc
added
S-waiting-on-review
and removed
S-blocked
labels
Feb 15, 2019
Zoxc
reviewed
Feb 15, 2019
| }); | ||
|
|
||
| if has_lint_level { | ||
| LintLevel::Explicit(node_id) |
This comment has been minimized.
This comment has been minimized.
Zoxc
Feb 15, 2019
Author
Contributor
This path was always taken, so I replaced the callers of lint_level_of with LintLevel::Explicit.
Zoxc
force-pushed the
Zoxc:lint-levels
branch
from
a29c375
to
536bad7
Feb 15, 2019
This comment has been minimized.
This comment has been minimized.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Zoxc commentedFeb 5, 2019
r? @eddyb