Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make an assert debug-only in `find_constraint_paths_between_regions`. #58210

Merged
merged 1 commit into from Feb 7, 2019

Conversation

@nnethercote
Copy link
Contributor

commented Feb 6, 2019

This reduces instruction counts for NLL builds of wg-grammar by over
20%.

r? @nikomatsakis

Make an assert debug-only in `find_constraint_paths_between_regions`.
This reduces instruction counts for NLL builds of `wg-grammar` by over
20%.
@matthewjasper

This comment has been minimized.

Copy link
Contributor

commented Feb 6, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Feb 6, 2019

📌 Commit f7ed6e1 has been approved by matthewjasper

kennytm added a commit to kennytm/rust that referenced this pull request Feb 7, 2019

Rollup merge of rust-lang#58210 - nnethercote:find_outlives-debug_ass…
…ert, r=matthewjasper

Make an assert debug-only in `find_constraint_paths_between_regions`.

This reduces instruction counts for NLL builds of `wg-grammar` by over
20%.

r? @nikomatsakis

bors added a commit that referenced this pull request Feb 7, 2019

Auto merge of #58254 - kennytm:rollup, r=kennytm
Rollup of 23 pull requests

Successful merges:

 - #58118 (Transition libtest to 2018 edition)
 - #58119 (libproc_macro => 2018)
 - #58123 (Avoid some bounds checks in binary_heap::{PeekMut,Hole})
 - #58124 (libsyntax_pos => 2018)
 - #58133 (libsyntax_ext => 2018)
 - #58136 (Improve error message and docs for non-UTF-8 bytes in stdio on Windows)
 - #58156 (update submodule: rust-installer from 27dec6c to ccdc47b)
 - #58192 (Do not ICE in codegen when using a extern_type static)
 - #58193 (Move librustc to 2018)
 - #58210 (Make an assert debug-only in `find_constraint_paths_between_regions`.)
 - #58217 (librustc_tsan => 2018)
 - #58218 (librustc_msan => 2018)
 - #58219 (librustc_asan => 2018)
 - #58220 (libprofiler_builtins => 2018)
 - #58223 (librustc_lsan => 2018)
 - #58225 (librustc_fs_util => 2018)
 - #58228 (librustc_plugin => 2018)
 - #58236 (librustc_resolve => 2018)
 - #58237 (Fix broken grammar in iter::from_fn() docs)
 - #58239 (librustc_apfloat => 2018)
 - #58240 (librustc_errors => 2018)
 - #58241 (librustc_llvm => 2018)
 - #58242 (Document the one TyKind that isn't documented)

Failed merges:

 - #58185 (Remove images' url to make it work even without internet connection)

r? @ghost

@bors bors merged commit f7ed6e1 into rust-lang:master Feb 7, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@nnethercote nnethercote deleted the nnethercote:find_outlives-debug_assert branch Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.