New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more profiler events #58309

Merged
merged 3 commits into from Feb 14, 2019

Conversation

Projects
None yet
5 participants
@wesleywiser
Copy link
Member

wesleywiser commented Feb 8, 2019

  • Adds Start\Stop events for time spent loading incremental query results from disk.

  • Adds Start\Stop events for time spent blocked waiting for queries to complete (when parallel queries are enabled).

r? @michaelwoerister

Show resolved Hide resolved src/librustc/util/profiling.rs Outdated
Show resolved Hide resolved src/librustc/util/profiling.rs Outdated
Show resolved Hide resolved src/librustc/util/profiling.rs Outdated
Show resolved Hide resolved src/librustc/util/profiling.rs Outdated

@wesleywiser wesleywiser force-pushed the wesleywiser:add_more_profiler_events branch from 3f16a63 to 7690f4a Feb 10, 2019

@wesleywiser

This comment has been minimized.

Copy link
Member Author

wesleywiser commented Feb 10, 2019

@ljedrz Fixed, thanks!

wesleywiser added some commits Feb 7, 2019

Capture time spent blocked waiting on queries
This captures time spent blocked when a query is waiting for another
query to finish executing in another thread.

@wesleywiser wesleywiser force-pushed the wesleywiser:add_more_profiler_events branch from 7690f4a to e9ebc2e Feb 11, 2019

@michaelwoerister

This comment has been minimized.

Copy link
Contributor

michaelwoerister commented Feb 12, 2019

Thanks, @wesleywiser!
@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Feb 12, 2019

📌 Commit e9ebc2e has been approved by michaelwoerister

Centril added a commit to Centril/rust that referenced this pull request Feb 14, 2019

Rollup merge of rust-lang#58309 - wesleywiser:add_more_profiler_event…
…s, r=michaelwoerister

Add more profiler events

- Adds Start\Stop events for time spent loading incremental query results from disk.

- Adds Start\Stop events for time spent blocked waiting for queries to complete (when parallel queries are enabled).

r? @michaelwoerister

bors added a commit that referenced this pull request Feb 14, 2019

Auto merge of #58455 - Centril:rollup, r=Centril
Rollup of 7 pull requests

Successful merges:

 - #58309 (Add more profiler events)
 - #58347 (Closure bounds fixes)
 - #58365 (Add an option to print the status of incremental tasks / dep nodes after running them)
 - #58371 (Check user type annotations for range patterns.)
 - #58378 (rustc: Implement incremental "fat" LTO)
 - #58407 (specify "upper camel case" in style lint)
 - #58449 (Notify @topecongiro when the state of rustfmt has changed)

Failed merges:

r? @ghost

@bors bors merged commit e9ebc2e into rust-lang:master Feb 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment