Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement specialized nth_back() for Box and Windows. #59328

Merged
merged 2 commits into from Mar 24, 2019

Conversation

Projects
None yet
5 participants
@koalatux
Copy link
Contributor

commented Mar 20, 2019

Hi there, this is my first pull request to rust :-)

I started implementing some specializations for DoubleEndedIterator::nth_back() and these are the first two. The problem has been discussed in #54054 and nth_back() is tracked in #56995.

I'm stuck with the next implementation so I though I do a PR for the ones I'm confident with to get some feedback.

koalatux added some commits Feb 16, 2019

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Mar 20, 2019

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @rkruppe (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rkruppe

This comment has been minimized.

Copy link
Member

commented Mar 20, 2019

Welcome and thank you for your work! I'm going to hand this review over to @scottmcm since they appear to have a pretty good idea of what's necessary here and I... don't 😅

r? @scottmcm

@rust-highfive rust-highfive assigned scottmcm and unassigned rkruppe Mar 20, 2019

@scottmcm

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

These look good to me; Thanks!

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

📌 Commit 739ba04 has been approved by scottmcm

kennytm added a commit to kennytm/rust that referenced this pull request Mar 24, 2019

Rollup merge of rust-lang#59328 - koalatux:iter-nth-back, r=scottmcm
Implement specialized nth_back() for Box and Windows.

Hi there, this is my first pull request to rust :-)

I started implementing some specializations for DoubleEndedIterator::nth_back() and these are the first two. The problem has been discussed in rust-lang#54054 and nth_back() is tracked in rust-lang#56995.

I'm stuck with the next implementation so I though I do a PR for the ones I'm confident with to get some feedback.

bors added a commit that referenced this pull request Mar 24, 2019

Auto merge of #59397 - kennytm:rollup, r=kennytm
Rollup of 9 pull requests

Successful merges:

 - #59213 (Track changes to robots.txt)
 - #59239 (Remove inline assembly from hint::spin_loop)
 - #59242 (make asm diagnostic instruction optional)
 - #59251 (Use a valid name for graphviz graphs)
 - #59296 (Do not encode gensymed imports in metadata)
 - #59328 (Implement specialized nth_back() for Box and Windows.)
 - #59355 (Fix ICE with const generic param in struct)
 - #59366 (Update books)
 - #59377 (Correct minimum system LLVM version in tests)

Failed merges:

r? @ghost

kennytm added a commit to kennytm/rust that referenced this pull request Mar 24, 2019

Rollup merge of rust-lang#59328 - koalatux:iter-nth-back, r=scottmcm
Implement specialized nth_back() for Box and Windows.

Hi there, this is my first pull request to rust :-)

I started implementing some specializations for DoubleEndedIterator::nth_back() and these are the first two. The problem has been discussed in rust-lang#54054 and nth_back() is tracked in rust-lang#56995.

I'm stuck with the next implementation so I though I do a PR for the ones I'm confident with to get some feedback.

bors added a commit that referenced this pull request Mar 24, 2019

Auto merge of #59397 - kennytm:rollup, r=kennytm
Rollup of 8 pull requests

Successful merges:

 - #59213 (Track changes to robots.txt)
 - #59239 (Remove inline assembly from hint::spin_loop)
 - #59251 (Use a valid name for graphviz graphs)
 - #59296 (Do not encode gensymed imports in metadata)
 - #59328 (Implement specialized nth_back() for Box and Windows.)
 - #59355 (Fix ICE with const generic param in struct)
 - #59366 (Update books)
 - #59377 (Correct minimum system LLVM version in tests)

bors added a commit that referenced this pull request Mar 24, 2019

Auto merge of #59397 - kennytm:rollup, r=kennytm
Rollup of 7 pull requests

Successful merges:

 - #59213 (Track changes to robots.txt)
 - #59239 (Remove inline assembly from hint::spin_loop)
 - #59251 (Use a valid name for graphviz graphs)
 - #59296 (Do not encode gensymed imports in metadata)
 - #59328 (Implement specialized nth_back() for Box and Windows.)
 - #59355 (Fix ICE with const generic param in struct)
 - #59377 (Correct minimum system LLVM version in tests)

@bors bors merged commit 739ba04 into rust-lang:master Mar 24, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@koalatux koalatux deleted the koalatux:iter-nth-back branch Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.