Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement for comparision against fn #59798

Merged
merged 5 commits into from Apr 14, 2019

Conversation

Projects
None yet
6 participants
@rchaser53
Copy link
Contributor

commented Apr 8, 2019

I try to add error message.
related: #59488

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Apr 8, 2019

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Show resolved Hide resolved src/librustc_typeck/check/op.rs Outdated
@petrochenkov

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

Show resolved Hide resolved src/librustc_typeck/check/op.rs Outdated
};

if self.lookup_op_method(fn_sig.output(),
&[other_ty],

This comment has been minimized.

Copy link
@estebank

estebank Apr 11, 2019

Contributor

We could have another code branch for the case where both ty and other_ty are fns, so that you can suggest calling both of them, if their return types are the same.

Show resolved Hide resolved src/librustc_typeck/check/op.rs Outdated
Show resolved Hide resolved src/librustc_typeck/check/op.rs Outdated
@rchaser53

This comment has been minimized.

Copy link
Contributor Author

commented Apr 12, 2019

I reflected the estebank's review.

@estebank

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

📌 Commit d01ac0d has been approved by estebank

@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 14, 2019

⌛️ Testing commit d01ac0d with merge 464473a...

bors added a commit that referenced this pull request Apr 14, 2019

Auto merge of #59798 - rchaser53:issue-59488, r=estebank
Improvement for comparision against fn

I try to add error message.
related: #59488
@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 14, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: estebank
Pushing 464473a to master...

@bors bors added the merged-by-bors label Apr 14, 2019

@bors bors merged commit d01ac0d into rust-lang:master Apr 14, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
homu Test successful
Details

@rchaser53 rchaser53 deleted the rchaser53:issue-59488 branch Apr 14, 2019

bors added a commit that referenced this pull request Apr 19, 2019

Auto merge of #60073 - rchaser53:issue-60049, r=estebank
avoid type-check body of DefId

fix: #60049
related: PR #59798
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.