Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for incompatible universes in borrow errors #60327

Merged
merged 1 commit into from May 1, 2019

Conversation

Projects
None yet
5 participants
@matthewjasper
Copy link
Contributor

commented Apr 27, 2019

If we have a borrow that has to live for 'static we need to check for
any regions in incompatible universes when trying to find the cause.

closes #60274

Search for incompatible universes in borrow errors
If we have a borrow that has to live for `'static` we need to check for
any regions in incompatible universes when trying to find the cause.
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Apr 27, 2019

r? @michaelwoerister

(rust_highfive has picked a reviewer for you, use r? to override)

@michaelwoerister

This comment has been minimized.

Copy link
Contributor

commented Apr 29, 2019

Thanks, @matthewjasper!
r? @nikomatsakis for re-assignment.

@nikomatsakis

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

📌 Commit a962274 has been approved by nikomatsakis

Centril added a commit to Centril/rust that referenced this pull request May 1, 2019

Rollup merge of rust-lang#60327 - matthewjasper:handle-local-outlives…
…-lbl, r=nikomatsakis

Search for incompatible universes in borrow errors

If we have a borrow that has to live for `'static` we need to check for
any regions in incompatible universes when trying to find the cause.

closes rust-lang#60274

@Centril Centril referenced this pull request May 1, 2019

Closed

Rollup of 8 pull requests #60433

bors added a commit that referenced this pull request May 1, 2019

Auto merge of #60433 - Centril:rollup-l534wjc, r=Centril
Rollup of 8 pull requests

Successful merges:

 - #60287 (Use references for variances_of)
 - #60327 (Search for incompatible universes in borrow errors)
 - #60330 (Suggest using an inclusive range instead of an exclusive range when the endpoint overflows by 1)
 - #60366 (build-gcc: Create missing cc symlink)
 - #60369 (Support ZSTs in DispatchFromDyn)
 - #60404 (Implement `BorrowMut<str>` for `String`)
 - #60417 (Rename hir::ExprKind::Use to ::DropTemps and improve docs.)
 - #60432 (Update clippy)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request May 1, 2019

Rollup merge of rust-lang#60327 - matthewjasper:handle-local-outlives…
…-lbl, r=nikomatsakis

Search for incompatible universes in borrow errors

If we have a borrow that has to live for `'static` we need to check for
any regions in incompatible universes when trying to find the cause.

closes rust-lang#60274

@Centril Centril referenced this pull request May 1, 2019

Closed

Rollup of 7 pull requests #60434

bors added a commit that referenced this pull request May 1, 2019

Auto merge of #60434 - Centril:rollup-x1iczrh, r=Centril
Rollup of 7 pull requests

Successful merges:

 - #60327 (Search for incompatible universes in borrow errors)
 - #60330 (Suggest using an inclusive range instead of an exclusive range when the endpoint overflows by 1)
 - #60366 (build-gcc: Create missing cc symlink)
 - #60369 (Support ZSTs in DispatchFromDyn)
 - #60404 (Implement `BorrowMut<str>` for `String`)
 - #60417 (Rename hir::ExprKind::Use to ::DropTemps and improve docs.)
 - #60432 (Update clippy)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request May 1, 2019

Rollup merge of rust-lang#60327 - matthewjasper:handle-local-outlives…
…-lbl, r=nikomatsakis

Search for incompatible universes in borrow errors

If we have a borrow that has to live for `'static` we need to check for
any regions in incompatible universes when trying to find the cause.

closes rust-lang#60274

@Centril Centril referenced this pull request May 1, 2019

Merged

Rollup of 7 pull requests #60435

bors added a commit that referenced this pull request May 1, 2019

Auto merge of #60435 - Centril:rollup-aa5lmuw, r=Centril
Rollup of 7 pull requests

Successful merges:

 - #60287 (Use references for variances_of)
 - #60327 (Search for incompatible universes in borrow errors)
 - #60330 (Suggest using an inclusive range instead of an exclusive range when the endpoint overflows by 1)
 - #60366 (build-gcc: Create missing cc symlink)
 - #60369 (Support ZSTs in DispatchFromDyn)
 - #60404 (Implement `BorrowMut<str>` for `String`)
 - #60417 (Rename hir::ExprKind::Use to ::DropTemps and improve docs.)

Failed merges:

r? @ghost
@nikomatsakis

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

@matthewjasper can you test if this also fixes #60218 ?

bors added a commit that referenced this pull request May 1, 2019

Auto merge of #60435 - Centril:rollup-aa5lmuw, r=Centril
Rollup of 7 pull requests

Successful merges:

 - #60287 (Use references for variances_of)
 - #60327 (Search for incompatible universes in borrow errors)
 - #60330 (Suggest using an inclusive range instead of an exclusive range when the endpoint overflows by 1)
 - #60366 (build-gcc: Create missing cc symlink)
 - #60369 (Support ZSTs in DispatchFromDyn)
 - #60404 (Implement `BorrowMut<str>` for `String`)
 - #60417 (Rename hir::ExprKind::Use to ::DropTemps and improve docs.)

Failed merges:

r? @ghost

bors added a commit that referenced this pull request May 1, 2019

Auto merge of #60435 - Centril:rollup-aa5lmuw, r=Centril
Rollup of 7 pull requests

Successful merges:

 - #60287 (Use references for variances_of)
 - #60327 (Search for incompatible universes in borrow errors)
 - #60330 (Suggest using an inclusive range instead of an exclusive range when the endpoint overflows by 1)
 - #60366 (build-gcc: Create missing cc symlink)
 - #60369 (Support ZSTs in DispatchFromDyn)
 - #60404 (Implement `BorrowMut<str>` for `String`)
 - #60417 (Rename hir::ExprKind::Use to ::DropTemps and improve docs.)

Failed merges:

r? @ghost
@matthewjasper

This comment has been minimized.

Copy link
Contributor Author

commented May 1, 2019

It doesn't

@bors bors merged commit a962274 into rust-lang:master May 1, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@matthewjasper matthewjasper deleted the matthewjasper:handle-local-outlives-lbl branch May 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.