Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement `BorrowMut<str>` for `String` #60404

Merged
merged 1 commit into from May 1, 2019

Conversation

Projects
None yet
9 participants
@lo48576
Copy link
Contributor

commented Apr 30, 2019

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Apr 30, 2019

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@lzutao

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

@rustbot modify labels to +T-libs

@rustbot rustbot added the T-libs label Apr 30, 2019

@Centril Centril added the relnotes label Apr 30, 2019

@Centril Centril added this to the 1.36 milestone Apr 30, 2019

@Centril

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

@sfackler

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

@bors r+ rollup

Thanks!

@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2019

📌 Commit a0e112b has been approved by sfackler

@Centril Centril removed the needs-fcp label Apr 30, 2019

Centril added a commit to Centril/rust that referenced this pull request Apr 30, 2019

Rollup merge of rust-lang#60404 - lo48576:borrow-mut-for-string, r=sf…
…ackler

Implement `BorrowMut<str>` for `String`

Closes rust-lang/rfcs#1282.

bors added a commit that referenced this pull request Apr 30, 2019

Auto merge of #60420 - Centril:rollup-1dw8n6g, r=Centril
Rollup of 7 pull requests

Successful merges:

 - #60204 (Debug-print error when using rtunwrap)
 - #60280 (Fix indexing issue for const parameter invariance)
 - #60287 (Use references for variances_of)
 - #60369 (Support ZSTs in DispatchFromDyn)
 - #60402 (libprofiler_builtins: Set compilation flags more correctly for C code.)
 - #60404 (Implement `BorrowMut<str>` for `String`)
 - #60417 (Rename hir::ExprKind::Use to ::DropTemps and improve docs.)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request May 1, 2019

Rollup merge of rust-lang#60404 - lo48576:borrow-mut-for-string, r=sf…
…ackler

Implement `BorrowMut<str>` for `String`

Closes rust-lang/rfcs#1282.

@Centril Centril referenced this pull request May 1, 2019

Closed

Rollup of 8 pull requests #60433

bors added a commit that referenced this pull request May 1, 2019

Auto merge of #60433 - Centril:rollup-l534wjc, r=Centril
Rollup of 8 pull requests

Successful merges:

 - #60287 (Use references for variances_of)
 - #60327 (Search for incompatible universes in borrow errors)
 - #60330 (Suggest using an inclusive range instead of an exclusive range when the endpoint overflows by 1)
 - #60366 (build-gcc: Create missing cc symlink)
 - #60369 (Support ZSTs in DispatchFromDyn)
 - #60404 (Implement `BorrowMut<str>` for `String`)
 - #60417 (Rename hir::ExprKind::Use to ::DropTemps and improve docs.)
 - #60432 (Update clippy)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request May 1, 2019

Rollup merge of rust-lang#60404 - lo48576:borrow-mut-for-string, r=sf…
…ackler

Implement `BorrowMut<str>` for `String`

Closes rust-lang/rfcs#1282.

@Centril Centril referenced this pull request May 1, 2019

Closed

Rollup of 7 pull requests #60434

bors added a commit that referenced this pull request May 1, 2019

Auto merge of #60434 - Centril:rollup-x1iczrh, r=Centril
Rollup of 7 pull requests

Successful merges:

 - #60327 (Search for incompatible universes in borrow errors)
 - #60330 (Suggest using an inclusive range instead of an exclusive range when the endpoint overflows by 1)
 - #60366 (build-gcc: Create missing cc symlink)
 - #60369 (Support ZSTs in DispatchFromDyn)
 - #60404 (Implement `BorrowMut<str>` for `String`)
 - #60417 (Rename hir::ExprKind::Use to ::DropTemps and improve docs.)
 - #60432 (Update clippy)

Failed merges:

r? @ghost

Centril added a commit to Centril/rust that referenced this pull request May 1, 2019

Rollup merge of rust-lang#60404 - lo48576:borrow-mut-for-string, r=sf…
…ackler

Implement `BorrowMut<str>` for `String`

Closes rust-lang/rfcs#1282.

@Centril Centril referenced this pull request May 1, 2019

Merged

Rollup of 7 pull requests #60435

bors added a commit that referenced this pull request May 1, 2019

Auto merge of #60435 - Centril:rollup-aa5lmuw, r=Centril
Rollup of 7 pull requests

Successful merges:

 - #60287 (Use references for variances_of)
 - #60327 (Search for incompatible universes in borrow errors)
 - #60330 (Suggest using an inclusive range instead of an exclusive range when the endpoint overflows by 1)
 - #60366 (build-gcc: Create missing cc symlink)
 - #60369 (Support ZSTs in DispatchFromDyn)
 - #60404 (Implement `BorrowMut<str>` for `String`)
 - #60417 (Rename hir::ExprKind::Use to ::DropTemps and improve docs.)

Failed merges:

r? @ghost

bors added a commit that referenced this pull request May 1, 2019

Auto merge of #60435 - Centril:rollup-aa5lmuw, r=Centril
Rollup of 7 pull requests

Successful merges:

 - #60287 (Use references for variances_of)
 - #60327 (Search for incompatible universes in borrow errors)
 - #60330 (Suggest using an inclusive range instead of an exclusive range when the endpoint overflows by 1)
 - #60366 (build-gcc: Create missing cc symlink)
 - #60369 (Support ZSTs in DispatchFromDyn)
 - #60404 (Implement `BorrowMut<str>` for `String`)
 - #60417 (Rename hir::ExprKind::Use to ::DropTemps and improve docs.)

Failed merges:

r? @ghost

bors added a commit that referenced this pull request May 1, 2019

Auto merge of #60435 - Centril:rollup-aa5lmuw, r=Centril
Rollup of 7 pull requests

Successful merges:

 - #60287 (Use references for variances_of)
 - #60327 (Search for incompatible universes in borrow errors)
 - #60330 (Suggest using an inclusive range instead of an exclusive range when the endpoint overflows by 1)
 - #60366 (build-gcc: Create missing cc symlink)
 - #60369 (Support ZSTs in DispatchFromDyn)
 - #60404 (Implement `BorrowMut<str>` for `String`)
 - #60417 (Rename hir::ExprKind::Use to ::DropTemps and improve docs.)

Failed merges:

r? @ghost

@bors bors merged commit a0e112b into rust-lang:master May 1, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@lo48576 lo48576 deleted the lo48576:borrow-mut-for-string branch May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.