Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary unwraps #60720

Merged
merged 1 commit into from
May 12, 2019
Merged

Remove unnecessary unwraps #60720

merged 1 commit into from
May 12, 2019

Conversation

estebank
Copy link
Contributor

Fix #60713.

@rust-highfive
Copy link
Collaborator

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 10, 2019
estebank
estebank commented May 10, 2019
View reviewed changes
src/librustc_typeck/check/method/suggest.rs
String::new(),
Applicability::MaybeIncorrect,
);
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only this change was needed, but avoiding the other unwraps is worthwhile.

@estebank
Copy link
Contributor Author

r? @zackmdavis

@rust-highfive rust-highfive assigned zackmdavis and unassigned pnkfelix May 10, 2019
@rust-highfive

This comment has been minimized.

Sign in to view
@zackmdavis
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented May 11, 2019

📌 Commit c158a0f has been approved by zackmdavis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2019
@jethrogb
Copy link
Contributor

Needs test?

@zackmdavis
Copy link
Member

@jethrogb good question! Unless someone can further minimize your motivating example to not need a dependency (so, no juniper_codegen), I'm inclined to just trust @estebank on this one?

Centril added a commit to Centril/rust that referenced this pull request May 11, 2019
@Centril
Rollup merge of rust-lang#60720 - estebank:no-ice-thanks, r=zackmdavis
5da009e 
Remove unnecessary unwraps

Fix rust-lang#60713.
@Centril Centril mentioned this pull request May 11, 2019
Merged
bors added a commit that referenced this pull request May 11, 2019
@bors
Auto merge of #60748 - Centril:rollup-rr63jqo, r=Centril
d28e948 
Rollup of 4 pull requests

Successful merges:

 - #60720 (Remove unnecessary unwraps)
 - #60727 (add comment to `Rc`/`Arc`'s `Eq` specialization)
 - #60733 (Cleanup the .await HIR lowering with .stmt(..).)
 - #60741 (Remove redundant "let mut" in write_graph_label)

Failed merges:

r? @ghost
@estebank
Copy link
Contributor Author

The ideal thing would be to add a test but because it required two crates to repro writing it would have taken me a hit longer. Having said that the change should be good as it is, but thanks for keeping your eyes peeled @jethrogb and thanks @zackmdavid for the vote of confidence ^_^

@bors bors merged commit c158a0f into rust-lang:master May 12, 2019
@estebank estebank deleted the no-ice-thanks branch November 9, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zackmdavis zackmdavis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ICE in rustc_typeck::check::method::suggest::<impl rustc_typeck::check::FnCtxt>::report_method_error
6 participants
@estebank @rust-highfive @zackmdavis @bors @jethrogb @pnkfelix