Skip to content

Rollup of 4 pull requests #60748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 12, 2019
Merged

Rollup of 4 pull requests #60748

merged 8 commits into from
May 12, 2019

Conversation

Centril
Copy link
Contributor

@Centril Centril commented May 11, 2019

Successful merges:

Failed merges:

r? @ghost

estebank and others added 8 commits May 10, 2019 17:57
@estebank
Remove unnecessary unwraps
c158a0f
@chpio
add comment to Rc/Arc's Eq specialization
740a8da
@Centril
Cleanup the .await HIR lowering with .stmt(..).
362431b
@shiatsumat
Remove redundant "let mut" in write_graph_label
a145b14 
Removed the redundant "let mut" in the write_graph_label function (it caused "let mut let mut" for non-user-defined local variables).
@Centril
Rollup merge of rust-lang#60720 - estebank:no-ice-thanks, r=zackmdavis
5da009e 
Remove unnecessary unwraps

Fix rust-lang#60713.
@Centril
Rollup merge of rust-lang#60727 - chpio:master, r=sfackler
e19ad45 
add comment to `Rc`/`Arc`'s `Eq` specialization

in addition to rust-lang#56550

rust-lang#42965 (comment)
@Centril
Rollup merge of rust-lang#60733 - Centril:cleanup-lowering-await, r=v…
5490cc1 
…arkor

Cleanup the .await HIR lowering with .stmt(..).

r? @cramertj
@Centril
Rollup merge of rust-lang#60741 - shiatsumat:patch-let-mut-write-grap…
f2dd97c 
…h-label, r=varkor

Remove redundant "let mut" in write_graph_label

Removed the redundant "let mut" in the write_graph_label function (it caused "let mut let mut" for non-user-defined local variables).
@Centril
Copy link
Contributor Author

Centril commented May 11, 2019

@bors r+ p=4 rollup=never

@bors
Copy link
Collaborator

bors commented May 11, 2019

📌 Commit f2dd97c has been approved by Centril

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 11, 2019
@bors
Copy link
Collaborator

bors commented May 11, 2019

⌛ Testing commit f2dd97c with merge d28e948...

bors added a commit that referenced this pull request May 11, 2019
@bors
Auto merge of #60748 - Centril:rollup-rr63jqo, r=Centril
d28e948 
Rollup of 4 pull requests

Successful merges:

 - #60720 (Remove unnecessary unwraps)
 - #60727 (add comment to `Rc`/`Arc`'s `Eq` specialization)
 - #60733 (Cleanup the .await HIR lowering with .stmt(..).)
 - #60741 (Remove redundant "let mut" in write_graph_label)

Failed merges:

r? @ghost
@bors
Copy link
Collaborator

bors commented May 12, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Centril
Pushing d28e948 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 12, 2019
@bors bors merged commit f2dd97c into rust-lang:master May 12, 2019
@Centril Centril deleted the rollup-rr63jqo branch May 12, 2019 01:17
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Centril @bors @estebank @chpio @shiatsumat