Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

request at least ptr-size alignment from posix_memalign #62296

Merged
merged 4 commits into from
Jul 6, 2019
Merged

request at least ptr-size alignment from posix_memalign #62296

merged 4 commits into from
Jul 6, 2019

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Jul 2, 2019

Fixes #62251

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 2, 2019
@RalfJung RalfJung mentioned this pull request Jul 2, 2019
Closed
@RalfJung RalfJung mentioned this pull request Jul 2, 2019
Closed
@RalfJung
Copy link
Member Author

RalfJung commented Jul 2, 2019

I expanded the check_overalign_request test to actually cover this; it now fails without this patch.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jul 2, 2019

📌 Commit 45e7ba9 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 2, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 3, 2019
@Centril
Rollup merge of rust-lang#62296 - RalfJung:memalign, r=alexcrichton
40b5c09 
request at least ptr-size alignment from posix_memalign

Fixes rust-lang#62251
@Centril Centril mentioned this pull request Jul 3, 2019
Closed
@Centril
Copy link
Contributor

Centril commented Jul 3, 2019

Failed in #62349 (comment), @bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 3, 2019
@RalfJung
Copy link
Member Author

RalfJung commented Jul 3, 2019 

error‌: unused import: `crate::mem`‌
 ‌--> ‌src/libstd/sys/unix/alloc.rs:4:5‌
  ‌|‌
4‌ ‌| ‌use crate::mem;‌
  ‌| ‌    ‌^^^^^^^^^^‌
  ‌|‌
  ‌= ‌note‌: `-D unused-imports` implied by `-D warnings`‌

(It was actually hard to copy-paste that piece of corrupted output from https://dev.azure.com/rust-lang/rust/_build/results?buildId=2298... impressive, Azure is doing worse than AppVeyor in that regard.)

@RalfJung
Copy link
Member Author

RalfJung commented Jul 3, 2019

@alexcrichton This should fix the unused-import error.

@RalfJung RalfJung added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 4, 2019
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jul 4, 2019

📌 Commit 2e47fc3 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 4, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 5, 2019
@Centril
Rollup merge of rust-lang#62296 - RalfJung:memalign, r=alexcrichton
c2b89eb 
request at least ptr-size alignment from posix_memalign

Fixes rust-lang#62251
@Centril Centril mentioned this pull request Jul 5, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Jul 5, 2019
@Centril
Rollup merge of rust-lang#62296 - RalfJung:memalign, r=alexcrichton
6cffcc9 
request at least ptr-size alignment from posix_memalign

Fixes rust-lang#62251
@Centril Centril mentioned this pull request Jul 5, 2019
Closed
bors added a commit that referenced this pull request Jul 5, 2019
@bors
Auto merge of #62424 - Centril:rollup-hry6eak, r=Centril
c2a2cb9 
Rollup of 8 pull requests

Successful merges:

 - #60260 (Add support for UWP targets)
 - #62151 (Update linked OpenSSL version)
 - #62245 (Miri engine: support extra function (pointer) values)
 - #62257 (forward read_c_str method from Memory to Alloc)
 - #62264 (Fix perf regression from Miri Machine trait changes)
 - #62296 (request at least ptr-size alignment from posix_memalign)
 - #62329 (Remove support for 1-token lookahead from the lexer)
 - #62377 (Add test for ICE #62375)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Jul 6, 2019
@Centril
Rollup merge of rust-lang#62296 - RalfJung:memalign, r=alexcrichton
3c4a6c8 
request at least ptr-size alignment from posix_memalign

Fixes rust-lang#62251
@Centril Centril mentioned this pull request Jul 6, 2019
Merged
bors added a commit that referenced this pull request Jul 6, 2019
@bors
Auto merge of #62428 - Centril:rollup-2udow5e, r=Centril
b820c76 
Rollup of 7 pull requests

Successful merges:

 - #62151 (Update linked OpenSSL version)
 - #62245 (Miri engine: support extra function (pointer) values)
 - #62257 (forward read_c_str method from Memory to Alloc)
 - #62264 (Fix perf regression from Miri Machine trait changes)
 - #62296 (request at least ptr-size alignment from posix_memalign)
 - #62329 (Remove support for 1-token lookahead from the lexer)
 - #62377 (Add test for ICE #62375)

Failed merges:

r? @ghost
@bors bors merged commit 2e47fc3 into rust-lang:master Jul 6, 2019
@RalfJung RalfJung deleted the memalign branch July 6, 2019 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

We call posix_memalign with a too small alignment
5 participants
@RalfJung @rust-highfive @alexcrichton @bors @Centril