Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for ICE #62375 #62377

Merged
merged 1 commit into from
Jul 6, 2019
Merged

Add test for ICE #62375 #62377

merged 1 commit into from
Jul 6, 2019

Conversation

wesleywiser
Copy link
Member

Fixes #62375

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 4, 2019
@Centril
Copy link
Contributor

Centril commented Jul 4, 2019 •
edited
Loading

As a general strategy on testing, I would prefer that test's not be added to the issues/ folder. Ideally we put them in some appropriate place (e.g. enums/ or whatnot) and name the file with more than just the issue number (e.g. include something about what the test is about in addition to the number).

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jul 4, 2019

📌 Commit 12672e2 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 4, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 5, 2019
@Centril
Rollup merge of rust-lang#62377 - wesleywiser:fix_62375, r=alexcrichton
a5ab8b2 
Add test for ICE rust-lang#62375

Fixes rust-lang#62375
@Centril Centril mentioned this pull request Jul 5, 2019
Closed
bors added a commit that referenced this pull request Jul 5, 2019
@bors
Auto merge of #62424 - Centril:rollup-hry6eak, r=Centril
c2a2cb9 
Rollup of 8 pull requests

Successful merges:

 - #60260 (Add support for UWP targets)
 - #62151 (Update linked OpenSSL version)
 - #62245 (Miri engine: support extra function (pointer) values)
 - #62257 (forward read_c_str method from Memory to Alloc)
 - #62264 (Fix perf regression from Miri Machine trait changes)
 - #62296 (request at least ptr-size alignment from posix_memalign)
 - #62329 (Remove support for 1-token lookahead from the lexer)
 - #62377 (Add test for ICE #62375)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Jul 6, 2019
@Centril
Rollup merge of rust-lang#62377 - wesleywiser:fix_62375, r=alexcrichton
46edb51 
Add test for ICE rust-lang#62375

Fixes rust-lang#62375
@Centril Centril mentioned this pull request Jul 6, 2019
Merged
bors added a commit that referenced this pull request Jul 6, 2019
@bors
Auto merge of #62428 - Centril:rollup-2udow5e, r=Centril
b820c76 
Rollup of 7 pull requests

Successful merges:

 - #62151 (Update linked OpenSSL version)
 - #62245 (Miri engine: support extra function (pointer) values)
 - #62257 (forward read_c_str method from Memory to Alloc)
 - #62264 (Fix perf regression from Miri Machine trait changes)
 - #62296 (request at least ptr-size alignment from posix_memalign)
 - #62329 (Remove support for 1-token lookahead from the lexer)
 - #62377 (Add test for ICE #62375)

Failed merges:

r? @ghost
@bors bors merged commit 12672e2 into rust-lang:master Jul 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Internal compiler error with enums
5 participants
@wesleywiser @rust-highfive @Centril @alexcrichton @bors