Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize duration_float #62756

Merged
merged 4 commits into from Aug 10, 2019

Conversation

@newpavlov
Copy link
Contributor

commented Jul 17, 2019

Closes: #54361

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Jul 17, 2019

r? @aidanhs

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Jul 17, 2019

The job mingw-check of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-07-17T15:38:49.2011872Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-07-17T15:38:49.2231250Z ##[command]git config gc.auto 0
2019-07-17T15:38:49.2319496Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-07-17T15:38:49.2374389Z ##[command]git config --get-all http.proxy
2019-07-17T15:38:49.2542060Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/62756/merge:refs/remotes/pull/62756/merge
---
2019-07-17T15:39:25.8530909Z do so (now or later) by using -b with the checkout command again. Example:
2019-07-17T15:39:25.8533111Z 
2019-07-17T15:39:25.8534910Z   git checkout -b <new-branch-name>
2019-07-17T15:39:25.8535273Z 
2019-07-17T15:39:25.8535493Z HEAD is now at dc849d73f Merge 0a227f33a80f02ce0182d52ff1224ace87ad2101 into d56128d2919132aceaf74cc3c68a4554f5445fce
2019-07-17T15:39:25.8687114Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-07-17T15:39:25.8691067Z ==============================================================================
2019-07-17T15:39:25.8691139Z Task         : Bash
2019-07-17T15:39:25.8691193Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-07-17T15:41:19.2459946Z Attempting with retry: curl -y 30 -Y 10 --connect-timeout 30 -f -L -C - -o /tmp/rustci_docker_cache https://.s3.amazonaws.com/docker/a4940e6914a5e1f6360ebc241d0d850aff083be5c43d268fd716ce48f63cb24e84238becb662f27f8c5d7740413ca17da24bb9cdc003ef32d7b03d2c9052b94d
2019-07-17T15:41:19.2529820Z   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
2019-07-17T15:41:19.2530182Z                                  Dload  Upload   Total   Spent    Left  Speed
2019-07-17T15:41:19.2530332Z 
2019-07-17T15:41:19.2534777Z   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0curl: (6) Could not resolve host: .s3.amazonaws.com
2019-07-17T15:41:20.2612371Z   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
2019-07-17T15:41:20.2612731Z                                  Dload  Upload   Total   Spent    Left  Speed
2019-07-17T15:41:20.2612843Z 
2019-07-17T15:41:20.2612843Z 
2019-07-17T15:41:20.2661181Z   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0curl: (6) Could not resolve host: .s3.amazonaws.com
2019-07-17T15:41:22.2736447Z   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
2019-07-17T15:41:22.2737098Z                                  Dload  Upload   Total   Spent    Left  Speed
2019-07-17T15:41:22.2737189Z 
2019-07-17T15:41:22.2737189Z 
2019-07-17T15:41:22.2776350Z   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0curl: (6) Could not resolve host: .s3.amazonaws.com
2019-07-17T15:41:25.2876782Z   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
2019-07-17T15:41:25.2877132Z                                  Dload  Upload   Total   Spent    Left  Speed
2019-07-17T15:41:25.2877277Z 
2019-07-17T15:41:25.2877277Z 
2019-07-17T15:41:25.2878773Z   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0curl: (6) Could not resolve host: .s3.amazonaws.com
2019-07-17T15:41:29.2955962Z   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
2019-07-17T15:41:29.2956343Z                                  Dload  Upload   Total   Spent    Left  Speed
2019-07-17T15:41:29.2956498Z 
2019-07-17T15:41:29.2956498Z 
2019-07-17T15:41:29.2998632Z   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0curl: (6) Could not resolve host: .s3.amazonaws.com
2019-07-17T15:41:29.3005661Z The command has failed after 5 attempts.
2019-07-17T15:41:29.4232292Z open /tmp/rustci_docker_cache: no such file or directory
2019-07-17T15:41:29.4259325Z Attempting with retry: docker build --rm -t rust-ci -f /home/vsts/work/1/s/src/ci/docker/mingw-check/Dockerfile /home/vsts/work/1/s/src/ci/docker
2019-07-17T15:41:29.5903956Z Sending build context to Docker daemon  521.2kB
2019-07-17T15:41:29.5904615Z 
2019-07-17T15:41:29.6120688Z Step 1/6 : FROM ubuntu:16.04
---
2019-07-17T15:41:46.2888963Z Reading package lists...
2019-07-17T15:41:47.3634123Z Reading package lists...
2019-07-17T15:41:47.5484866Z Building dependency tree...
2019-07-17T15:41:47.5484966Z Reading state information...
2019-07-17T15:41:47.6652758Z The following additional packages will be installed:
2019-07-17T15:41:47.6653932Z   binutils binutils-mingw-w64-i686 binutils-mingw-w64-x86-64 bzip2 cmake-data
2019-07-17T15:41:47.6654225Z   cpp cpp-5 dpkg-dev g++-5 g++-mingw-w64 g++-mingw-w64-i686
2019-07-17T15:41:47.6654503Z   g++-mingw-w64-x86-64 gcc gcc-5 gcc-mingw-w64 gcc-mingw-w64-base
2019-07-17T15:41:47.6654805Z   gcc-mingw-w64-i686 gcc-mingw-w64-x86-64 git-man libarchive13 libasan2
2019-07-17T15:41:47.6655086Z   libasn1-8-heimdal libatomic1 libbabeltrace-ctf1 libbabeltrace1 libbz2-1.0
2019-07-17T15:41:47.6656157Z   libdpkg-perl liberror-perl libexpat1 libffi6 libgcc-5-dev libgdbm3
2019-07-17T15:41:47.6656457Z   libglib2.0-0 libgmp10 libgnutls30 libgomp1 libgssapi-krb5-2
2019-07-17T15:41:47.6656725Z   libgssapi3-heimdal libhcrypto4-heimdal libheimbase1-heimdal
2019-07-17T15:41:47.6657025Z   libheimntlm0-heimdal libhogweed4 libhx509-5-heimdal libicu55 libidn11
2019-07-17T15:41:47.6657025Z   libheimntlm0-heimdal libhogweed4 libhx509-5-heimdal libicu55 libidn11
2019-07-17T15:41:47.6657319Z   libisl15 libitm1 libjsoncpp1 libk5crypto3 libkeyutils1 libkrb5-26-heimdal
2019-07-17T15:41:47.6657605Z   libkrb5-3 libkrb5support0 libldap-2.4-2 liblsan0 liblzo2-2 libmagic1 libmpc3
2019-07-17T15:41:47.6657892Z   libmpdec2 libmpfr4 libmpx0 libnettle6 libp11-kit0 libperl5.22
2019-07-17T15:41:47.6658174Z   libpython2.7-minimal libpython2.7-stdlib libpython3.5 libpython3.5-minimal
2019-07-17T15:41:47.6658455Z   libpython3.5-stdlib libquadmath0 libroken18-heimdal librtmp1 libsasl2-2
2019-07-17T15:41:47.6658751Z   libsasl2-modules-db libsqlite3-0 libssl1.0.0 libstdc++-5-dev libtasn1-6
2019-07-17T15:41:47.6659029Z   libtsan0 libubsan0 libwind0-heimdal libxml2 linux-libc-dev mime-support
2019-07-17T15:41:47.6659324Z   mingw-w64-common mingw-w64-i686-dev mingw-w64-x86-64-dev openssl patch perl
2019-07-17T15:41:47.6659648Z   perl-modules-5.22 python2.7-minimal zlib1g-dev
2019-07-17T15:41:47.6659756Z Suggested packages:
2019-07-17T15:41:47.6660074Z   binutils-doc bzip2-doc codeblocks eclipse ninja-build cpp-doc gcc-5-locales
2019-07-17T15:41:47.6660376Z   debian-keyring g++-multilib g++-5-multilib gcc-5-doc libstdc++6-5-dbg
2019-07-17T15:41:47.6660650Z   gcc-multilib manpages-dev autoconf automake libtool flex bison gcc-doc
2019-07-17T15:41:47.6661206Z   libasan2-dbg liblsan0-dbg libtsan0-dbg libubsan0-dbg libcilkrts5-dbg
2019-07-17T15:41:47.6661475Z   libmpx0-dbg libquadmath0-dbg gdb-doc gettext-base git-daemon-run
2019-07-17T15:41:47.6661475Z   libmpx0-dbg libquadmath0-dbg gdb-doc gettext-base git-daemon-run
2019-07-17T15:41:47.6661751Z   | git-daemon-sysvinit git-doc git-el git-email git-gui gitk gitweb git-arch
2019-07-17T15:41:47.6662046Z   git-cvs git-mediawiki git-svn lrzip glibc-doc gnutls-bin krb5-doc krb5-user
2019-07-17T15:41:47.6662323Z   libstdc++-5-doc make-doc wine wine64 ed diffutils-doc perl-doc
2019-07-17T15:41:47.6662596Z   libterm-readline-gnu-perl | libterm-readline-perl-perl python2.7-doc
2019-07-17T15:41:47.6662827Z   binfmt-support
2019-07-17T15:41:47.6662879Z Recommended packages:
2019-07-17T15:41:47.6663157Z   build-essential fakeroot libalgorithm-merge-perl gfortran-mingw-w64
2019-07-17T15:41:47.6663440Z   gnat-mingw-w64 libc-dbg gdbserver less rsync ssh-client manpages
2019-07-17T15:41:47.6663712Z   manpages-dev libfile-fcntllock-perl libglib2.0-data shared-mime-info
2019-07-17T15:41:47.6663986Z   xdg-user-dirs krb5-locales libsasl2-modules libssl-doc xml-core netbase
2019-07-17T15:41:47.6664055Z   rename
2019-07-17T15:41:47.6664107Z The following NEW packages will be installed:
2019-07-17T15:41:47.6664381Z   binutils binutils-mingw-w64-i686 binutils-mingw-w64-x86-64 bzip2
2019-07-17T15:41:47.6664654Z   ca-certificates cmake cmake-data cpp cpp-5 curl dpkg-dev file g++ g++-5
2019-07-17T15:41:47.6665106Z   g++-mingw-w64 g++-mingw-w64-i686 g++-mingw-w64-x86-64 gcc gcc-5
2019-07-17T15:41:47.6665449Z   gcc-mingw-w64 gcc-mingw-w64-base gcc-mingw-w64-i686 gcc-mingw-w64-x86-64 gdb
2019-07-17T15:41:47.6666073Z   git git-man libarchive13 libasan2 libasn1-8-heimdal libatomic1
2019-07-17T15:41:47.6666589Z   libbabeltrace-ctf1 libbabeltrace1 libc-dev-bin libc6-dev libcc1-0
2019-07-17T15:41:47.6667214Z   libffi6 libgcc-5-dev libgdbm3 libglib2.0-0 libgmp10 libgnutls30 libgomp1
2019-07-17T15:41:47.6667555Z   libgssapi-krb5-2 libgssapi3-heimdal libhcrypto4-heimdal libheimbase1-heimdal
2019-07-17T15:41:47.6667860Z   libheimntlm0-heimdal libhogweed4 libhx509-5-heimdal libicu55 libidn11
2019-07-17T15:41:47.6668165Z   libisl15 libitm1 libjsoncpp1 libk5crypto3 libkeyutils1 libkrb5-26-heimdal
2019-07-17T15:41:47.6668165Z   libisl15 libitm1 libjsoncpp1 libk5crypto3 libkeyutils1 libkrb5-26-heimdal
2019-07-17T15:41:47.6668493Z   libkrb5-3 libkrb5support0 libldap-2.4-2 liblsan0 liblzo2-2 libmagic1 libmpc3
2019-07-17T15:41:47.6668798Z   libmpdec2 libmpfr4 libmpx0 libnettle6 libp11-kit0 libperl5.22
2019-07-17T15:41:47.6669174Z   libpython2.7-minimal libpython2.7-stdlib libpython3.5 libpython3.5-minimal
2019-07-17T15:41:47.6669915Z   libpython3.5-stdlib libquadmath0 libroken18-heimdal librtmp1 libsasl2-2
2019-07-17T15:41:47.6670244Z   libsasl2-modules-db libsqlite3-0 libssl-dev libssl1.0.0 libstdc++-5-dev
2019-07-17T15:41:47.6670546Z   libtasn1-6 libtsan0 libubsan0 libwind0-heimdal libxml2 linux-libc-dev make
2019-07-17T15:41:47.6670862Z   mime-support mingw-w64 mingw-w64-common mingw-w64-i686-dev
2019-07-17T15:41:47.6671156Z   mingw-w64-x86-64-dev openssl patch perl perl-modules-5.22 pkg-config
2019-07-17T15:41:47.6671441Z   python2.7 python2.7-minimal sudo xz-utils zlib1g-dev
2019-07-17T15:41:47.6671522Z The following packages will be upgraded:
2019-07-17T15:41:48.1272931Z 1 upgraded, 112 newly installed, 0 to remove and 5 not upgraded.
2019-07-17T15:41:48.1273104Z Need to get 187 MB of archives.
2019-07-17T15:41:48.1273197Z After this operation, 968 MB of additional disk space will be used.
2019-07-17T15:41:48.1273996Z Get:1 http://archive.ubuntu.com/ubuntu xenial/main amd64 libgdbm3 amd64 1.8.3-13.1 [16.9 kB]
---
2019-07-17T15:41:52.4654099Z Get:97 http://archive.ubuntu.com/ubuntu xenial-updates/main amd64 zlib1g-dev amd64 1:1.2.8.dfsg-2ubuntu4.1 [168 kB]
2019-07-17T15:41:52.4704158Z Get:98 http://archive.ubuntu.com/ubuntu xenial-updates/main amd64 libssl-dev amd64 1.0.2g-1ubuntu4.15 [1344 kB]
2019-07-17T15:41:52.4938089Z Get:99 http://archive.ubuntu.com/ubuntu xenial/main amd64 pkg-config amd64 0.29.1-0ubuntu1 [45.0 kB]
2019-07-17T15:41:52.4938736Z Get:100 http://archive.ubuntu.com/ubuntu xenial-updates/main amd64 python2.7 amd64 2.7.12-1ubuntu0~16.04.4 [224 kB]
2019-07-17T15:41:52.4982237Z Get:101 http://archive.ubuntu.com/ubuntu xenial/universe amd64 binutils-mingw-w64-i686 amd64 2.26-3ubuntu1+6.6 [1782 kB]
2019-07-17T15:41:52.8112246Z Get:102 http://archive.ubuntu.com/ubuntu xenial/universe amd64 binutils-mingw-w64-x86-64 amd64 2.26-3ubuntu1+6.6 [2029 kB]
2019-07-17T15:41:53.7288337Z Get:103 http://archive.ubuntu.com/ubuntu xenial/universe amd64 mingw-w64-common all 4.0.4-2 [4787 kB]
2019-07-17T15:41:53.9354267Z Get:104 http://archive.ubuntu.com/ubuntu xenial/universe amd64 mingw-w64-i686-dev all 4.0.4-2 [2059 kB]
2019-07-17T15:41:54.0117559Z Get:105 http://archive.ubuntu.com/ubuntu xenial/universe amd64 gcc-mingw-w64-base amd64 5.3.1-8ubuntu3+17 [11.2 kB]
2019-07-17T15:41:54.0123179Z Get:106 http://archive.ubuntu.com/ubuntu xenial/universe amd64 gcc-mingw-w64-i686 amd64 5.3.1-8ubuntu3+17 [27.3 MB]
2019-07-17T15:41:55.0656006Z Get:107 http://archive.ubuntu.com/ubuntu xenial/universe amd64 g++-mingw-w64-i686 amd64 5.3.1-8ubuntu3+17 [19.8 MB]
2019-07-17T15:41:55.9112309Z Get:108 http://archive.ubuntu.com/ubuntu xenial/universe amd64 mingw-w64-x86-64-dev all 4.0.4-2 [3238 kB]
2019-07-17T15:41:55.9633935Z Get:109 http://archive.ubuntu.com/ubuntu xenial/universe amd64 gcc-mingw-w64-x86-64 amd64 5.3.1-8ubuntu3+17 [27.4 MB]
2019-07-17T15:41:57.2005411Z Get:110 http://archive.ubuntu.com/ubuntu xenial/universe amd64 g++-mingw-w64-x86-64 amd64 5.3.1-8ubuntu3+17 [20.4 MB]
2019-07-17T15:41:57.9615719Z Get:111 http://archive.ubuntu.com/ubuntu xenial/universe amd64 g++-mingw-w64 all 5.3.1-8ubuntu3+17 [10.7 kB]
2019-07-17T15:41:57.9620712Z Get:112 http://archive.ubuntu.com/ubuntu xenial/universe amd64 gcc-mingw-w64 all 5.3.1-8ubuntu3+17 [10.7 kB]
2019-07-17T15:41:57.9625072Z Get:113 http://archive.ubuntu.com/ubuntu xenial/universe amd64 mingw-w64 all 4.0.4-2 [9274 B]
2019-07-17T15:42:00.2419164Z debconf: delaying package configuration, since apt-utils is not installed
2019-07-17T15:42:00.2638069Z Fetched 187 MB in 10s (18.6 MB/s)
2019-07-17T15:42:00.3316851Z (Reading database ... 
2019-07-17T15:42:00.3316979Z (Reading database ... 5%
2019-07-17T15:42:00.3317058Z (Reading database ... 10%
2019-07-17T15:42:00.3317108Z (Reading database ... 15%
---
2019-07-17T15:42:26.4195076Z Unpacking pkg-config (0.29.1-0ubuntu1) ...
2019-07-17T15:42:26.5191393Z Selecting previously unselected package python2.7.
2019-07-17T15:42:26.5213196Z Preparing to unpack .../python2.7_2.7.12-1ubuntu0~16.04.4_amd64.deb ...
2019-07-17T15:42:26.5338517Z Unpacking python2.7 (2.7.12-1ubuntu0~16.04.4) ...
2019-07-17T15:42:26.6296105Z Selecting previously unselected package binutils-mingw-w64-i686.
2019-07-17T15:42:26.6318557Z Preparing to unpack .../binutils-mingw-w64-i686_2.26-3ubuntu1+6.6_amd64.deb ...
2019-07-17T15:42:26.6444545Z Unpacking binutils-mingw-w64-i686 (2.26-3ubuntu1+6.6) ...
2019-07-17T15:42:27.2042526Z Selecting previously unselected package binutils-mingw-w64-x86-64.
2019-07-17T15:42:27.2067397Z Preparing to unpack .../binutils-mingw-w64-x86-64_2.26-3ubuntu1+6.6_amd64.deb ...
2019-07-17T15:42:27.2185668Z Unpacking binutils-mingw-w64-x86-64 (2.26-3ubuntu1+6.6) ...
2019-07-17T15:42:27.7864937Z Selecting previously unselected package mingw-w64-common.
2019-07-17T15:42:27.7886736Z Preparing to unpack .../mingw-w64-common_4.0.4-2_all.deb ...
2019-07-17T15:42:27.8007823Z Unpacking mingw-w64-common (4.0.4-2) ...
2019-07-17T15:42:29.2971661Z Selecting previously unselected package mingw-w64-i686-dev.
2019-07-17T15:42:29.2995412Z Preparing to unpack .../mingw-w64-i686-dev_4.0.4-2_all.deb ...
2019-07-17T15:42:29.3115948Z Unpacking mingw-w64-i686-dev (4.0.4-2) ...
2019-07-17T15:42:30.4425577Z Selecting previously unselected package gcc-mingw-w64-base.
2019-07-17T15:42:30.4449313Z Preparing to unpack .../gcc-mingw-w64-base_5.3.1-8ubuntu3+17_amd64.deb ...
2019-07-17T15:42:30.4569948Z Unpacking gcc-mingw-w64-base (5.3.1-8ubuntu3+17) ...
2019-07-17T15:42:30.5479390Z Selecting previously unselected package gcc-mingw-w64-i686.
2019-07-17T15:42:30.5504650Z Preparing to unpack .../gcc-mingw-w64-i686_5.3.1-8ubuntu3+17_amd64.deb ...
2019-07-17T15:42:30.5653422Z Unpacking gcc-mingw-w64-i686 (5.3.1-8ubuntu3+17) ...
2019-07-17T15:42:34.8897929Z Selecting previously unselected package g++-mingw-w64-i686.
2019-07-17T15:42:34.8924465Z Preparing to unpack .../g++-mingw-w64-i686_5.3.1-8ubuntu3+17_amd64.deb ...
2019-07-17T15:42:34.9068867Z Unpacking g++-mingw-w64-i686 (5.3.1-8ubuntu3+17) ...
2019-07-17T15:42:38.9301467Z Selecting previously unselected package mingw-w64-x86-64-dev.
2019-07-17T15:42:38.9335276Z Preparing to unpack .../mingw-w64-x86-64-dev_4.0.4-2_all.deb ...
2019-07-17T15:42:38.9454130Z Unpacking mingw-w64-x86-64-dev (4.0.4-2) ...
2019-07-17T15:42:41.0396908Z Selecting previously unselected package gcc-mingw-w64-x86-64.
2019-07-17T15:42:41.0429904Z Preparing to unpack .../gcc-mingw-w64-x86-64_5.3.1-8ubuntu3+17_amd64.deb ...
2019-07-17T15:42:41.0572832Z Unpacking gcc-mingw-w64-x86-64 (5.3.1-8ubuntu3+17) ...
2019-07-17T15:42:45.8532970Z Selecting previously unselected package g++-mingw-w64-x86-64.
2019-07-17T15:42:45.8559171Z Preparing to unpack .../g++-mingw-w64-x86-64_5.3.1-8ubuntu3+17_amd64.deb ...
2019-07-17T15:42:45.8687655Z Unpacking g++-mingw-w64-x86-64 (5.3.1-8ubuntu3+17) ...
2019-07-17T15:42:50.1551960Z Selecting previously unselected package g++-mingw-w64.
2019-07-17T15:42:50.1583321Z Preparing to unpack .../g++-mingw-w64_5.3.1-8ubuntu3+17_all.deb ...
2019-07-17T15:42:50.1739501Z Unpacking g++-mingw-w64 (5.3.1-8ubuntu3+17) ...
2019-07-17T15:42:50.2767708Z Selecting previously unselected package gcc-mingw-w64.
2019-07-17T15:42:50.2794424Z Preparing to unpack .../gcc-mingw-w64_5.3.1-8ubuntu3+17_all.deb ...
2019-07-17T15:42:50.2959849Z Unpacking gcc-mingw-w64 (5.3.1-8ubuntu3+17) ...
2019-07-17T15:42:50.3769817Z Selecting previously unselected package mingw-w64.
2019-07-17T15:42:50.3800258Z Preparing to unpack .../mingw-w64_4.0.4-2_all.deb ...
2019-07-17T15:42:50.4008980Z Unpacking mingw-w64 (4.0.4-2) ...
2019-07-17T15:42:50.6565572Z Setting up libgdbm3:amd64 (1.8.3-13.1) ...
2019-07-17T15:42:50.7243197Z Setting up libffi6:amd64 (3.2.1-4) ...
2019-07-17T15:42:50.7616033Z Setting up libglib2.0-0:amd64 (2.48.2-0ubuntu4.3) ...
2019-07-17T15:42:50.7893460Z No schema files found: doing nothing.
---
2019-07-17T15:42:56.1294750Z Setting up zlib1g-dev:amd64 (1:1.2.8.dfsg-2ubuntu4.1) ...
2019-07-17T15:42:56.1680818Z Setting up libssl-dev:amd64 (1.0.2g-1ubuntu4.15) ...
2019-07-17T15:42:56.2076133Z Setting up pkg-config (0.29.1-0ubuntu1) ...
2019-07-17T15:42:56.2899051Z Setting up python2.7 (2.7.12-1ubuntu0~16.04.4) ...
2019-07-17T15:42:57.1667616Z Setting up binutils-mingw-w64-i686 (2.26-3ubuntu1+6.6) ...
2019-07-17T15:42:57.2081316Z Setting up binutils-mingw-w64-x86-64 (2.26-3ubuntu1+6.6) ...
2019-07-17T15:42:57.2476470Z Setting up mingw-w64-common (4.0.4-2) ...
2019-07-17T15:42:57.2888508Z Setting up mingw-w64-i686-dev (4.0.4-2) ...
2019-07-17T15:42:57.3306634Z Setting up gcc-mingw-w64-base (5.3.1-8ubuntu3+17) ...
2019-07-17T15:42:57.3691830Z Setting up gcc-mingw-w64-i686 (5.3.1-8ubuntu3+17) ...
2019-07-17T15:42:57.3965554Z update-alternatives: using /usr/bin/i686-w64-mingw32-gcc-posix to provide /usr/bin/i686-w64-mingw32-gcc (i686-w64-mingw32-gcc) in auto mode
2019-07-17T15:42:57.3966266Z update-alternatives: warning: skip creation of /usr/bin/i686-w64-mingw32-gcc-5 because associated file /usr/bin/i686-w64-mingw32-gcc-5-posix (of link group i686-w64-mingw32-gcc) doesn't exist
2019-07-17T15:42:57.4055899Z update-alternatives: using /usr/bin/i686-w64-mingw32-gcc-win32 to provide /usr/bin/i686-w64-mingw32-gcc (i686-w64-mingw32-gcc) in auto mode
2019-07-17T15:42:57.4056944Z update-alternatives: warning: skip creation of /usr/bin/i686-w64-mingw32-gcc-5 because associated file /usr/bin/i686-w64-mingw32-gcc-5-win32 (of link group i686-w64-mingw32-gcc) doesn't exist
2019-07-17T15:42:57.4327203Z Setting up g++-mingw-w64-i686 (5.3.1-8ubuntu3+17) ...
2019-07-17T15:42:57.4678977Z update-alternatives: using /usr/bin/i686-w64-mingw32-g++-posix to provide /usr/bin/i686-w64-mingw32-g++ (i686-w64-mingw32-g++) in auto mode
2019-07-17T15:42:57.4797184Z update-alternatives: using /usr/bin/i686-w64-mingw32-g++-win32 to provide /usr/bin/i686-w64-mingw32-g++ (i686-w64-mingw32-g++) in auto mode
2019-07-17T15:42:57.5065035Z Setting up mingw-w64-x86-64-dev (4.0.4-2) ...
2019-07-17T15:42:57.5437858Z Setting up gcc-mingw-w64-x86-64 (5.3.1-8ubuntu3+17) ...
2019-07-17T15:42:57.5713762Z update-alternatives: using /usr/bin/x86_64-w64-mingw32-gcc-posix to provide /usr/bin/x86_64-w64-mingw32-gcc (x86_64-w64-mingw32-gcc) in auto mode
2019-07-17T15:42:57.5715391Z update-alternatives: warning: skip creation of /usr/bin/x86_64-w64-mingw32-gcc-5 because associated file /usr/bin/x86_64-w64-mingw32-gcc-5-posix (of link group x86_64-w64-mingw32-gcc) doesn't exist
2019-07-17T15:42:57.5809766Z update-alternatives: using /usr/bin/x86_64-w64-mingw32-gcc-win32 to provide /usr/bin/x86_64-w64-mingw32-gcc (x86_64-w64-mingw32-gcc) in auto mode
2019-07-17T15:42:57.5813788Z update-alternatives: warning: skip creation of /usr/bin/x86_64-w64-mingw32-gcc-5 because associated file /usr/bin/x86_64-w64-mingw32-gcc-5-win32 (of link group x86_64-w64-mingw32-gcc) doesn't exist
2019-07-17T15:42:57.6082141Z Setting up g++-mingw-w64-x86-64 (5.3.1-8ubuntu3+17) ...
2019-07-17T15:42:57.6398340Z update-alternatives: using /usr/bin/x86_64-w64-mingw32-g++-posix to provide /usr/bin/x86_64-w64-mingw32-g++ (x86_64-w64-mingw32-g++) in auto mode
2019-07-17T15:42:57.6488666Z update-alternatives: using /usr/bin/x86_64-w64-mingw32-g++-win32 to provide /usr/bin/x86_64-w64-mingw32-g++ (x86_64-w64-mingw32-g++) in auto mode
2019-07-17T15:42:57.6745004Z Setting up g++-mingw-w64 (5.3.1-8ubuntu3+17) ...
2019-07-17T15:42:57.7154460Z Setting up gcc-mingw-w64 (5.3.1-8ubuntu3+17) ...
2019-07-17T15:42:57.7581748Z Setting up mingw-w64 (4.0.4-2) ...
2019-07-17T15:42:57.8545336Z Processing triggers for ca-certificates (20170717~16.04.2) ...
2019-07-17T15:42:57.8725827Z Updating certificates in /etc/ssl/certs...
2019-07-17T15:42:59.5132151Z 148 added, 0 removed; done.
2019-07-17T15:42:59.5134032Z Running hooks in /etc/ca-certificates/update.d...
---
2019-07-17T15:43:38.9535632Z Removing intermediate container 0e2e6ecd602f
2019-07-17T15:43:38.9537312Z  ---> 7566f487f965
2019-07-17T15:43:38.9586112Z Successfully built 7566f487f965
2019-07-17T15:43:39.1347280Z Successfully tagged rust-ci:latest
2019-07-17T15:43:39.2268512Z Built container sha256:7566f487f9656658e1e217e5a8423f5535b2f3c8c9d31c41a143cd3b33665bbc
2019-07-17T15:43:39.2328994Z Uploading finished image to https://.s3.amazonaws.com/docker/a4940e6914a5e1f6360ebc241d0d850aff083be5c43d268fd716ce48f63cb24e84238becb662f27f8c5d7740413ca17da24bb9cdc003ef32d7b03d2c9052b94d
2019-07-17T15:45:06.6547640Z upload failed: - to s3:///docker/a4940e6914a5e1f6360ebc241d0d850aff083be5c43d268fd716ce48f63cb24e84238becb662f27f8c5d7740413ca17da24bb9cdc003ef32d7b03d2c9052b94d Parameter validation failed:
2019-07-17T15:45:06.6548137Z Invalid bucket name "": Bucket name must match the regex "^[a-zA-Z0-9.\-_]{1,255}$"
2019-07-17T15:45:07.8089495Z [CI_JOB_NAME=mingw-check]
2019-07-17T15:45:07.8139999Z Starting sccache server...
2019-07-17T15:45:07.8762572Z configure: processing command line
2019-07-17T15:45:07.8762797Z configure: 
---
2019-07-17T15:47:28.1087828Z    Compiling autocfg v0.1.4
2019-07-17T15:47:29.9523928Z    Compiling unwind v0.0.0 (/checkout/src/libunwind)
2019-07-17T15:47:30.4986449Z    Compiling compiler_builtins v0.1.17
2019-07-17T15:47:33.4470440Z    Compiling cmake v0.1.38
2019-07-17T15:47:35.9966115Z error[E0723]: only int, `bool` and `char` operations are stable in const fn
2019-07-17T15:47:35.9986566Z    --> src/libcore/time.rs:516:30
2019-07-17T15:47:35.9994455Z     |
2019-07-17T15:47:36.0029934Z 516 |         (self.secs as f64) + (self.nanos as f64) / (NANOS_PER_SEC as f64)
2019-07-17T15:47:36.0030683Z     |
2019-07-17T15:47:36.0030683Z     |
2019-07-17T15:47:36.0031715Z     = note: for more information, see issue ***/issues/57563
2019-07-17T15:47:36.0032104Z     = help: add #![feature(const_fn)] to the crate attributes to enable
2019-07-17T15:47:36.0032149Z 
2019-07-17T15:47:36.0032452Z error[E0723]: only int, `bool` and `char` operations are stable in const fn
2019-07-17T15:47:36.0032777Z    --> src/libcore/time.rs:533:30
2019-07-17T15:47:36.0034207Z     |
2019-07-17T15:47:36.0034658Z 533 |         (self.secs as f32) + (self.nanos as f32) / (NANOS_PER_SEC as f32)
2019-07-17T15:47:36.0035313Z     |
2019-07-17T15:47:36.0035313Z     |
2019-07-17T15:47:36.0035731Z     = note: for more information, see issue ***/issues/57563
2019-07-17T15:47:36.0036087Z     = help: add #![feature(const_fn)] to the crate attributes to enable
2019-07-17T15:47:37.5510659Z error: aborting due to 2 previous errors
2019-07-17T15:47:37.5515838Z 
2019-07-17T15:47:37.5522164Z For more information about this error, try `rustc --explain E0723`.
2019-07-17T15:47:37.6392348Z    Compiling backtrace-sys v0.1.27
2019-07-17T15:47:37.6392348Z    Compiling backtrace-sys v0.1.27
2019-07-17T15:47:37.7075439Z error: Could not compile `core`.
2019-07-17T15:47:37.7075831Z warning: build failed, waiting for other jobs to finish...
2019-07-17T15:47:38.4632275Z error: build failed
2019-07-17T15:47:38.4662595Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "check" "--target" "x86_64-unknown-linux-gnu" "-j" "2" "--release" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "--message-format" "json"
2019-07-17T15:47:38.4672651Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap check
2019-07-17T15:47:38.4672718Z Build completed unsuccessfully in 0:02:30
2019-07-17T15:47:38.4672718Z Build completed unsuccessfully in 0:02:30
2019-07-17T15:47:40.8998682Z ##[error]Bash exited with code '1'.
2019-07-17T15:47:40.9033565Z ##[section]Starting: Checkout
2019-07-17T15:47:40.9035457Z ==============================================================================
2019-07-17T15:47:40.9035668Z Task         : Get sources
2019-07-17T15:47:40.9035740Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Centril

This comment has been minimized.

Copy link
Member

commented Jul 21, 2019

@rust-highfive rust-highfive assigned dtolnay and unassigned aidanhs Jul 21, 2019

@joelpalmer

This comment has been minimized.

Copy link

commented Jul 29, 2019

Ping from Triage. Hi, @dtolnay, pinging you to check on the status of a review for this PR.
cc: @rust-lang/libs

@alexcrichton

This comment has been minimized.

Copy link
Member

commented Jul 29, 2019

I'm personally in favor of stabilizing these functions, so I'm going to propose such.

@rfcbot fcp merge

The major new APIs here that I would proposed for stabilization are:

impl Duration {
    pub fn as_secs_f64(&self) -> f64;
    pub fn as_secs_f32(&self) -> f32;
    pub fn from_secs_f64(secs: f64) -> Duration; // panics on overflow
    pub fn from_secs_f32(secs: f32) -> Duration; // panics on overflow
}

then using those new APIs implementations are provided for:

impl Duration {
    pub fn mul_f64(self, rhs: f64) -> Duration; // panics on overflow
    pub fn mul_f32(self, rhs: f32) -> Duration; // panics on overflow
    pub fn div_f64(self, rhs: f64) -> Duration;
    pub fn div_f32(self, rhs: f32) -> Duration;
}

... and finally there are these two methods which also use as_secs_* but I would personally propose they not be stabilized at this time since they seem a bit odd and not really buying much over just doing what the implementation already does (self.as_secs_f32() / rhs.as_secs_f32())

impl Duration {
    pub fn div_duration_f64(self, rhs: Duration) -> f64;
    pub fn div_duration_f32(self, rhs: Duration) -> f32;
}
@rfcbot

This comment has been minimized.

Copy link

commented Jul 29, 2019

Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@newpavlov

This comment has been minimized.

Copy link
Contributor Author

commented Jul 29, 2019

What should I do with div_duration methods? I guess we can simply remove them.

@alexcrichton

This comment has been minimized.

Copy link
Member

commented Jul 29, 2019

If others agree that we shouldn't stabilize the methods then yeah I think it's fine to just remove them.

@jhpratt

This comment has been minimized.

Copy link

commented Jul 29, 2019

@alexcrichton Certainly there's a use case for div_duration_{f32,f64}? Right now, I'm doing self.duration.div_duration_f32(Duration::from_millis(1)) to get the number of milliseconds including the fractional bit. I suppose I could do self.duration.checked_mul(1000).as_secs_f32(), but it seems clearer to me to extract the millisecond value directly. Of course, a .as_millis_f32() method would be ideal, but regardless.

@alexcrichton

This comment has been minimized.

Copy link
Member

commented Jul 30, 2019

Note that I'm not saying that they're not useful nor that we should never stabilize. I don't think they fit into the pattern of the other stabilizations so I think it's worthwhile to consider them separately from these initial stabilizations. Sounds like we shouldn't remove them though, we'll just want to open a new tracking issue for those specific methods.

@newpavlov

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2019

I've marked div_duration methods as unstable, they will be tracked in #63139.

@jhpratt
Note, that in your case you will get the same precision by using 1000.*self.duration.as_secs_f32().

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Jul 30, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-07-30T15:01:01.1962297Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-07-30T15:01:01.2149934Z ##[command]git config gc.auto 0
2019-07-30T15:01:01.2247959Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-07-30T15:01:01.2296326Z ##[command]git config --get-all http.proxy
2019-07-30T15:01:01.2446645Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/62756/merge:refs/remotes/pull/62756/merge
---
2019-07-30T15:01:41.1992736Z do so (now or later) by using -b with the checkout command again. Example:
2019-07-30T15:01:41.1992787Z 
2019-07-30T15:01:41.1993010Z   git checkout -b <new-branch-name>
2019-07-30T15:01:41.1993039Z 
2019-07-30T15:01:41.1993085Z HEAD is now at 9d290a453 Merge 55ee8fe852d93ce7ac87a5fa36d371cf0f0b195d into f690098e6d65ad7b33dc7fdefccc387806782027
2019-07-30T15:01:41.2125696Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-07-30T15:01:41.2128413Z ==============================================================================
2019-07-30T15:01:41.2128472Z Task         : Bash
2019-07-30T15:01:41.2128518Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-07-30T16:02:24.8823743Z .................................................................................................... 1400/8819
2019-07-30T16:02:30.7100042Z .................................................................................................... 1500/8819
2019-07-30T16:02:43.1159723Z ................................................................i...............i................... 1600/8819
2019-07-30T16:02:50.7971026Z .................................................................................................... 1700/8819
2019-07-30T16:03:05.5001225Z ..................................................iiiii............................................. 1800/8819
2019-07-30T16:03:16.6290901Z .................................................................................................... 2000/8819
2019-07-30T16:03:19.2118613Z .................................................................................................... 2100/8819
2019-07-30T16:03:22.8290934Z .................................................................................................... 2200/8819
2019-07-30T16:03:29.5084353Z .................................................................................................... 2300/8819
---
2019-07-30T16:07:24.6636720Z .................................................................................................... 5300/8819
2019-07-30T16:07:31.3287288Z ..............i..................................................................................... 5400/8819
2019-07-30T16:07:36.8653001Z .................................................................................................... 5500/8819
2019-07-30T16:07:49.2329044Z .................................................................................................... 5600/8819
2019-07-30T16:08:02.8984586Z ........ii...i..ii...........i...................................................................... 5700/8819
2019-07-30T16:08:17.5247525Z .................................................................................................... 5900/8819
2019-07-30T16:08:22.4580486Z .................................................................................................... 6000/8819
2019-07-30T16:08:22.4580486Z .................................................................................................... 6000/8819
2019-07-30T16:08:36.3250829Z ........i..ii....................................................................................... 6100/8819
2019-07-30T16:08:56.1848589Z ...................................................i................................................ 6300/8819
2019-07-30T16:08:57.7489426Z .................................................................................................... 6400/8819
2019-07-30T16:09:00.2200662Z .....................i.............................................................................. 6500/8819
2019-07-30T16:09:04.8111043Z .................................................................................................... 6600/8819
---
2019-07-30T16:13:42.1500267Z  finished in 22.518
2019-07-30T16:13:42.1673599Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-30T16:13:42.3256724Z 
2019-07-30T16:13:42.3257885Z running 146 tests
2019-07-30T16:13:45.6604901Z i....iii......iii..iiii....i............................i..i................i....i.........ii.i.i..i 100/146
2019-07-30T16:13:47.5214170Z iii..............i.........iii.i......ii......
2019-07-30T16:13:47.5215747Z 
2019-07-30T16:13:47.5217663Z  finished in 5.354
2019-07-30T16:13:47.5406673Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-30T16:13:47.7050863Z 
---
2019-07-30T16:13:49.7925058Z  finished in 2.251
2019-07-30T16:13:49.8122260Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-30T16:13:49.9706627Z 
2019-07-30T16:13:49.9706888Z running 9 tests
2019-07-30T16:13:49.9707699Z iiiiiiiii
2019-07-30T16:13:49.9708062Z 
2019-07-30T16:13:49.9713487Z  finished in 0.159
2019-07-30T16:13:49.9897324Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-30T16:13:50.1533447Z 
---
2019-07-30T16:14:08.3522731Z  finished in 18.362
2019-07-30T16:14:08.3705870Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-30T16:14:08.5268620Z 
2019-07-30T16:14:08.5268906Z running 122 tests
2019-07-30T16:14:32.7388630Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....i..........iiii..........i...ii...i.......ii.i 100/122
2019-07-30T16:14:37.4592657Z .i.i......iii.i.....ii
2019-07-30T16:14:37.4593916Z 
2019-07-30T16:14:37.4594146Z  finished in 29.088
2019-07-30T16:14:37.4602945Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-30T16:14:37.4603642Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-07-30T16:28:36.3688150Z 
2019-07-30T16:28:36.3692155Z    Doc-tests core
2019-07-30T16:28:40.5343369Z 
2019-07-30T16:28:40.5349721Z running 2379 tests
2019-07-30T16:28:52.8416731Z ......iiiii......................................................................................... 100/2379
2019-07-30T16:29:05.1052514Z .........................................................................ii......................... 200/2379
2019-07-30T16:29:34.3584103Z .................................................................................................... 400/2379
2019-07-30T16:29:34.3584103Z .................................................................................................... 400/2379
2019-07-30T16:29:45.6396394Z ..............................i..i.................iiii............................................. 500/2379
2019-07-30T16:30:08.7410450Z .................................................................................................... 700/2379
2019-07-30T16:30:20.3905404Z .................................................................................................... 800/2379
2019-07-30T16:30:32.0851033Z .................................................................................................... 900/2379
2019-07-30T16:30:44.0304139Z .................................................................................................... 1000/2379
---
2019-07-30T16:33:28.1231536Z ........................................................................................i........... 2300/2379
2019-07-30T16:33:38.0156771Z .............................................................FF................
2019-07-30T16:33:38.0157388Z failures:
2019-07-30T16:33:38.0157536Z 
2019-07-30T16:33:38.0158411Z ---- time.rs - time::Duration::div_duration_f32 (line 707) stdout ----
2019-07-30T16:33:38.0158875Z error[E0658]: use of unstable library feature 'div_duration'
2019-07-30T16:33:38.0159256Z  --> time.rs:712:17
2019-07-30T16:33:38.0159492Z   |
2019-07-30T16:33:38.0159637Z 8 | assert_eq!(dur1.div_duration_f32(dur2), 0.5);
2019-07-30T16:33:38.0159932Z   |
2019-07-30T16:33:38.0159932Z   |
2019-07-30T16:33:38.0160463Z   = note: for more information, see ***/issues/63139
2019-07-30T16:33:38.0160685Z   = help: add `#![feature(div_duration)]` to the crate attributes to enable
2019-07-30T16:33:38.0160968Z error: aborting due to previous error
2019-07-30T16:33:38.0161089Z 
2019-07-30T16:33:38.0161504Z For more information about this error, try `rustc --explain E0658`.
2019-07-30T16:33:38.0161876Z Couldn't compile the test.
2019-07-30T16:33:38.0161876Z Couldn't compile the test.
2019-07-30T16:33:38.0162283Z ---- time.rs - time::Duration::div_duration_f64 (line 691) stdout ----
2019-07-30T16:33:38.0163300Z error[E0658]: use of unstable library feature 'div_duration'
2019-07-30T16:33:38.0163737Z  --> time.rs:696:17
2019-07-30T16:33:38.0163911Z   |
2019-07-30T16:33:38.0164078Z 8 | assert_eq!(dur1.div_duration_f64(dur2), 0.5);
2019-07-30T16:33:38.0164382Z   |
2019-07-30T16:33:38.0164382Z   |
2019-07-30T16:33:38.0164828Z   = note: for more information, see ***/issues/63139
2019-07-30T16:33:38.0165030Z   = help: add `#![feature(div_duration)]` to the crate attributes to enable
2019-07-30T16:33:38.0165310Z error: aborting due to previous error
2019-07-30T16:33:38.0165425Z 
2019-07-30T16:33:38.0165835Z For more information about this error, try `rustc --explain E0658`.
2019-07-30T16:33:38.0166212Z Couldn't compile the test.
---
2019-07-30T16:33:38.0167720Z 
2019-07-30T16:33:38.0412483Z error: test failed, to rerun pass '--doc'
2019-07-30T16:33:38.0419075Z 
2019-07-30T16:33:38.0419276Z 
2019-07-30T16:33:38.0419988Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-j" "2" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-p" "core" "--" "--quiet"
2019-07-30T16:33:38.0420397Z 
2019-07-30T16:33:38.0420449Z 
2019-07-30T16:33:38.0431406Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-07-30T16:33:38.0432193Z Build completed unsuccessfully in 1:25:11
2019-07-30T16:33:38.0432193Z Build completed unsuccessfully in 1:25:11
2019-07-30T16:33:38.5737306Z ##[error]Bash exited with code '1'.
2019-07-30T16:33:38.5775238Z ##[section]Starting: Checkout
2019-07-30T16:33:38.5777122Z ==============================================================================
2019-07-30T16:33:38.5777330Z Task         : Get sources
2019-07-30T16:33:38.5777399Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rfcbot

This comment has been minimized.

Copy link

commented Jul 30, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

@faern

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

How come the mul_fXX and div_fXX methods are not just Mul/Div implementations?:

impl Div<f32> for Duration {...}
impl Div<f64> for Duration {...}
impl Mul<f32> for Duration {...}
impl Mul<f64> for Duration {...}

There might be an obvious answer that I missed. But I can't see anyone discussing/proposing this in the PRs leading up to this stabilization.

@newpavlov

This comment has been minimized.

Copy link
Contributor Author

commented Aug 6, 2019

@faern
See this message. I think adding those impls can be done in a separate PR, although I am not sure if the libs team will support such addition.

@faern

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

Thanks @newpavlov,

I interpret that message as the libs team wanting the Div/Mul impls after/when there is a way to convert a Duration to a float. Which this PR stabilizes. So I don't see why we would bloat std with duplicate ways to do the same thing if the libs team agree we could add the proper trait impls now when we have the to-float-functionality?

EDIT: I see in a later comment that at least Alex argued that the Duration * {Float} operation should stand out as it involves possible loss of precision. I would argue that anyone doing anything with floats should be aware there might be rounding/precision problems.

@rfcbot

This comment has been minimized.

Copy link

commented Aug 9, 2019

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

@alexcrichton

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

@bors: r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2019

📌 Commit 4281e61 has been approved by alexcrichton

Centril added a commit to Centril/rust that referenced this pull request Aug 9, 2019

@Centril Centril removed the needs-fcp label Aug 9, 2019

@Centril Centril referenced this pull request Aug 9, 2019

Closed

Rollup of 8 pull requests #63424

bors added a commit that referenced this pull request Aug 9, 2019

Auto merge of #63424 - Centril:rollup-2k5gn6b, r=Centril
Rollup of 8 pull requests

Successful merges:

 - #62756 (Stabilize duration_float)
 - #62860 (Stabilize checked_duration_since for 1.38.0)
 - #63337 (Tweak mismatched types error)
 - #63350 (Use associated_type_bounds where applicable - closes #61738)
 - #63352 (Sort the fat LTO modules to produce deterministic output.)
 - #63394 (Add test for issue 36804)
 - #63399 (More explicit diagnostic when using a `vec![]` in a pattern)
 - #63419 (check against more collisions for TypeId of fn pointer)

Failed merges:

r? @ghost
@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 10, 2019

⌛️ Testing commit 4281e61 with merge be8bbb0...

bors added a commit that referenced this pull request Aug 10, 2019

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 10, 2019

☀️ Test successful - checks-azure
Approved by: alexcrichton
Pushing be8bbb0 to master...

@bors bors added the merged-by-bors label Aug 10, 2019

@bors bors merged commit 4281e61 into rust-lang:master Aug 10, 2019

5 checks passed

homu Test successful
Details
pr Build #20190730.47 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Aug 10, 2019

📣 Toolstate changed by #62756!

Tested on commit be8bbb0.
Direct link to PR: #62756

🎉 rustc-guide on linux: test-fail → test-pass (cc @mark-i-m @spastorino, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Aug 10, 2019

📣 Toolstate changed by rust-lang/rust#62756!
Tested on commit rust-lang/rust@be8bbb0.
Direct link to PR: <rust-lang/rust#62756>

🎉 rustc-guide on linux: test-fail → test-pass (cc @mark-i-m @spastorino, @rust-lang/infra).

@newpavlov newpavlov deleted the newpavlov:stabilize_dur_float branch Aug 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.