Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #64919. Suggest fix based on operator precendence. #64933

Merged
merged 2 commits into from Oct 2, 2019

Conversation

@sam09
Copy link
Contributor

commented Sep 30, 2019

Fixes #64919

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Sep 30, 2019

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@sam09

This comment has been minimized.

Copy link
Contributor Author

commented Sep 30, 2019

r? @varkor

@rust-highfive rust-highfive assigned varkor and unassigned cramertj Sep 30, 2019
@sam09 sam09 force-pushed the sam09:master branch from 85230dc to cb25435 Sep 30, 2019
@sam09 sam09 force-pushed the sam09:master branch from cb25435 to c9baaa7 Sep 30, 2019
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

commented Sep 30, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-09-30T23:11:49.3295548Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-30T23:11:49.3468197Z ##[command]git config gc.auto 0
2019-09-30T23:11:49.3549657Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-30T23:11:49.3605905Z ##[command]git config --get-all http.proxy
2019-09-30T23:11:49.3747692Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/64933/merge:refs/remotes/pull/64933/merge
---
2019-09-30T23:19:10.7286040Z    Compiling serde_json v1.0.40
2019-09-30T23:19:12.5286269Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-09-30T23:19:23.9643600Z     Finished release [optimized] target(s) in 1m 31s
2019-09-30T23:19:23.9724490Z tidy check
2019-09-30T23:19:24.8434594Z tidy error: /checkout/src/librustc_typeck/check/mod.rs:4348: line longer than 100 chars
2019-09-30T23:19:24.8434792Z tidy error: /checkout/src/librustc_typeck/check/mod.rs:4349: line longer than 100 chars
2019-09-30T23:19:26.0789513Z some tidy checks failed
2019-09-30T23:19:26.0790510Z 
2019-09-30T23:19:26.0790510Z 
2019-09-30T23:19:26.0791693Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-09-30T23:19:26.0797371Z 
2019-09-30T23:19:26.0797427Z 
2019-09-30T23:19:26.0808541Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-09-30T23:19:26.0808866Z Build completed unsuccessfully in 0:01:34
2019-09-30T23:19:26.0808866Z Build completed unsuccessfully in 0:01:34
2019-09-30T23:19:26.0865271Z == clock drift check ==
2019-09-30T23:19:26.0880568Z   local time: Mon Sep 30 23:19:26 UTC 2019
2019-09-30T23:19:26.1726195Z   network time: Mon, 30 Sep 2019 23:19:26 GMT
2019-09-30T23:19:26.1729297Z == end clock drift check ==
2019-09-30T23:19:28.0404474Z ##[error]Bash exited with code '1'.
2019-09-30T23:19:28.0440935Z ##[section]Starting: Checkout
2019-09-30T23:19:28.0443110Z ==============================================================================
2019-09-30T23:19:28.0443182Z Task         : Get sources
2019-09-30T23:19:28.0443382Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@estebank

This comment has been minimized.

Copy link
Contributor

commented Oct 1, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Oct 1, 2019

📌 Commit 9e4eb46 has been approved by estebank

tmandry added a commit to tmandry/rust that referenced this pull request Oct 1, 2019
Fixes rust-lang#64919. Suggest fix based on operator precendence.

Fixes rust-lang#64919
@tmandry tmandry referenced this pull request Oct 1, 2019
tmandry added a commit to tmandry/rust that referenced this pull request Oct 1, 2019
Fixes rust-lang#64919. Suggest fix based on operator precendence.

Fixes rust-lang#64919
@tmandry tmandry referenced this pull request Oct 1, 2019
bors added a commit that referenced this pull request Oct 1, 2019
Rollup of 8 pull requests

Successful merges:

 - #63416 (apfloat: improve doc comments)
 - #64722 (Make all alt builders produce parallel-enabled compilers)
 - #64820 (BTreeSet intersection, is_subset & difference optimizations)
 - #64840 (SelfProfiler API refactoring and part one of event review)
 - #64910 (syntax: cleanup param, method, and misc parsing)
 - #64912 (Remove unneeded `fn main` blocks from docs)
 - #64933 (Fixes #64919. Suggest fix based on operator precendence.)
 - #64952 (Update cargo.)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Oct 1, 2019
Fixes rust-lang#64919. Suggest fix based on operator precendence.

Fixes rust-lang#64919
@Centril Centril referenced this pull request Oct 1, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 1, 2019
Fixes rust-lang#64919. Suggest fix based on operator precendence.

Fixes rust-lang#64919
@Centril Centril referenced this pull request Oct 1, 2019
bors added a commit that referenced this pull request Oct 1, 2019
Rollup of 7 pull requests

Successful merges:

 - #63416 (apfloat: improve doc comments)
 - #64820 (BTreeSet intersection, is_subset & difference optimizations)
 - #64910 (syntax: cleanup param, method, and misc parsing)
 - #64912 (Remove unneeded `fn main` blocks from docs)
 - #64933 (Fixes #64919. Suggest fix based on operator precendence.)
 - #64943 (Add lower bound doctests for `saturating_{add,sub}` signed ints)
 - #64950 (Simplify interners)

Failed merges:

r? @ghost
@bors bors merged commit 9e4eb46 into rust-lang:master Oct 2, 2019
4 checks passed
4 checks passed
pr Build #20191001.21 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.