Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unreachable unit tuple compare binop codegen #65605

Merged
merged 1 commit into from Oct 20, 2019

Conversation

@bjorn3
Copy link
Contributor

bjorn3 commented Oct 19, 2019

Closes #63906
Fixes #63551

This is based on #63906 by @luigishat, who had trouble with rebasing his PR.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Oct 19, 2019

r? @davidtwco

(rust_highfive has picked a reviewer for you, use r? to override)

@Centril

This comment has been minimized.

Copy link
Member

Centril commented Oct 20, 2019

cc @eddyb

@eddyb

This comment has been minimized.

Copy link
Member

eddyb commented Oct 20, 2019

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Oct 20, 2019

📌 Commit 2e36c84 has been approved by eddyb

JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 20, 2019
Remove unreachable unit tuple compare binop codegen

Closes rust-lang#63906
Fixes rust-lang#63551

This is based on rust-lang#63906 by @luigishat, who had trouble with rebasing his PR.
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 20, 2019
Remove unreachable unit tuple compare binop codegen

Closes rust-lang#63906
Fixes rust-lang#63551

This is based on rust-lang#63906 by @luigishat, who had trouble with rebasing his PR.
bors added a commit that referenced this pull request Oct 20, 2019
Rollup of 5 pull requests

Successful merges:

 - #65460 (Clean up `contains()` `insert()` chains on HashSet)
 - #65463 (Avoid unnecessary arena allocations in `expand_pattern()`.)
 - #65579 (Changed `resolve_type_vars_with_obligations` to also resolve const inference variables)
 - #65605 (Remove unreachable unit tuple compare binop codegen)
 - #65626 (trivial typo fix)

Failed merges:

r? @ghost
@bors bors merged commit 2e36c84 into rust-lang:master Oct 20, 2019
4 checks passed
4 checks passed
pr Build #20191019.64 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details
@bjorn3 bjorn3 deleted the bjorn3:fix_63906 branch Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.