Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add long error explanation for E0623 #66186

Merged
merged 5 commits into from
Nov 13, 2019
Merged

Add long error explanation for E0623 #66186

merged 5 commits into from
Nov 13, 2019

Conversation

GuillaumeGomez
Copy link
Member

Part of #61137.

r? @Dylan-DPC

@rust-highfive
Copy link
Collaborator

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 7, 2019
@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 7, 2019
Closed
100 tasks
@Dylan-DPC-zz
Copy link

looks good to me. Let's get another 👀 from @kinnison

kinnison
kinnison reviewed Nov 7, 2019
View reviewed changes
src/librustc/error_codes.rs Outdated
```

In this example, we tried to set a value with an incompatible lifetime to
another one (`'long` != `'short`). We can solve this issue in two different
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be tempted to say "is unrelated to" rather than just !=:

Suggested change
another one (`'long` != `'short`). We can solve this issue in two different
another one (`'long` is unrelated to `'short`). We can solve this issue in two different

src/librustc/error_codes.rs Outdated Show resolved Hide resolved
src/librustc/error_codes.rs Outdated Show resolved Hide resolved
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2019-11-13T00:50:50.7234935Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-11-13T00:50:50.7417405Z ##[command]git config gc.auto 0
2019-11-13T00:50:50.7495928Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-11-13T00:50:50.7552631Z ##[command]git config --get-all http.proxy
2019-11-13T00:50:51.4432363Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66186/merge:refs/remotes/pull/66186/merge
---
2019-11-13T00:57:00.4265400Z    Compiling serde_json v1.0.40
2019-11-13T00:57:02.3126582Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-11-13T00:57:13.9734603Z     Finished release [optimized] target(s) in 1m 31s
2019-11-13T00:57:13.9806620Z tidy check
2019-11-13T00:57:14.7871379Z tidy error: /checkout/src/librustc/error_codes.rs:1915: line longer than 80 chars
2019-11-13T00:57:16.7315449Z Found 485 error codes
2019-11-13T00:57:16.7322391Z Found 0 error codes with no tests
2019-11-13T00:57:16.7327540Z Done!
2019-11-13T00:57:16.7327597Z some tidy checks failed
2019-11-13T00:57:16.7327597Z some tidy checks failed
2019-11-13T00:57:16.7327629Z 
2019-11-13T00:57:16.7327656Z 
2019-11-13T00:57:16.7328922Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-11-13T00:57:16.7329080Z 
2019-11-13T00:57:16.7329121Z 
2019-11-13T00:57:16.7329172Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-11-13T00:57:16.7329224Z Build completed unsuccessfully in 0:01:35
2019-11-13T00:57:16.7329224Z Build completed unsuccessfully in 0:01:35
2019-11-13T00:57:16.7351711Z == clock drift check ==
2019-11-13T00:57:16.7363542Z   local time: Wed Nov 13 00:57:16 UTC 2019
2019-11-13T00:57:16.8843253Z   network time: Wed, 13 Nov 2019 00:57:16 GMT
2019-11-13T00:57:16.8845383Z == end clock drift check ==
2019-11-13T00:57:18.2286300Z 
2019-11-13T00:57:18.2389131Z ##[error]Bash exited with code '1'.
2019-11-13T00:57:18.2417113Z ##[section]Starting: Checkout
2019-11-13T00:57:18.2419201Z ==============================================================================
2019-11-13T00:57:18.2419258Z Task         : Get sources
2019-11-13T00:57:18.2419321Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Dylan-DPC-zz
Copy link

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Nov 13, 2019

📌 Commit fd868d4 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 13, 2019
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 13, 2019
@JohnTitor
Rollup merge of rust-lang#66186 - GuillaumeGomez:long-err-explanation…
0395fc7 
…-E0623, r=Dylan-DPC

Add long error explanation for E0623

Part of rust-lang#61137.

r? @Dylan-DPC
@JohnTitor JohnTitor mentioned this pull request Nov 13, 2019
Closed
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 13, 2019
@JohnTitor
Rollup merge of rust-lang#66186 - GuillaumeGomez:long-err-explanation…
be3fcf4 
…-E0623, r=Dylan-DPC

Add long error explanation for E0623

Part of rust-lang#61137.

r? @Dylan-DPC
@JohnTitor JohnTitor mentioned this pull request Nov 13, 2019
Merged
bors added a commit that referenced this pull request Nov 13, 2019
@bors
Auto merge of #66366 - JohnTitor:rollup-xlc1bj2, r=JohnTitor
695fe96 
Rollup of 14 pull requests

Successful merges:

 - #65932 (download .tar.xz if python3 is used)
 - #66094 (Fix documentation for `Iterator::count()`.)
 - #66166 (rename cfg(rustdoc) into cfg(doc))
 - #66186 (Add long error explanation for E0623)
 - #66227 (docs: Fix link to BufWriter::flush)
 - #66248 (add raw ptr variant of UnsafeCell::get)
 - #66292 (add Result::map_or)
 - #66297 (Add a callback that allows compiler consumers to override queries.)
 - #66317 (Use a relative bindir for rustdoc to find rustc)
 - #66330 (Improve non-exhaustiveness handling in usefulness checking)
 - #66331 (Add some tests for fixed ICEs)
 - #66334 (Move Session fields to CrateStore)
 - #66335 (Move self-profile infrastructure to data structures)
 - #66337 (Remove dead code for encoding/decoding lint IDs)

Failed merges:

r? @ghost
@bors bors merged commit fd868d4 into rust-lang:master Nov 13, 2019
@bors
Copy link
Contributor

bors commented Nov 13, 2019

☔ The latest upstream changes (presumably #66366) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinnison kinnison kinnison left review comments

Assignees

@Dylan-DPC-zz Dylan-DPC-zz

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@GuillaumeGomez @rust-highfive @Dylan-DPC-zz @bors @kinnison @Dylan-DPC