Remove NodeState::{Waiting,Done}
#66405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
Ping from triage |
nikomatsakis
approved these changes
Dec 2, 2019
|
@bors r+ rollup |
|
📌 Commit c45fc6b has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 3, 2019
…tates, r=nikomatsakis Tweak `ObligationForest` `NodeState`s These two commits improve comments and function names. r? @nikomatsakis
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Dec 5, 2019
…tates, r=nikomatsakis Tweak `ObligationForest` `NodeState`s These two commits improve comments and function names. r? @nikomatsakis
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Dec 5, 2019
…tates, r=nikomatsakis Tweak `ObligationForest` `NodeState`s These two commits improve comments and function names. r? @nikomatsakis
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Dec 5, 2019
…tates, r=nikomatsakis Tweak `ObligationForest` `NodeState`s These two commits improve comments and function names. r? @nikomatsakis
bors
added a commit
that referenced
this pull request
Dec 5, 2019
Rollup of 13 pull requests Successful merges: - #66405 (Tweak `ObligationForest` `NodeState`s) - #66730 (remove dependency from libhermit) - #66764 (Tweak wording of `collect()` on bad target type) - #66899 (Standard library support for riscv64gc-unknown-linux-gnu) - #66900 (Clean up error codes) - #66974 ([CI] fix the `! isCI` check in src/ci/run.sh) - #66979 (Add long error for E0631 and update ui tests.) - #67005 (capitalize Rust) - #67010 (Accurately portray raw identifiers in error messages) - #67011 (Include a span in more `expected...found` notes) - #67017 (cleanup long error explanations) - #67021 (Fix docs for formatting delegations) - #67041 (add ExitStatusExt into prelude) Failed merges: r? @ghost
|
Actually, I'm going to do some more changes here. @bors r- |
bors
added
S-waiting-on-author
nnethercote
force-pushed
the
tweak-ObligForest-NodeStates
branch
from
c45fc6b
to
3a5b4ed
Compare
|
The new commits subsume the old ones. |
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion |
|
⌛ Trying commit 3a5b4ed49bdb8848175b78b2dccdfe35a6611ac3 with merge 0e8c24186c2c99d5fc9847db42856c85a642ad3f... |
|
☀️ Try build successful - checks-azure |
|
Queued 88ae36bd20175c16667f51a71fbedcae8f933c44 with parent e9469a6, future comparison URL. |
|
Finished benchmarking try commit 88ae36bd20175c16667f51a71fbedcae8f933c44, comparison URL. |
|
The new results still don't really match what I got locally, but they do show it as a small win, so I'm going to land this. @bors r=nikomatsakis |
|
📌 Commit cb21293 has been approved by |
bors
added
the
S-waiting-on-bors
|
@bors rollup=never (The rollup directive above was from an earlier version of this PR when the changes were much simpler.) |
bors
added a commit
that referenced
this pull request
Dec 13, 2019
…komatsakis
Remove `NodeState::{Waiting,Done}`
An optimization, and then some clean-ups.
r? @nikomatsakis
|
☀️ Test successful - checks-azure |
Mark-Simulacrum
pushed a commit
to nnethercote/rust
that referenced
this pull request
Dec 31, 2019
Because it caused major performance regressions in some cases. That PR had five commits, two of which affected performance, and three of which were refactorings. This change undoes the performance-affecting changes, while keeping the refactorings in place. Fixes rust-lang#67454.
bors
added a commit
that referenced
this pull request
Jan 1, 2020
Revert parts of #66405. Because PR #66405 caused major performance regressions in some cases. That PR had five commits, two of which affected performance, and three of which were refactorings. This change undoes the performance-affecting changes, while keeping the refactorings in place. Fixes #67454. r? @nikomatsakis
Marwes
added a commit
to Marwes/rust
that referenced
this pull request
Jan 3, 2020
This was lost in rust-lang#66405 , perhaps due to the added `dep_index >= min_index` check which attempts to avoid reprocessing in a different way. Unfortunately that does not cover the case where a node points to a higher index which can in degenerate cases where a lot of nodes point to a lot of higher indexed nodes end up with `O(N ^ 2)` complexity. With this fix restored it is `O(N)` again since nodes will never be reprocessed.
Mark-Simulacrum
pushed a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Jan 23, 2020
Because it caused major performance regressions in some cases. That PR had five commits, two of which affected performance, and three of which were refactorings. This change undoes the performance-affecting changes, while keeping the refactorings in place. Fixes rust-lang#67454.
Merged
bors
added a commit
that referenced
this pull request
Jan 24, 2020
[beta] backports This backports: * Do not ICE on malformed suggestion spans #68256 * Distinguish between private items and hidden items in rustdoc #67875 * Revert parts of #66405. #67471 It also includes a few formatting commits to permit the backports to proceed cleanly (those are scoped to the relevant files, but still generate noise, of course). This was deemed easier than attempting to manually deal with the formatting. r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An optimization, and then some clean-ups.
r? @nikomatsakis