Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port erased cleanup #66443

Merged
merged 12 commits into from
Nov 15, 2019
Merged

Port erased cleanup #66443

merged 12 commits into from
Nov 15, 2019

Conversation

GuillaumeGomez
Copy link
Member

Just realised that the changes I made in #65965 were removed after the move of all error codes so here it is. I made them into separate commits to make the history look better this time.

r? @Mark-Simulacrum

@rust-highfive
Copy link
Collaborator

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 15, 2019
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 15, 2019

📌 Commit f9fdc38 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 15, 2019
Centril added a commit to Centril/rust that referenced this pull request Nov 15, 2019
@Centril
Rollup merge of rust-lang#66443 - GuillaumeGomez:port-erased-cleanup,…
3294f41 
… r=Mark-Simulacrum

Port erased cleanup

Just realised that the changes I made in rust-lang#65965 were removed after the move of all error codes so here it is. I made them into separate commits to make the history look better this time.

r? @Mark-Simulacrum
@Centril Centril mentioned this pull request Nov 15, 2019
Closed
tmandry added a commit to tmandry/rust that referenced this pull request Nov 15, 2019
@tmandry
Rollup merge of rust-lang#66443 - GuillaumeGomez:port-erased-cleanup,…
0f2f03f 
… r=Mark-Simulacrum

Port erased cleanup

Just realised that the changes I made in rust-lang#65965 were removed after the move of all error codes so here it is. I made them into separate commits to make the history look better this time.

r? @Mark-Simulacrum
@tmandry tmandry mentioned this pull request Nov 15, 2019
Merged
bors added a commit that referenced this pull request Nov 15, 2019
@bors
Auto merge of #66449 - tmandry:rollup-3p1t0sb, r=tmandry
1bd30ce 
Rollup of 4 pull requests

Successful merges:

 - #66197 (Push `ast::{ItemKind, ImplItemKind}::OpaqueTy` hack down into lowering)
 - #66429 (Add a regression test for #62524)
 - #66435 (Correct `const_in_array_repeat_expressions` feature name)
 - #66443 (Port erased cleanup)

Failed merges:

r? @ghost
@bors bors merged commit f9fdc38 into rust-lang:master Nov 15, 2019
@GuillaumeGomez GuillaumeGomez deleted the port-erased-cleanup branch November 16, 2019 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GuillaumeGomez @rust-highfive @Mark-Simulacrum @bors