Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a regression test for #62524 #66429

Merged
merged 1 commit into from Nov 15, 2019
Merged

Add a regression test for #62524 #66429

merged 1 commit into from Nov 15, 2019

Conversation

guanqun
Copy link
Contributor

@guanqun guanqun commented Nov 15, 2019 •
edited

Closes #62524

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 15, 2019
@guanqun guanqun mentioned this pull request Nov 15, 2019
Closed
@JohnTitor
Copy link
Member

Could you include Closes #62524 to the PR description to close that issue?

@guanqun
Copy link
Contributor Author

guanqun commented Nov 15, 2019

sure. added.

@Centril Centril changed the title add a unit test for #62524 Add a regression test for #62524 Nov 15, 2019
@Centril
Copy link
Contributor

Centril commented Nov 15, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Nov 15, 2019

📌 Commit ed9c5da has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 15, 2019
@Centril
Copy link
Contributor

Centril commented Nov 15, 2019

r? @Centril

Centril added a commit to Centril/rust that referenced this pull request Nov 15, 2019
@Centril
Rollup merge of rust-lang#66429 - guanqun:add-unit-test, r=Centril
0c04c8e 
Add a regression test for rust-lang#62524

Closes rust-lang#62524
@Centril Centril mentioned this pull request Nov 15, 2019
Closed
tmandry added a commit to tmandry/rust that referenced this pull request Nov 15, 2019
@tmandry
Rollup merge of rust-lang#66429 - guanqun:add-unit-test, r=Centril
c6cdbe9 
Add a regression test for rust-lang#62524

Closes rust-lang#62524
@tmandry tmandry mentioned this pull request Nov 15, 2019
Merged
bors added a commit that referenced this pull request Nov 15, 2019
@bors
Auto merge of #66449 - tmandry:rollup-3p1t0sb, r=tmandry
1bd30ce 
Rollup of 4 pull requests

Successful merges:

 - #66197 (Push `ast::{ItemKind, ImplItemKind}::OpaqueTy` hack down into lowering)
 - #66429 (Add a regression test for #62524)
 - #66435 (Correct `const_in_array_repeat_expressions` feature name)
 - #66443 (Port erased cleanup)

Failed merges:

r? @ghost
@bors bors merged commit ed9c5da into rust-lang:master Nov 15, 2019
@guanqun guanqun deleted the add-unit-test branch November 15, 2019 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Centril Centril

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

compiler panic: "byte index 10 is not a char boundary"
6 participants
@guanqun @rust-highfive @JohnTitor @Centril @bors @nikomatsakis