Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable gdb pretty printer global section on wasm targets #66520

Merged
merged 1 commit into from Dec 5, 2019

Conversation

@alexcrichton
Copy link
Member

alexcrichton commented Nov 18, 2019

The wasm targets don't support gdb anyway so there's no need for this
section there.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Nov 18, 2019

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@eddyb
eddyb approved these changes Nov 18, 2019
@eddyb

This comment has been minimized.

Copy link
Member

eddyb commented Nov 18, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 18, 2019

📌 Commit eda67ba has been approved by eddyb

JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 19, 2019
Disable gdb pretty printer global section on wasm targets

The wasm targets don't support gdb anyway so there's no need for this
section there.
bors added a commit that referenced this pull request Nov 19, 2019
Rollup of 13 pull requests

Successful merges:

 - #66090 (Misc CI improvements)
 - #66239 (Suggest calling async closure when needed)
 - #66430 ([doc] Fix the source code highlighting on source comments)
 - #66431 (Fix 'type annotations needed' error with opaque types)
 - #66461 (Add explanation message for E0641)
 - #66468 (Cleanup Miri SIMD intrinsics)
 - #66478 (rustc_plugin: Remove the compatibility shim)
 - #66493 (Add JohnTitor to rustc-guide toolstate notification list)
 - #66511 (std::error::Chain: remove Copy)
 - #66512 (Add unix::process::CommandExt::arg0)
 - #66520 (Disable gdb pretty printer global section on wasm targets)
 - #66529 (resolve: Give derive helpers highest priority during resolution)
 - #66536 (Move the definition of `QueryResult` into `plumbing.rs`.)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Nov 20, 2019
Disable gdb pretty printer global section on wasm targets

The wasm targets don't support gdb anyway so there's no need for this
section there.
bors added a commit that referenced this pull request Nov 20, 2019
Rollup of 6 pull requests

Successful merges:

 - #65730 (Suggest to add lifetime constraint at explicit ouput of functions)
 - #66460 (Add a proc-macro to derive HashStable in librustc dependencies)
 - #66468 (Cleanup Miri SIMD intrinsics)
 - #66520 (Disable gdb pretty printer global section on wasm targets)
 - #66539 (Point at type in `let` assignment on type errors)
 - #66569 (GitHub Actions: preparations, part 1)

Failed merges:

 - #66524 (Support multiple revisions in `compiletest`)

r? @ghost
bors added a commit that referenced this pull request Nov 20, 2019
Rollup of 6 pull requests

Successful merges:

 - #65730 (Suggest to add lifetime constraint at explicit ouput of functions)
 - #66460 (Add a proc-macro to derive HashStable in librustc dependencies)
 - #66468 (Cleanup Miri SIMD intrinsics)
 - #66520 (Disable gdb pretty printer global section on wasm targets)
 - #66539 (Point at type in `let` assignment on type errors)
 - #66569 (GitHub Actions: preparations, part 1)

Failed merges:

 - #66524 (Support multiple revisions in `compiletest`)

r? @ghost
bors added a commit that referenced this pull request Nov 21, 2019
Rollup of 6 pull requests

Successful merges:

 - #65730 (Suggest to add lifetime constraint at explicit ouput of functions)
 - #66460 (Add a proc-macro to derive HashStable in librustc dependencies)
 - #66468 (Cleanup Miri SIMD intrinsics)
 - #66520 (Disable gdb pretty printer global section on wasm targets)
 - #66539 (Point at type in `let` assignment on type errors)
 - #66569 (GitHub Actions: preparations, part 1)

Failed merges:

 - #66524 (Support multiple revisions in `compiletest`)

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Nov 21, 2019
Disable gdb pretty printer global section on wasm targets

The wasm targets don't support gdb anyway so there's no need for this
section there.
bors added a commit that referenced this pull request Nov 21, 2019
Rollup of 6 pull requests

Successful merges:

 - #65730 (Suggest to add lifetime constraint at explicit ouput of functions)
 - #66460 (Add a proc-macro to derive HashStable in librustc dependencies)
 - #66468 (Cleanup Miri SIMD intrinsics)
 - #66515 (Reduce size of `hir::Expr` by boxing more of `hir::InlineAsm`)
 - #66520 (Disable gdb pretty printer global section on wasm targets)
 - #66539 (Point at type in `let` assignment on type errors)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Nov 21, 2019
Disable gdb pretty printer global section on wasm targets

The wasm targets don't support gdb anyway so there's no need for this
section there.
bors added a commit that referenced this pull request Nov 21, 2019
Rollup of 6 pull requests

Successful merges:

 - #65730 (Suggest to add lifetime constraint at explicit ouput of functions)
 - #66460 (Add a proc-macro to derive HashStable in librustc dependencies)
 - #66468 (Cleanup Miri SIMD intrinsics)
 - #66515 (Reduce size of `hir::Expr` by boxing more of `hir::InlineAsm`)
 - #66520 (Disable gdb pretty printer global section on wasm targets)
 - #66602 (Revert "Update Source Code Pro and include italics")

Failed merges:

r? @ghost
@Centril

This comment has been minimized.

Copy link
Member

Centril commented Nov 21, 2019

Failed in #66604 (comment), @bors r- rollup=never

@JohnCSimon

This comment has been minimized.

Copy link
Member

JohnCSimon commented Nov 29, 2019

Ping from triage:
@eddyb - this PR has been squashed passed the checks and has been approved already.
Thank you.

@eddyb

This comment has been minimized.

Copy link
Member

eddyb commented Nov 29, 2019

@JohnCSimon nothing happened since #66520 (comment).

@alexcrichton

This comment has been minimized.

Copy link
Member Author

alexcrichton commented Dec 2, 2019

Oops sorry I missed the notification here about the failed test, I will update this in the next day or so.

@alexcrichton alexcrichton force-pushed the alexcrichton:disable-gdb-wasm branch from eda67ba to b8eb6b7 Dec 2, 2019
@alexcrichton

This comment has been minimized.

Copy link
Member Author

alexcrichton commented Dec 2, 2019

@bors: r=eddyb

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 2, 2019

📌 Commit b8eb6b7 has been approved by eddyb

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 4, 2019

⌛️ Testing commit b8eb6b7 with merge 12eeebd...

bors added a commit that referenced this pull request Dec 4, 2019
Disable gdb pretty printer global section on wasm targets

The wasm targets don't support gdb anyway so there's no need for this
section there.
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Dec 4, 2019

The job wasm32 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-12-04T23:05:46.7156932Z failures:
2019-12-04T23:05:46.7157147Z 
2019-12-04T23:05:46.7157935Z ---- [codegen] codegen/gdb_debug_script_load.rs stdout ----
2019-12-04T23:05:46.7158034Z 
2019-12-04T23:05:46.7158525Z error: verification with 'FileCheck' failed
2019-12-04T23:05:46.7158624Z status: exit code: 1
2019-12-04T23:05:46.7159165Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin/FileCheck" "--input-file" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/gdb_debug_script_load/gdb_debug_script_load.ll" "/checkout/src/test/codegen/gdb_debug_script_load.rs"
2019-12-04T23:05:46.7159554Z ------------------------------------------
2019-12-04T23:05:46.7159617Z 
2019-12-04T23:05:46.7159828Z ------------------------------------------
2019-12-04T23:05:46.7159912Z stderr:
2019-12-04T23:05:46.7159912Z stderr:
2019-12-04T23:05:46.7160122Z ------------------------------------------
2019-12-04T23:05:46.7160229Z /checkout/src/test/codegen/gdb_debug_script_load.rs:11:11: error: CHECK: expected string not found in input
2019-12-04T23:05:46.7160598Z // CHECK: load volatile i8, i8* getelementptr inbounds ([[B:\[[0-9]* x i8\]]], [[B]]* @__rustc_debug_gdb_scripts_section__, i32 0, i32 0), align 1
2019-12-04T23:05:46.7160734Z           ^
2019-12-04T23:05:46.7161077Z /checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/gdb_debug_script_load/gdb_debug_script_load.ll:22:17: note: scanning from here
2019-12-04T23:05:46.7161179Z define i32 @main(i32, i8**) unnamed_addr #2 {
2019-12-04T23:05:46.7161299Z 
2019-12-04T23:05:46.7161529Z ------------------------------------------
2019-12-04T23:05:46.7161574Z 
2019-12-04T23:05:46.7161605Z 
---
2019-12-04T23:05:46.7162436Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:537:22
2019-12-04T23:05:46.7162544Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-12-04T23:05:46.7162612Z 
2019-12-04T23:05:46.7162662Z 
2019-12-04T23:05:46.7168620Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/wasm32-unknown-emscripten/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/codegen" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen" "--stage-id" "stage2-wasm32-unknown-emscripten" "--mode" "codegen" "--target" "wasm32-unknown-emscripten" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/checkout/obj/build/x86_64-unknown-linux-gnu/llvm/build/bin/FileCheck" "--nodejs" "/emsdk-portable/node/12.9.1_64bit/bin/node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/wasm32-unknown-emscripten/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--llvm-version" "9.0.0-rust-1.41.0-dev\n" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-12-04T23:05:46.7169496Z 
2019-12-04T23:05:46.7169549Z 
2019-12-04T23:05:46.7181003Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --target wasm32-unknown-emscripten --exclude src/libcore --exclude src/liballoc --exclude src/libproc_macro --exclude src/libstd --exclude src/libterm --exclude src/libtest
2019-12-04T23:05:46.7181187Z Build completed unsuccessfully in 2:09:13
2019-12-04T23:05:46.7181187Z Build completed unsuccessfully in 2:09:13
2019-12-04T23:05:46.7234796Z == clock drift check ==
2019-12-04T23:05:46.7247774Z   local time: Wed Dec  4 23:05:46 UTC 2019
2019-12-04T23:05:46.9987044Z   network time: Wed, 04 Dec 2019 23:05:46 GMT
2019-12-04T23:05:46.9990903Z == end clock drift check ==
2019-12-04T23:05:49.7024682Z 
2019-12-04T23:05:49.7117817Z ##[error]Bash exited with code '1'.
2019-12-04T23:05:49.7158425Z ##[section]Starting: Checkout rust-lang/rust@auto to s
2019-12-04T23:05:49.7160267Z ==============================================================================
2019-12-04T23:05:49.7160349Z Task         : Get sources
2019-12-04T23:05:49.7160439Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 4, 2019

💔 Test failed - checks-azure

The wasm targets don't support gdb anyway so there's no need for this
section there.
@alexcrichton alexcrichton force-pushed the alexcrichton:disable-gdb-wasm branch from b8eb6b7 to 5ce09bc Dec 5, 2019
@alexcrichton

This comment has been minimized.

Copy link
Member Author

alexcrichton commented Dec 5, 2019

@bors: r=eddyb

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 5, 2019

📌 Commit 5ce09bc has been approved by eddyb

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 5, 2019

⌛️ Testing commit 5ce09bc with merge d825e35...

bors added a commit that referenced this pull request Dec 5, 2019
Disable gdb pretty printer global section on wasm targets

The wasm targets don't support gdb anyway so there's no need for this
section there.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 5, 2019

☀️ Test successful - checks-azure
Approved by: eddyb
Pushing d825e35 to master...

@bors bors added the merged-by-bors label Dec 5, 2019
@bors bors merged commit 5ce09bc into rust-lang:master Dec 5, 2019
5 checks passed
5 checks passed
homu Test successful
Details
pr #20191205.7 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-7) Linux x86_64-gnu-llvm-7 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
@alexcrichton alexcrichton deleted the alexcrichton:disable-gdb-wasm branch Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.