Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VecDeque: drop remaining items on destructor panic #67235

Merged
merged 2 commits into from Dec 13, 2019

Conversation

@jonas-schievink
Copy link
Member

jonas-schievink commented Dec 11, 2019

Closes #67232

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Dec 11, 2019

r? @joshtriplett

(rust_highfive has picked a reviewer for you, use r? to override)

@KodrAus

This comment has been minimized.

Copy link
Contributor

KodrAus commented Dec 12, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 12, 2019

📌 Commit 82c09b7 has been approved by KodrAus

@Centril

This comment has been minimized.

Copy link
Member

Centril commented Dec 12, 2019

Centril added a commit to Centril/rust that referenced this pull request Dec 12, 2019
…drAus

VecDeque: drop remaining items on destructor panic

Closes rust-lang#67232
Centril added a commit to Centril/rust that referenced this pull request Dec 12, 2019
…KodrAus

LinkedList: drop remaining items when drop panics

rust-lang#67235, but for `LinkedList`, which has the same issue.

I've also copied over the other drop-related tests from `VecDeque` since AFAICT `LinkedList` didn't have any.
bors added a commit that referenced this pull request Dec 13, 2019
Rollup of 7 pull requests

Successful merges:

 - #67224 (Revert stabilization of never type)
 - #67235 (VecDeque: drop remaining items on destructor panic)
 - #67243 (LinkedList: drop remaining items when drop panics)
 - #67247 (Don't suggest wrong snippet in closure)
 - #67250 (Remove the `DelimSpan` from `NamedMatch::MatchedSeq`.)
 - #67251 (Require `allow_internal_unstable` for stable min_const_fn using unsta…)
 - #67255 (Remove i686-unknown-dragonfly target)

Failed merges:

r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Dec 13, 2019
…KodrAus

LinkedList: drop remaining items when drop panics

rust-lang#67235, but for `LinkedList`, which has the same issue.

I've also copied over the other drop-related tests from `VecDeque` since AFAICT `LinkedList` didn't have any.
Centril added a commit to Centril/rust that referenced this pull request Dec 13, 2019
…drAus

VecDeque: drop remaining items on destructor panic

Closes rust-lang#67232
bors added a commit that referenced this pull request Dec 13, 2019
Rollup of 7 pull requests

Successful merges:

 - #67026 (Improve diagnostics and code for exhaustiveness of empty matches)
 - #67235 (VecDeque: drop remaining items on destructor panic)
 - #67254 (dont ICE in case of invalid drop fn)
 - #67256 (Reduce allocs for validation errors)
 - #67274 (be explicit that mem::uninitialized is the same as MaybeUninit::uninit().assume_init())
 - #67278 (`coerce_inner`: use initial `expected_ty`)
 - #67280 (docs: std::convert::From: Fix typo)

Failed merges:

r? @ghost
@bors bors merged commit 82c09b7 into rust-lang:master Dec 13, 2019
4 checks passed
4 checks passed
pr #20191211.70 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-7) Linux x86_64-gnu-llvm-7 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.