VecDeque: drop remaining items on destructor panic #67235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
KodrAus
reviewed
Dec 11, 2019
|
@bors r+ |
|
📌 Commit 82c09b7 has been approved by |
bors
added
S-waiting-on-bors
|
r? @KodrAus |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 12, 2019
…drAus VecDeque: drop remaining items on destructor panic Closes rust-lang#67232
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 12, 2019
…KodrAus LinkedList: drop remaining items when drop panics rust-lang#67235, but for `LinkedList`, which has the same issue. I've also copied over the other drop-related tests from `VecDeque` since AFAICT `LinkedList` didn't have any.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 13, 2019
…KodrAus LinkedList: drop remaining items when drop panics rust-lang#67235, but for `LinkedList`, which has the same issue. I've also copied over the other drop-related tests from `VecDeque` since AFAICT `LinkedList` didn't have any.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Dec 13, 2019
…drAus VecDeque: drop remaining items on destructor panic Closes rust-lang#67232
bors
added a commit
that referenced
this pull request
Dec 13, 2019
Rollup of 7 pull requests Successful merges: - #67026 (Improve diagnostics and code for exhaustiveness of empty matches) - #67235 (VecDeque: drop remaining items on destructor panic) - #67254 (dont ICE in case of invalid drop fn) - #67256 (Reduce allocs for validation errors) - #67274 (be explicit that mem::uninitialized is the same as MaybeUninit::uninit().assume_init()) - #67278 (`coerce_inner`: use initial `expected_ty`) - #67280 (docs: std::convert::From: Fix typo) Failed merges: r? @ghost
bors
added a commit
that referenced
this pull request
Feb 26, 2020
Audit liballoc for leaks in `Drop` impls when user destructor panics Inspired by #67243 and #67235, this audits and hopefully fixes the remaining `Drop` impls in liballoc for resource leaks in the presence of panics in destructors called by the affected `Drop` impl. This does not touch `Hash{Map,Set}` since they live in hashbrown. They have similar issues though. r? @KodrAus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #67232