Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not ICE on unnamed future #67289

Merged
merged 1 commit into from Dec 15, 2019
Merged

Do not ICE on unnamed future #67289

merged 1 commit into from Dec 15, 2019

Conversation

@estebank
Copy link
Contributor

estebank commented Dec 13, 2019

Fix #67252.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Dec 13, 2019

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@estebank

This comment has been minimized.

Copy link
Contributor Author

estebank commented Dec 13, 2019

Depending on how quickly we land this it might need a beta backport after the next beta release.

@Centril

This comment has been minimized.

Copy link
Member

Centril commented Dec 14, 2019

@rust-highfive rust-highfive assigned Centril and unassigned eddyb Dec 14, 2019
@Centril Centril added the T-compiler label Dec 14, 2019
@Mark-Simulacrum

This comment has been minimized.

Copy link
Member

Mark-Simulacrum commented Dec 14, 2019

@estebank so the beta-nomination here is for "current master", i.e., we want this in 1.41, not the release next week, right? I am skipping it for beta backports at least so it probably won't get in.

@estebank estebank force-pushed the estebank:unnamed-closure branch from 3a9da04 to e08944f Dec 14, 2019
@estebank

This comment has been minimized.

Copy link
Contributor Author

estebank commented Dec 15, 2019

@bors r=Centril

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 15, 2019

📌 Commit e08944f has been approved by Centril

Centril added a commit to Centril/rust that referenced this pull request Dec 15, 2019
Do not ICE on unnamed future

Fix rust-lang#67252.
bors added a commit that referenced this pull request Dec 15, 2019
Rollup of 6 pull requests

Successful merges:

 - #67255 (Remove i686-unknown-dragonfly target)
 - #67267 (Fix signature of `__wasilibc_find_relpath`)
 - #67282 (Fix example code of OpenOptions::open)
 - #67289 (Do not ICE on unnamed future)
 - #67300 (Restore original implementation of Vec::retain)
 - #67305 (Doc typo)

Failed merges:

r? @ghost
bors added a commit that referenced this pull request Dec 15, 2019
Rollup of 6 pull requests

Successful merges:

 - #67255 (Remove i686-unknown-dragonfly target)
 - #67267 (Fix signature of `__wasilibc_find_relpath`)
 - #67282 (Fix example code of OpenOptions::open)
 - #67289 (Do not ICE on unnamed future)
 - #67300 (Restore original implementation of Vec::retain)
 - #67305 (Doc typo)

Failed merges:

r? @ghost
bors added a commit that referenced this pull request Dec 15, 2019
Rollup of 6 pull requests

Successful merges:

 - #67255 (Remove i686-unknown-dragonfly target)
 - #67267 (Fix signature of `__wasilibc_find_relpath`)
 - #67282 (Fix example code of OpenOptions::open)
 - #67289 (Do not ICE on unnamed future)
 - #67300 (Restore original implementation of Vec::retain)
 - #67305 (Doc typo)

Failed merges:

r? @ghost
bors added a commit that referenced this pull request Dec 15, 2019
Rollup of 6 pull requests

Successful merges:

 - #67255 (Remove i686-unknown-dragonfly target)
 - #67267 (Fix signature of `__wasilibc_find_relpath`)
 - #67282 (Fix example code of OpenOptions::open)
 - #67289 (Do not ICE on unnamed future)
 - #67300 (Restore original implementation of Vec::retain)
 - #67305 (Doc typo)

Failed merges:

r? @ghost
@bors bors merged commit e08944f into rust-lang:master Dec 15, 2019
4 checks passed
4 checks passed
pr #20191214.38 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-7) Linux x86_64-gnu-llvm-7 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
@pnkfelix

This comment has been minimized.

Copy link
Member

pnkfelix commented Dec 19, 2019

discussed in T-compiler meeting. beta-accepted.

@jonas-schievink

This comment has been minimized.

Copy link
Member

jonas-schievink commented Jan 13, 2020

This seems to be on the beta branch already

bors added a commit that referenced this pull request Jan 14, 2020
[Beta] Backports

I did not include #67134 and #67289 since they seem to be on beta already.

* Fix up Command Debug output when arg0 is specified. #67219
* Do not ICE on unnamed future #67289
* Don't suppress move errors for union fields #67314
* Reenable static linking of libstdc++ on windows-gnu #67410
* Use the correct type for static qualifs #67621
* Treat extern statics just like statics in the "const pointer to static" representation #67630
* Do not ICE on lifetime error involving closures #67687
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.