Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not ICE on lifetime error involving closures #67687

Merged
merged 1 commit into from Dec 30, 2019
Merged

Conversation

@estebank
Copy link
Contributor

estebank commented Dec 28, 2019

Fix #67634.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Dec 28, 2019

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@matthewjasper

This comment has been minimized.

Copy link
Contributor

matthewjasper commented Dec 29, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 29, 2019

📌 Commit 5e1b366 has been approved by matthewjasper

Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Dec 29, 2019
Do not ICE on lifetime error involving closures

Fix rust-lang#67634.
bors added a commit that referenced this pull request Dec 29, 2019
Rollup of 5 pull requests

Successful merges:

 - #64273 (Stabilize attribute macros on inline modules)
 - #67631 (Work around a resolve bug in const prop)
 - #67667 (Resolve long compile times when evaluating always valid constants)
 - #67677 (resolve: Minor cleanup of duplicate macro reexports)
 - #67687 (Do not ICE on lifetime error involving closures)

Failed merges:

 - #67682 ([const-prop] Remove useless typedef)

r? @ghost
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Dec 30, 2019
Do not ICE on lifetime error involving closures

Fix rust-lang#67634.
bors added a commit that referenced this pull request Dec 30, 2019
Rollup of 10 pull requests

Successful merges:

 - #64273 (Stabilize attribute macros on inline modules)
 - #67287 (typeck: note other end-point when checking range pats)
 - #67564 (docs: Iterator adapters have unspecified results after a panic)
 - #67622 (Some keyword documentation.)
 - #67657 (Clean up const-hack PRs now that const if / match exist.)
 - #67677 (resolve: Minor cleanup of duplicate macro reexports)
 - #67687 (Do not ICE on lifetime error involving closures)
 - #67698 (Move reachable_set and diagnostic_items to librustc_passes.)
 - #67701 (tidy: Enforce formatting rather than just check it if `--bless` is specified)
 - #67715 (Typo fix)

Failed merges:

r? @ghost
@bors bors merged commit 5e1b366 into rust-lang:master Dec 30, 2019
4 checks passed
4 checks passed
pr Build #20191228.35 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-7) Linux x86_64-gnu-llvm-7 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
@pnkfelix

This comment has been minimized.

Copy link
Member

pnkfelix commented Jan 9, 2020

Discussed at T-compiler meeting. (Two weeks in a row, even.)

beta-accepted and stable-accepted.

bors added a commit that referenced this pull request Jan 14, 2020
[Beta] Backports

I did not include #67134 and #67289 since they seem to be on beta already.

* Fix up Command Debug output when arg0 is specified. #67219
* Do not ICE on unnamed future #67289
* Don't suppress move errors for union fields #67314
* Reenable static linking of libstdc++ on windows-gnu #67410
* Use the correct type for static qualifs #67621
* Treat extern statics just like statics in the "const pointer to static" representation #67630
* Do not ICE on lifetime error involving closures #67687
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.