Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Untangle ZST validation from integer validation and generalize it to all zsts #68219

Merged
merged 2 commits into from Jan 15, 2020

Conversation

@oli-obk
Copy link
Contributor

oli-obk commented Jan 14, 2020

@wesleywiser

This comment has been minimized.

Copy link
Member

wesleywiser commented Jan 14, 2020

Copy link
Member

RalfJung left a comment

LGTM. Do we have a test making sure that a non-empty &[!] is an error?

@oli-obk

This comment has been minimized.

Copy link
Contributor Author

oli-obk commented Jan 15, 2020

Do we have a test making sure that a non-empty &[!] is an error?

We do now

Could you add some tests

Done

Copy link
Member

RalfJung left a comment

r=me

@wesleywiser

This comment has been minimized.

Copy link
Member

wesleywiser commented Jan 15, 2020

@bors r=RalfJung,wesleywiser

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jan 15, 2020

📌 Commit 0e14b9f has been approved by RalfJung,wesleywiser

JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jan 15, 2020
…wiser

Untangle ZST validation from integer validation and generalize it to all zsts

cc @RalfJung

r? @wesleywiser
bors added a commit that referenced this pull request Jan 15, 2020
Rollup of 12 pull requests

Successful merges:

 - #67784 (Reset Formatter flags on exit from pad_integral)
 - #67914 (Don't run const propagation on items with inconsistent bounds)
 - #68141 (use winapi for non-stdlib Windows bindings)
 - #68211 (Add failing example for E0170 explanation)
 - #68219 (Untangle ZST validation from integer validation and generalize it to all zsts)
 - #68222 (Update the wasi-libc bundled with libstd)
 - #68226 (Avoid calling tcx.hir().get() on CRATE_HIR_ID)
 - #68227 (Update to a version of cmake with windows arm64 support)
 - #68229 (Update iovec to a version with no winapi dependency)
 - #68230 (Update libssh2-sys to a version that can build for aarch64-pc-windows…)
 - #68231 (Better support for cross compilation on Windows.)
 - #68233 (Update compiler_builtins with changes to fix 128 bit integer remainder for aarch64 windows.)

Failed merges:

r? @ghost
@bors bors merged commit 0e14b9f into rust-lang:master Jan 15, 2020
4 checks passed
4 checks passed
pr Build #20200115.17 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-7) Linux x86_64-gnu-llvm-7 succeeded
Details
pr (Linux x86_64-gnu-tools) Linux x86_64-gnu-tools succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.