Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable setting diagnostic labels #69505

Merged
merged 1 commit into from
Feb 27, 2020
Merged

Enable setting diagnostic labels #69505

merged 1 commit into from
Feb 27, 2020

Conversation

Mark-Simulacrum
Copy link
Member

No description provided.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 27, 2020
@Mark-Simulacrum
Copy link
Member Author

cc @estebank @rust-lang/wg-diagnostics -- seems fine to permit people to set the D-* labels, right?

r? @estebank (or whoever, but no need for it to be Niko :)

@Centril
Copy link
Contributor

Centril commented Feb 27, 2020

Seems quite fine. r? @Centril @bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 27, 2020

📌 Commit 2c7c446 has been approved by Centril

@rust-highfive rust-highfive assigned Centril and unassigned estebank Feb 27, 2020
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 27, 2020
@JohnTitor JohnTitor mentioned this pull request Feb 27, 2020
Merged
bors added a commit that referenced this pull request Feb 27, 2020
@bors
Auto merge of #69507 - JohnTitor:rollup-jqf1gmw, r=JohnTitor
a8437cf 
Rollup of 7 pull requests

Successful merges:

 - #69324 (Backport only: avoid ICE on bad placeholder type)
 - #69439 (resolve: `lifetimes.rs` -> `late/lifetimes.rs`)
 - #69473 (update llvm to silence gcc 9 warnings)
 - #69479 (clarify operator precedence)
 - #69480 (Clean up E0373 explanation)
 - #69500 (Simplify the signature of par_for_each_in)
 - #69505 (Enable setting diagnostic labels)

Failed merges:

r? @ghost
@bors bors merged commit c384ace into rust-lang:master Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Centril Centril

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Mark-Simulacrum @rust-highfive @Centril @bors @nikomatsakis @estebank