don't use .into() to convert types into identical types. #69529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit 97710b4afb132c9a9c7f2818ccdb544ee59cc976 has been approved by |
bors
added
S-waiting-on-bors
eddyb
approved these changes
Feb 27, 2020
There was a problem hiding this comment.
LGTM, only had one nit (due to let-binding, which most of these don't do).
cc @alexcrichton @Mark-Simulacrum for the libstd changes
cc @oli-obk @RalfJung for the miri changes
EDIT: whoops, too late!
matthiaskrgr
force-pushed
the
clippy_identity_conversion
branch
2 times, most recently
from
6a701ed
to
3530b9a
Compare
|
reverted some changes to src/libstd/sys_common/process.rs |
example:
let s: String = format!("hello").into();
matthiaskrgr
force-pushed
the
clippy_identity_conversion
branch
from
3530b9a
to
7be94a8
Compare
|
@bors r+ rollup |
|
📌 Commit 7be94a8 has been approved by |
bors
added a commit
that referenced
this pull request
Feb 28, 2020
Rollup of 9 pull requests Successful merges: - #69379 (Fail on multiple declarations of `main`.) - #69430 (librustc_typeck: remove loop that never actually loops) - #69449 (Do not ping PR reviewers in toolstate breakage) - #69491 (rustc_span: Add `Symbol::to_ident_string` for use in diagnostic messages) - #69495 (don't take redundant references to operands) - #69496 (use find(x) instead of filter(x).next()) - #69501 (note that find(f) is equivalent to filter(f).next() in the docs.) - #69527 (Ignore untracked paths when running `rustfmt` on repository.) - #69529 (don't use .into() to convert types into identical types.) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes redundant
.into()calls.example:
let s: String = format!("hello").into();