New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and documention of debuginfo.rs #7255

Closed
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@michaelwoerister
Contributor

michaelwoerister commented Jun 20, 2013

This PR contains no real code changes. Just some documentation additions in the form of comments and some internal reordering of functions within debuginfo.rs.

@jdm

This comment has been minimized.

jdm commented on 6eb3c0f Jun 20, 2013

r+

This comment has been minimized.

huonw replied Jun 23, 2013

@bors: retry

This comment has been minimized.

brson replied Jun 26, 2013

@bors: retry

@jdm

This comment has been minimized.

Contributor

jdm commented Jun 20, 2013

I'm not sure if I'm on the bors approved list. We'll see.

@jdm

This comment has been minimized.

Contributor

jdm commented Jun 22, 2013

@graydon Any idea why bors didn't notice my r+ if I'm on the list?

@bors

This comment has been minimized.

Contributor

bors commented on 6eb3c0f Jun 23, 2013

saw approval from jdm
at michaelwoerister@6eb3c0f

This comment has been minimized.

Contributor

bors replied Jun 23, 2013

merging michaelwoerister/rust/debuginfo = 6eb3c0f into auto

This comment has been minimized.

Contributor

bors replied Jun 23, 2013

michaelwoerister/rust/debuginfo = 6eb3c0f merged ok, testing candidate = 7244225a

This comment has been minimized.

Contributor

bors replied Jun 23, 2013

This comment has been minimized.

Contributor

jdm replied Jun 23, 2013

/bin/sh: 1: /home/ubuntu/src/rust-buildbot/slave/auto-linux-32-nopt/build/obj/llvm/i686-unknown-linux-gnu/Release+Asserts/bin/llvm-mc: not found
make: *** [rt/i686-unknown-linux-gnu/stage0/arch/i386/_context.o] Error 127

Anybody know what to do about this?

This comment has been minimized.

Contributor

bors replied Jun 26, 2013

saw approval from jdm
at michaelwoerister@6eb3c0f

This comment has been minimized.

Contributor

bors replied Jun 26, 2013

merging michaelwoerister/rust/debuginfo = 6eb3c0f into auto

This comment has been minimized.

Contributor

bors replied Jun 26, 2013

michaelwoerister/rust/debuginfo = 6eb3c0f merged ok, testing candidate = a30ab76

This comment has been minimized.

Contributor

bors replied Jun 26, 2013

fast-forwarding master to auto = a30ab76

bors added a commit that referenced this pull request Jun 26, 2013

auto merge of #7255 : michaelwoerister/rust/debuginfo, r=jdm
This PR contains no real code changes. Just some documentation additions in the form of comments and some internal reordering of functions within debuginfo.rs.

@bors bors closed this Jun 26, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment