Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stdarch #73166

Merged
merged 1 commit into from
Sep 15, 2020
Merged

Update stdarch #73166

merged 1 commit into from
Sep 15, 2020

Conversation

jethrogb
Copy link
Contributor

@jethrogb jethrogb commented Jun 9, 2020

This PR changes the public signature of the following functions in core::arch::{x86, x86_64}:

-pub unsafe fn _mm256_extract_epi8(a: __m256i, imm8: i32) -> i8
+pub unsafe fn _mm256_extract_epi8(a: __m256i, imm8: i32) -> i32
-pub unsafe fn _mm256_extract_epi16(a: __m256i, imm8: i32) -> i16
+pub unsafe fn _mm256_extract_epi16(a: __m256i, imm8: i32) -> i32

This change is desired so that these signatures

  • are similar to those of the 128-bit versions _mm_extract_epi8 and _mm_extract_epi16
  • match the Intel definitions for the intrinsics
    • RFC 2325 specifies that the exact vendor function signatures should be used

A crater run revealed only a single breakage. The vektor crate copied the incorrect signatures in core exactly to their own crate. The functions don't seem to be used by anyone anywhere.

Actual breakage is not expected, since due to the nature of the functions, users would generally write _mm256_extract_epi8(...) as u8 or _mm256_extract_epi16(...) as u16.

See rust-lang/stdarch#868. Note that the changes from that stdarch PR have already partially landed in core after rust-lang/stdarch#878. This PR is now only about the remaining changes.

@rust-highfive
Copy link
Collaborator

r? @joshtriplett

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 9, 2020
@Mark-Simulacrum
Copy link
Member

@bors try for crater

@bors
Copy link
Contributor

bors commented Jun 23, 2020

⌛ Trying commit e35b044edfde3225f9149b2f943b2ee03fe18777 with merge 5fdfba63a96c5e8ae0ebf6b8b66853110277087d...

@bors
Copy link
Contributor

bors commented Jun 23, 2020

☀️ Try build successful - checks-azure
Build commit: 5fdfba63a96c5e8ae0ebf6b8b66853110277087d (5fdfba63a96c5e8ae0ebf6b8b66853110277087d)

@crlf0710 crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 10, 2020
@Dylan-DPC-zz
Copy link

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-73166 created and queued.
🤖 Automatically detected try build 5fdfba63a96c5e8ae0ebf6b8b66853110277087d
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 17, 2020
@craterbot
Copy link
Collaborator

🚧 Experiment pr-73166 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚨 Experiment pr-73166 has encountered an error: command Command { std: "/workspace/cargo-home/bin/rustup-toolchain-install-master" "1557fb031b272b4c5bfcc7de5df7eddc7b36a584" "-c" "cargo", kill_on_drop: false } failed
🛠️ If the error is fixed use the retry command.

🆘 Can someone from the infra team check in on this? @rust-lang/infra
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

alexcrichton added a commit to alexcrichton/stdarch that referenced this pull request Jul 28, 2020
This commit partially reverts rust-lang#868 to restore the intrinsics to their
original implementation to avoid breaking changes. This is done while
rust-lang/rust#73166 is running through crater, and should unblock
rust-lang/rust#74482.
@Mark-Simulacrum
Copy link
Member

@craterbot retry

@craterbot
Copy link
Collaborator

🛠️ Experiment pr-73166 queued again.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚧 Experiment pr-73166 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Amanieu pushed a commit to rust-lang/stdarch that referenced this pull request Jul 28, 2020
This commit partially reverts #868 to restore the intrinsics to their
original implementation to avoid breaking changes. This is done while
rust-lang/rust#73166 is running through crater, and should unblock
rust-lang/rust#74482.
@craterbot
Copy link
Collaborator

🚨 Experiment pr-73166 has encountered an error: command Command { std: "/workspace/cargo-home/bin/rustup-toolchain-install-master" "1557fb031b272b4c5bfcc7de5df7eddc7b36a584" "-c" "cargo", kill_on_drop: false } failed
🛠️ If the error is fixed use the retry command.

🆘 Can someone from the infra team check in on this? @rust-lang/infra
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@Mark-Simulacrum
Copy link
Member

Aha, captured a log this time! I'll be investigating a fix -- looks like disks were full -- but for now, @craterbot retry

@Mark-Simulacrum
Copy link
Member

Seems like I was ignored...

@craterbot retry

@craterbot
Copy link
Collaborator

🛠️ Experiment pr-73166 queued again.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚧 Experiment pr-73166 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-73166 is completed!
📊 6 regressed and 10 fixed (113492 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot removed the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Jul 31, 2020
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 15, 2020
@bors
Copy link
Contributor

bors commented Sep 15, 2020

⌛ Testing commit dca14c610ace41941b575f0721ae60977b8f2f81 with merge 00e6cc6db6cd8ba5dce413413e7411454664165d...

@rust-log-analyzer
Copy link
Collaborator

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
Build completed successfully in 0:01:34
+ /scripts/validate-toolstate.sh
Cloning into 'rust-toolstate'...
<Nothing changed>
HTTPError: HTTP Error 403: Forbidden
b'{"message":"API rate limit exceeded for user ID 7378925.","documentation_url":"https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting"}'
Traceback (most recent call last):
  File "../../src/tools/publish_toolstate.py", line 288, in <module>
    validate_maintainers(repo, github_token)
  File "../../src/tools/publish_toolstate.py", line 84, in validate_maintainers
    'Accept': 'application/vnd.github.hellcat-preview+json',
  File "/usr/lib/python3.6/urllib/request.py", line 223, in urlopen
    return opener.open(url, data, timeout)
  File "/usr/lib/python3.6/urllib/request.py", line 532, in open
    response = meth(req, response)
  File "/usr/lib/python3.6/urllib/request.py", line 642, in http_response
    'http', request, response, code, msg, hdrs)
  File "/usr/lib/python3.6/urllib/request.py", line 570, in error
    return self._call_chain(*args)
  File "/usr/lib/python3.6/urllib/request.py", line 504, in _call_chain
    result = func(*args)
  File "/usr/lib/python3.6/urllib/request.py", line 650, in http_error_default
    raise HTTPError(req.full_url, code, msg, hdrs, fp)
urllib.error.HTTPError: HTTP Error 403: Forbidden
  local time: Tue Sep 15 14:34:37 UTC 2020
  network time: Tue, 15 Sep 2020 14:34:37 GMT
== end clock drift check ==
== end clock drift check ==
##[error]Process completed with exit code 1.
Terminate orphan process: pid (3249) (node)
Terminate orphan process: pid (3258) (python)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

@Amanieu
Copy link
Member

Amanieu commented Sep 15, 2020

@bors retry

@bors
Copy link
Contributor

bors commented Sep 15, 2020

⌛ Testing commit dca14c610ace41941b575f0721ae60977b8f2f81 with merge 4af14f6ef2d9b60510ee7ecc62b3ee7ba28da1f4...

@jethrogb
Copy link
Contributor Author

Actually, please cancel this build. The upstream PR wasn't merged with a merge commit, so the commit hash is not valid.

@Mark-Simulacrum
Copy link
Member

@bors retry r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 15, 2020
@jethrogb
Copy link
Contributor Author

@rustbot modify labels: -S-waiting-on-author +S-waiting-on-review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 15, 2020
@rust-log-analyzer
Copy link
Collaborator

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
Initialized empty Git repository in /home/runner/work/rust/rust/.git/
##[command]git remote add origin https://github.com/rust-lang/rust
##[command]git config gc.auto 0
##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/73166/merge:refs/remotes/pull/73166/merge
---
configure: rust.channel         := nightly
configure: rust.debug-assertions := True
configure: llvm.assertions      := True
configure: dist.missing-tools   := True
configure: build.configure-args := ['--enable-sccache', '--disable-manage-submodu ...
configure: writing `config.toml` in current directory
configure: 
configure: run `python /checkout/x.py --help`
configure: 
---
   Compiling test v0.0.0 (/checkout/library/test)
    Finished release [optimized] target(s) in 1m 12s
Copying stage0 std from stage0 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
 Documenting core v0.0.0 (/checkout/library/core)
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1974:48
     |
1974 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = note: `-D broken-intra-doc-links` implied by `-D warnings`
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:1998:48
     |
1998 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2028:48
     |
2028 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2058:48
     |
2058 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2082:48
     |
2082 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2112:48
     |
2112 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2142:48
     |
2142 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2166:48
     |
2166 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2196:48
     |
2196 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2226:48
     |
2226 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2250:48
     |
2250 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2280:48
     |
2280 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2310:48
     |
2310 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2334:48
     |
2334 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2364:48
     |
2364 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2394:48
     |
2394 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2418:48
     |
2418 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2448:48
     |
2448 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2478:48
     |
2478 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2502:48
     |
2502 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2532:48
     |
2532 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2562:48
     |
2562 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2586:48
     |
2586 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2616:48
     |
2616 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2646:48
     |
2646 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2670:48
     |
2670 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2699:48
     |
2699 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2724:48
     |
2724 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2748:48
     |
2748 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2777:48
     |
2777 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2802:48
     |
2802 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2826:48
     |
2826 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2856:48
     |
2856 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2887:48
     |
2887 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2917:48
     |
2917 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2941:48
     |
2941 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:2971:48
     |
2971 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3002:48
     |
3002 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3032:48
     |
3032 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3058:48
     |
3058 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3090:48
     |
3090 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3122:48
     |
3122 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3154:48
     |
3154 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3180:48
     |
3180 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3212:48
     |
3212 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3244:48
     |
3244 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3276:48
     |
3276 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3300:48
     |
3300 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3330:48
     |
3330 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3361:48
     |
3361 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3391:48
     |
3391 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3420:48
     |
3420 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3450:48
     |
3450 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3481:48
     |
3481 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3511:48
     |
3511 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3537:48
     |
3537 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3569:48
     |
3569 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3601:48
     |
3601 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3633:48
     |
3633 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3664:48
     |
3664 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3696:48
     |
3696 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`
error: unresolved link to `3:0`
error: unresolved link to `3:0`
    --> library/core/src/../../stdarch/crates/core_arch/src/x86/avx512f.rs:3728:48
     |
3728 | /// Rounding is done according to the rounding[3:0] parameter, which can be one of:
     |                                                ^^^ unresolved link
     |
     = help: to escape `[` and `]` characters, add '\' before them like `\[` or `\]`

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

@Dylan-DPC-zz
Copy link

@jethrogb this is ready now?

@Amanieu
Copy link
Member

Amanieu commented Sep 15, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Sep 15, 2020

📌 Commit 0122e08 has been approved by Amanieu

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 15, 2020
@bors
Copy link
Contributor

bors commented Sep 15, 2020

⌛ Testing commit 0122e08 with merge 07ece44...

@bors
Copy link
Contributor

bors commented Sep 15, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: Amanieu
Pushing 07ece44 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 15, 2020
@bors bors merged commit 07ece44 into rust-lang:master Sep 15, 2020
@bors bors mentioned this pull request Sep 15, 2020
wip-sync pushed a commit to NetBSD/pkgsrc-wip that referenced this pull request Nov 24, 2020
Clean up some of the pkgsrc Makefile, there's still lots in here that
should just be deleted though.  Switch SunOS to the illumos bootstrap
by default.

Version 1.48.0 (2020-11-19)
==========================

Language
--------

- [The `unsafe` keyword is now syntactically permitted on modules.][75857] This
  is still rejected *semantically*, but can now be parsed by procedural macros.

Compiler
--------
- [Stabilised the `-C link-self-contained=<yes|no>` compiler flag.][76158] This tells
  `rustc` whether to link its own C runtime and libraries or to rely on a external
  linker to find them. (Supported only on `windows-gnu`, `linux-musl`, and `wasi` platforms.)
- [You can now use `-C target-feature=+crt-static` on `linux-gnu` targets.][77386]
  Note: If you're using cargo you must explicitly pass the `--target` flag.
- [Added tier 2\* support for `aarch64-unknown-linux-musl`.][76420]

\* Refer to Rust's [platform support page][forge-platform-support] for more
information on Rust's tiered platform support.

Libraries
---------
- [`io::Write` is now implemented for `&ChildStdin` `&Sink`, `&Stdout`,
  and `&Stderr`.][76275]
- [All arrays of any length now implement `TryFrom<Vec<T>>`.][76310]
- [The `matches!` macro now supports having a trailing comma.][74880]
- [`Vec<A>` now implements `PartialEq<[B]>` where `A: PartialEq<B>`.][74194]
- [The `RefCell::{replace, replace_with, clone}` methods now all use `#[track_caller]`.][77055]

Stabilized APIs
---------------
- [`slice::as_ptr_range`]
- [`slice::as_mut_ptr_range`]
- [`VecDeque::make_contiguous`]
- [`future::pending`]
- [`future::ready`]

The following previously stable methods are now `const fn`'s:

- [`Option::is_some`]
- [`Option::is_none`]
- [`Option::as_ref`]
- [`Result::is_ok`]
- [`Result::is_err`]
- [`Result::as_ref`]
- [`Ordering::reverse`]
- [`Ordering::then`]

Cargo
-----

Rustdoc
-------
- [You can now link to items in `rustdoc` using the intra-doc link
  syntax.][74430] E.g. ``/// Uses [`std::future`]`` will automatically generate
  a link to `std::future`'s documentation. See ["Linking to items by
  name"][intradoc-links] for more information.
- [You can now specify `#[doc(alias = "<alias>")]` on items to add search aliases
  when searching through `rustdoc`'s UI.][75740]

Compatibility Notes
-------------------
- [Promotion of references to `'static` lifetime inside `const fn` now follows the
  same rules as inside a `fn` body.][75502] In particular, `&foo()` will not be
  promoted to `'static` lifetime any more inside `const fn`s.
- [Associated type bindings on trait objects are now verified to meet the bounds
  declared on the trait when checking that they implement the trait.][27675]
- [When trait bounds on associated types or opaque types are ambiguous, the
  compiler no longer makes an arbitrary choice on which bound to use.][54121]
- [Fixed recursive nonterminals not being expanded in macros during
  pretty-print/reparse check.][77153] This may cause errors if your macro wasn't
  correctly handling recursive nonterminal tokens.
- [`&mut` references to non zero-sized types are no longer promoted.][75585]
- [`rustc` will now warn if you use attributes like `#[link_name]` or `#[cold]`
  in places where they have no effect.][73461]
- [Updated `_mm256_extract_epi8` and `_mm256_extract_epi16` signatures in
  `arch::{x86, x86_64}` to return `i32` to match the vendor signatures.][73166]
- [`mem::uninitialized` will now panic if any inner types inside a struct or enum
  disallow zero-initialization.][71274]
- [`#[target_feature]` will now error if used in a place where it has no effect.][78143]
- [Foreign exceptions are now caught by `catch_unwind` and will cause an abort.][70212]
  Note: This behaviour is not guaranteed and is still considered undefined behaviour,
  see the [`catch_unwind`] documentation for further information.

Internal Only
-------------
These changes provide no direct user facing benefits, but represent significant
improvements to the internals and overall performance of rustc and
related tools.
- [Building `rustc` from source now uses `ninja` by default over `make`.][74922]
  You can continue building with `make` by setting `ninja=false` in
  your `config.toml`.
- [cg_llvm: `fewer_names` in `uncached_llvm_type`][76030]
- [Made `ensure_sufficient_stack()` non-generic][76680]

[78143]: rust-lang/rust#78143
[76680]: rust-lang/rust#76680
[76030]: rust-lang/rust#76030
[70212]: rust-lang/rust#70212
[27675]: rust-lang/rust#27675
[54121]: rust-lang/rust#54121
[71274]: rust-lang/rust#71274
[77386]: rust-lang/rust#77386
[77153]: rust-lang/rust#77153
[77055]: rust-lang/rust#77055
[76275]: rust-lang/rust#76275
[76310]: rust-lang/rust#76310
[76420]: rust-lang/rust#76420
[76158]: rust-lang/rust#76158
[75857]: rust-lang/rust#75857
[75585]: rust-lang/rust#75585
[75740]: rust-lang/rust#75740
[75502]: rust-lang/rust#75502
[74880]: rust-lang/rust#74880
[74922]: rust-lang/rust#74922
[74430]: rust-lang/rust#74430
[74194]: rust-lang/rust#74194
[73461]: rust-lang/rust#73461
[73166]: rust-lang/rust#73166
[intradoc-links]: https://doc.rust-lang.org/rustdoc/linking-to-items-by-name.html
[`catch_unwind`]: https://doc.rust-lang.org/std/panic/fn.catch_unwind.html
[`Option::is_some`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.is_some
[`Option::is_none`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.is_none
[`Option::as_ref`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.as_ref
[`Result::is_ok`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.is_ok
[`Result::is_err`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.is_err
[`Result::as_ref`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.as_ref
[`Ordering::reverse`]: https://doc.rust-lang.org/std/cmp/enum.Ordering.html#method.reverse
[`Ordering::then`]: https://doc.rust-lang.org/std/cmp/enum.Ordering.html#method.then
[`slice::as_ptr_range`]: https://doc.rust-lang.org/std/primitive.slice.html#method.as_ptr_range
[`slice::as_mut_ptr_range`]: https://doc.rust-lang.org/std/primitive.slice.html#method.as_mut_ptr_range
[`VecDeque::make_contiguous`]: https://doc.rust-lang.org/std/collections/struct.VecDeque.html#method.make_contiguous
[`future::pending`]: https://doc.rust-lang.org/std/future/fn.pending.html
[`future::ready`]: https://doc.rust-lang.org/std/future/fn.ready.html
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Jan 1, 2021
Pkgsrc changes:
 * Compensate for files being moved around upstream.
 * Introduce optional, on-by-default semi-static building of cargo,
   using the internal curl and openssl sources.  This reduces the dynamic
   dependencies of cargo and therefore the rust package itself.
   Ref. options.mk.
 * The 1.47.0 bootstrap kits have been re-built with the above option
   turned on, so no longer depends on curl or openssl from pkgsrc and/or
   from earlier OS or pkgsrc versions.  This should hopefully fix
   installation of rust with non-default PREFIX, ref. PR#54453.


Upstream changes:

Version 1.48.0 (2020-11-19)
==========================

Language
--------
- [The `unsafe` keyword is now syntactically permitted on modules.][75857] This
  is still rejected *semantically*, but can now be parsed by procedural macros.

Compiler
--------
- [Stabilised the `-C link-self-contained=<yes|no>` compiler flag.][76158]
  This tells `rustc` whether to link its own C runtime and libraries
  or to rely on a external linker to find them. (Supported only on
  `windows-gnu`, `linux-musl`, and `wasi` platforms.)
- [You can now use `-C target-feature=+crt-static` on `linux-gnu` targets.]
  [77386]
  Note: If you're using cargo you must explicitly pass the `--target` flag.
- [Added tier 2\* support for `aarch64-unknown-linux-musl`.][76420]

\* Refer to Rust's [platform support page][forge-platform-support] for more
information on Rust's tiered platform support.

Libraries
---------
- [`io::Write` is now implemented for `&ChildStdin` `&Sink`, `&Stdout`,
  and `&Stderr`.][76275]
- [All arrays of any length now implement `TryFrom<Vec<T>>`.][76310]
- [The `matches!` macro now supports having a trailing comma.][74880]
- [`Vec<A>` now implements `PartialEq<[B]>` where `A: PartialEq<B>`.][74194]
- [The `RefCell::{replace, replace_with, clone}` methods now all use
  `#[track_caller]`.][77055]

Stabilized APIs
---------------
- [`slice::as_ptr_range`]
- [`slice::as_mut_ptr_range`]
- [`VecDeque::make_contiguous`]
- [`future::pending`]
- [`future::ready`]

The following previously stable methods are now `const fn`'s:

- [`Option::is_some`]
- [`Option::is_none`]
- [`Option::as_ref`]
- [`Result::is_ok`]
- [`Result::is_err`]
- [`Result::as_ref`]
- [`Ordering::reverse`]
- [`Ordering::then`]

Cargo
-----

Rustdoc
-------
- [You can now link to items in `rustdoc` using the intra-doc link
  syntax.][74430] E.g. ``/// Uses [`std::future`]`` will automatically generate
  a link to `std::future`'s documentation. See ["Linking to items by
  name"][intradoc-links] for more information.
- [You can now specify `#[doc(alias = "<alias>")]` on items to add
  search aliases when searching through `rustdoc`'s UI.][75740]

Compatibility Notes
-------------------
- [Promotion of references to `'static` lifetime inside `const fn`
  now follows the same rules as inside a `fn` body.][75502] In
  particular, `&foo()` will not be promoted to `'static` lifetime
  any more inside `const fn`s.
- [Associated type bindings on trait objects are now verified to meet the bounds
  declared on the trait when checking that they implement the trait.][27675]
- [When trait bounds on associated types or opaque types are ambiguous, the
  compiler no longer makes an arbitrary choice on which bound to use.][54121]
- [Fixed recursive nonterminals not being expanded in macros during
  pretty-print/reparse check.][77153] This may cause errors if your macro wasn't
  correctly handling recursive nonterminal tokens.
- [`&mut` references to non zero-sized types are no longer promoted.][75585]
- [`rustc` will now warn if you use attributes like `#[link_name]` or `#[cold]`
  in places where they have no effect.][73461]
- [Updated `_mm256_extract_epi8` and `_mm256_extract_epi16` signatures in
  `arch::{x86, x86_64}` to return `i32` to match the vendor signatures.][73166]
- [`mem::uninitialized` will now panic if any inner types inside
  a struct or enum disallow zero-initialization.][71274]
- [`#[target_feature]` will now error if used in a place where it
  has no effect.][78143]
- [Foreign exceptions are now caught by `catch_unwind` and will
  cause an abort.][70212] Note: This behaviour is not guaranteed
  and is still considered undefined behaviour, see the [`catch_unwind`]
  documentation for further information.

Internal Only
-------------
These changes provide no direct user facing benefits, but represent significant
improvements to the internals and overall performance of rustc and
related tools.

- [Building `rustc` from source now uses `ninja` by default over `make`.][74922]
  You can continue building with `make` by setting `ninja=false` in
  your `config.toml`.
- [cg_llvm: `fewer_names` in `uncached_llvm_type`][76030]
- [Made `ensure_sufficient_stack()` non-generic][76680]

[78143]: rust-lang/rust#78143
[76680]: rust-lang/rust#76680
[76030]: rust-lang/rust#76030
[70212]: rust-lang/rust#70212
[27675]: rust-lang/rust#27675
[54121]: rust-lang/rust#54121
[71274]: rust-lang/rust#71274
[77386]: rust-lang/rust#77386
[77153]: rust-lang/rust#77153
[77055]: rust-lang/rust#77055
[76275]: rust-lang/rust#76275
[76310]: rust-lang/rust#76310
[76420]: rust-lang/rust#76420
[76158]: rust-lang/rust#76158
[75857]: rust-lang/rust#75857
[75585]: rust-lang/rust#75585
[75740]: rust-lang/rust#75740
[75502]: rust-lang/rust#75502
[74880]: rust-lang/rust#74880
[74922]: rust-lang/rust#74922
[74430]: rust-lang/rust#74430
[74194]: rust-lang/rust#74194
[73461]: rust-lang/rust#73461
[73166]: rust-lang/rust#73166
[intradoc-links]: https://doc.rust-lang.org/rustdoc/linking-to-items-by-name.html
[`catch_unwind`]: https://doc.rust-lang.org/std/panic/fn.catch_unwind.html
[`Option::is_some`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.is_some
[`Option::is_none`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.is_none
[`Option::as_ref`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.as_ref
[`Result::is_ok`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.is_ok
[`Result::is_err`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.is_err
[`Result::as_ref`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.as_ref
[`Ordering::reverse`]: https://doc.rust-lang.org/std/cmp/enum.Ordering.html#method.reverse
[`Ordering::then`]: https://doc.rust-lang.org/std/cmp/enum.Ordering.html#method.then
[`slice::as_ptr_range`]: https://doc.rust-lang.org/std/primitive.slice.html#method.as_ptr_range
[`slice::as_mut_ptr_range`]: https://doc.rust-lang.org/std/primitive.slice.html#method.as_mut_ptr_range
[`VecDeque::make_contiguous`]: https://doc.rust-lang.org/std/collections/struct.VecDeque.html#method.make_contiguous
[`future::pending`]: https://doc.rust-lang.org/std/future/fn.pending.html
[`future::ready`]: https://doc.rust-lang.org/std/future/fn.ready.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. merged-by-bors This PR was explicitly merged by bors. relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet