Deprecate linked_list_extras methods.
#74644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #73265) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Rebased. |
|
@rust-lang/libs Do we want to add a deprecation period for these unstable methods or can we just remove them directly? |
|
I think I would prefer having a deprecation period. We did that for |
|
@crlf0710 Could you change your PR to deprecate these methods instead of removing them? |
|
Sure, will do. |
|
@bors r+ |
|
📌 Commit dc21178 has been approved by |
bors
added
S-waiting-on-bors
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 31, 2020
Remove `linked_list_extras` methods. Removing these in favor of the `Cursor` API in rust-lang#58533 . Closes rust-lang#27794. r? @Amanieu
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 31, 2020
Rollup of 6 pull requests Successful merges: - rust-lang#74644 (Remove `linked_list_extras` methods.) - rust-lang#74968 (Run all tests if have no specified tests) - rust-lang#74982 (1.45.2 release notes) - rust-lang#74984 (Miri: fix ICE when unwinding past topmost stack frame) - rust-lang#74986 (fix part of comparison that would always evaluate to "true", probably an oversight) - rust-lang#74991 (Fix Const-Generic Cycle ICE rust-lang#74199) Failed merges: r? @ghost
crlf0710
changed the title
linked_list_extras methods.linked_list_extras methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing these in favor of the
CursorAPI in #58533 .Closes #27794.
r? @Amanieu